[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |WONTFIX
 Whiteboard|AwaitingSubmitter   |
  Flags|fedora-review?  |fedora-review-
Last Closed||2020-04-23 12:48:16





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response
should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623

Dridi Boukelmoune  changed:

   What|Removed |Added

  Flags|needinfo?(dridi.boukelmoune |
   |@gmail.com) |



--- Comment #12 from Dridi Boukelmoune  ---
Apologies for the long silence, I'm barely keeping my Fedora commitments afloat
these days.

Feel free to either take over or close this ticket.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623

Petr Pisar  changed:

   What|Removed |Added

  Flags||needinfo?(dridi.boukelmoune
   ||@gmail.com)



--- Comment #11 from Petr Pisar  ---
Dridi, if you don't write that you want continue in this review, I will close
it as a dead one.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623

Petr Pisar  changed:

   What|Removed |Added

 Whiteboard||AwaitingSubmitter



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623



--- Comment #10 from Sergio Monteiro Basto  ---
Dridi, can I take this review , i.e. do a new review and close this one ? 

Thanks,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623



--- Comment #9 from Dridi Boukelmoune  ---
Hello Sergio and Petr, I have been away for a couple weeks but now that I am
back I'm planning to make progress on this review request and a bunch of others
(both as reviewer or submitter).

Thank you for the initial review, I will try to be more reactive and update the
spec and SPRM soon. Apologies for the non-responsiveness until now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623



--- Comment #8 from Sergio Monteiro Basto  ---
Dridi, you need update strip-nondeterminism.spec according to above mentioned,
to continue the review , until Peter approve this package .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623



--- Comment #7 from Petr Pisar  ---
Ok. Dridi, please update the spec file according to above mentioned advice and
notify me here after doing so. I will then resume the full-featured formal
review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623

Neal Gompa  changed:

   What|Removed |Added

   Assignee|ngomp...@gmail.com  |ppi...@redhat.com
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623



--- Comment #6 from Neal Gompa  ---
@Petr, I'm happy to hand this off to you, as I only grabbed it because he
seemed to be asking for reviewers. An expert is always better. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623



--- Comment #5 from Petr Pisar  ---
Neal seems interested in reviewing this package. Thus only few notes from me:

The URL value point to an umbrella project, not the the strip-nondeterminism
itself. I'd rather use
 as the URL
value.

The Makefile.PL has some dependencies you missed. Please build-require
"perl(strict)" and "perl(warnings)".

The perl-File-StripNondeterminism subpackage delivers Perl modules into a
standard Perl look-up path. That means the subpackage must run-require
perl(:MODULE_COPMAT...). See

for the specific spec code to use.

The perl-File-StripNondeterminism package must own the File subdirectory. Use
"%{perl_vendorlib}/*" instead of "%{perl_vendorlib}/File/*" in the %files
sections.

You should execute tests. Add %check section with "make test" and build-require
"make" and all the Perl modules used when running the tests (e.g.
"perl(Test::More)". Don't forget the tests execute some scripts, e.g.
bin/strip-nondeterminism, so you also need build-require their dependencies. We
have a "tangerine" tool that can help you to scan the files for the used Perl
modules.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623



--- Comment #4 from Dridi Boukelmoune  ---
I'm ok with epel7, I would have objected to maintain it for epel6 myself :)

And the packlist question is exactly why I asked for perl-experienced
co-maintainers for this package, sbuild and apt. I can dig that kind of
problems but it will take me much more time when the midden hits the windmill.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com



--- Comment #3 from Petr Pisar  ---
(In reply to Sergio Monteiro Basto from comment #2)
> BUILDSTDERR: Installed (but unpackaged) file(s) found:
> BUILDSTDERR:   
> /usr/lib64/perl5/vendor_perl/auto/File/StripNondeterminism/.packlist
> 
See . I.e. if you
use NO_PACKLIST=1, you have to buil-require perl(ExtUtils::MakeMaker) >= 6.76.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623



--- Comment #2 from Sergio Monteiro Basto  ---
It would be nice if we support epel 7 at least, I got this error [1] complete
logs [2] 
Thanks

[1]
BUILDSTDERR: Installed (but unpackaged) file(s) found:
BUILDSTDERR:   
/usr/lib64/perl5/vendor_perl/auto/File/StripNondeterminism/.packlist

[2] 
https://copr-be.cloud.fedoraproject.org/results/sergiomb/debs/epel-7-x86_64/00860413-strip-nondeterminism/
https://copr-be.cloud.fedoraproject.org/results/sergiomb/debs/epel-7-x86_64/00860413-strip-nondeterminism/build.log.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1678623] Review Request: strip-nondeterminism - File non-deterministic information stripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1678623

Dridi Boukelmoune  changed:

   What|Removed |Added

  Alias||strip-nondeterminism



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org