[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2021-01-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Kevin Fenzi  changed:

   What|Removed |Added

 CC||ke...@scrye.com
  Flags|needinfo?(bazanluis20@gmail |
   |.com)   |
   |needinfo?(lead2gold@gmail.c |
   |om) |
   |needinfo?(package-review@li |
   |sts.fedoraproject.org)  |



--- Comment #16 from Kevin Fenzi  ---
If you would like to package elpy emacs, please take a look at
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers 

You can ask questions on the devel list and/or ask someone else to package it
up if you prefer...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2021-01-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

ivano...@riseup.net changed:

   What|Removed |Added

 CC||ivano...@riseup.net
  Flags||needinfo?(bazanluis20@gmail
   ||.com)
   ||needinfo?(lead2gold@gmail.c
   ||om)
   ||needinfo?(package-review@li
   ||sts.fedoraproject.org)



--- Comment #15 from ivano...@riseup.net ---
Hello! It's great that we have rpm for elpy python package, but how should it
work without rpm for elpy emacs package? 

Sorry, I'm a newbie with Emacs and would to use it as an editor for a python
code with my Fedora machine. I know that Emacs has its own package manager, but
I prefer to use system packages if available.

Should I create a request for emacs-elpy rpm?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


needinfo requested: [Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2021-01-08 Thread bugzilla


Product: Fedora
Version: rawhide
Component: Package Review

ivano...@riseup.net has asked Package Review
 for needinfo:
Bug 1691610: Review Request: python-elpy - Backend for the elpy Emacs mode
https://bugzilla.redhat.com/show_bug.cgi?id=1691610



--- Comment #15 from ivano...@riseup.net ---
Hello! It's great that we have rpm for elpy python package, but how should it
work without rpm for elpy emacs package? 

Sorry, I'm a newbie with Emacs and would to use it as an editor for a python
code with my Fedora machine. I know that Emacs has its own package manager, but
I prefer to use system packages if available.

Should I create a request for emacs-elpy rpm?
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-04-27 21:26:50



--- Comment #14 from Fedora Update System  ---
python-elpy-1.29.1-1.fc30 has been pushed to the Fedora 30 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
python-elpy-1.29.1-1.fc30 has been pushed to the Fedora 30 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-f3592cb035

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #12 from Fedora Update System  ---
python-elpy-1.29.1-1.fc30 has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-f3592cb035

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610



--- Comment #11 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-elpy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610



--- Comment #10 from Luis Bazan  ---
(In reply to Chris Caron from comment #9)
> My apologies Luis; :)
> 
> Done.

No problem! Thanks!

Cheers,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Chris Caron  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #9 from Chris Caron  ---
My apologies Luis; :)

Done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Luis Bazan  changed:

   What|Removed |Added

  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Luis Bazan  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610



--- Comment #8 from Luis Bazan  ---
Thanks Chris --

Can you change the flag to + 

Cheers,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Chris Caron  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #7 from Chris Caron  ---
> I not change the buildrequires:

No problem

As per the review; great job.  i have no qualms!

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= Comments 
- I realize you've acknowledged that there is a bug not allowing you to run the
tests.  I just want to identify that i recognize this and you've documented it
accordingly in the spec (and this ticket) :) so i don't personally see a
problem here.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "GPL (v3 or later)".
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUST
 use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec 

[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610



--- Comment #5 from Luis Bazan  ---
Please continue the review.

Cheers,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610



--- Comment #6 from Luis Bazan  ---
SPEC: https://lbazan.fedorapeople.org/python-elpy.spec
SRPM: https://lbazan.fedorapeople.org/python-elpy-1.29.1-1.fc30.src.rpm

Test disable:
https://github.com/jorgenschaefer/elpy/issues/1581

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610



--- Comment #4 from Luis Bazan  ---
 let me fix some problems in test

Please ignore.. do not review the new spec.

test_should_refactor_global (elpy.tests.test_refactor.TestExtractMethod) ...
skipped 'Python 3.5 not supported'
test_should_refactor_local (elpy.tests.test_refactor.TestExtractMethod) ...
skipped 'Python 3.5 not supported'

Cheers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610



--- Comment #3 from Luis Bazan  ---
Hi Chris --

Fixed:
source URL
License typo
changelog typo
test enable
dependency generator

Update to new version 1.29.1

I not change the buildrequires:
https://fedoraproject.org/wiki/User:Bkabrda/EPEL7_Python3 <- this is a draft
when this project approved I change to the new format.

SPEC: https://lbazan.fedorapeople.org/python-elpy.spec
SRPM: https://lbazan.fedorapeople.org/python-elpy-1.29.1-1.fc30.src.rpm

Cheers,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Luis Bazan  changed:

   What|Removed |Added

 Status|ON_QA   |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Chris Caron  changed:

   What|Removed |Added

 Status|NEW |ON_QA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610



--- Comment #2 from Chris Caron  ---
Another minor comment, the %changelog is just missing a proper close > tag
after your email.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Chris Caron  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|lead2g...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Chris Caron  changed:

   What|Removed |Added

 CC||lead2g...@gmail.com



--- Comment #1 from Chris Caron  ---

Package Build
=
Builds Okay:
 - https://koji.fedoraproject.org/koji/taskinfo?taskID=34038420

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
===
- Sources used to build the package do not match the upstream source, as
provided
  in the spec URL. Checksum differences are provided at the bottom of this
review.
- Your .spec file identifies a GPL license, yet your GitHub page and tar.gz
file
  includes a GPLv3 license.  I imagine this is just a typo in your spec?
- You should have a peek at
https://fedoraproject.org/wiki/User:Bkabrda/EPEL7_Python3.
  From here you'll see some things you're doing nicely and some spots you just
need
  a few tweeks such as:
 - drop reference to %{?python_enable_dependency_generator}
 - BuildRequires: %{py3_dist coverage} should read:
   BuildRequires: python%{python3_pkgversion}-coverage
 -  You need to apply this to all of the BuildRequrires.
- There are a few rpmlint warnings below which are not show-stoppers by any
means, but
  useful to show as you can optionally fix them up too! :)
- %check is disabled; but i can see that recently python-yapf (bz#1691609) has
been pushed
  upstream now. So you can turn that back on and try it out to see how it works
for you.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "GPL (v3 or later)". 307 files have
 unknown license. Detailed output of licensecheck in
 /home/l2g/Development/reviews/review-python-elpy/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging 

[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-04-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610
Bug 1691610 depends on bug 1691609, which changed state.

Bug 1691609 Summary: Review Request: python-yapf - A formatter for Python code
https://bugzilla.redhat.com/show_bug.cgi?id=1691609

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1691610] Review Request: python-elpy - Backend for the elpy Emacs mode

2019-03-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1691610

Luis Bazan  changed:

   What|Removed |Added

 Depends On||1691609




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1691609
[Bug 1691609] Review Request: python-yapf - A formatter for Python code
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org