[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Fedora Update System changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |ERRATA Last Closed||2020-02-26 17:59:01 --- Comment #37 from Fedora Update System --- pre-commit-2.1.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #36 from Aniket Pradhan --- > Hi, pushed to repos. I'll add @Miro, @major, @chedi as co-maintainers. Thanks for this @artem. I will start working on the package pre-commit was a dep for. :D -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #35 from Artem --- @Miro, sure! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #34 from Miro Hrončok --- Can I add @python-sig as well? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #33 from Artem --- (In reply to chedi toueiti from comment #31) > congrats, when can we expect the package to be added to > src.fedoraproject.org and be buildable in koji/bodhi ? Hi, pushed to repos. I'll add @Miro, @major, @chedi as co-maintainers. https://bodhi.fedoraproject.org/updates/FEDORA-2020-1473a3f45a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #32 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pre-commit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #31 from chedi toueiti --- congrats, when can we expect the package to be added to src.fedoraproject.org and be buildable in koji/bodhi ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #30 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 chedi toueiti changed: What|Removed |Added CC||chedi.toue...@gmail.com --- Comment #29 from chedi toueiti --- Hi everybody, I would like to help with this package if possible as I'm one of the maintainers of python3-molecule that recently has added pre-commit as a runtime dependency. Hope this get released for before the next release freeze -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #28 from Artem --- Latest 1.21.0 version https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-rawhide-x86_64/01167933-pre-commit/pre-commit.spec https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-rawhide-x86_64/01167933-pre-commit/pre-commit-1.21.0-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #27 from Artem --- (In reply to Aniket Pradhan from comment #26) > @artem, since you had opened this request, then maybe you would have to > provide the final spec/srpm which can be reviewed upon. Sure. Will do shortly. And @Aniket i'll add you with full permission and full control of package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #26 from Aniket Pradhan --- Hello everyone! Can we push this request further? The patches are no longer required in the new version of pre-commit. @artem, since you had opened this request, then maybe you would have to provide the final spec/srpm which can be reviewed upon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #25 from Aniket Pradhan --- > spec: https://major.fedorapeople.org/pre-commit/pre-commit.spec > srpm: > https://major.fedorapeople.org/pre-commit/pre-commit-1.20.0-1.fc31.src.rpm Updated the files above. The package now builds perfectly fine. > The scratch build fails with some ambiguous reason: line 43: /usr/bin/git: > No such file or directory I just had to fix the ordering of the lines, so not much of an issue. Here [0] is the scratch build for the same. [0]: https://koji.fedoraproject.org/koji/taskinfo?taskID=39563479 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Bug 1694366 depends on bug 1765265, which changed state. Bug 1765265 Summary: Review Request: python-identify - File identification library for Python https://bugzilla.redhat.com/show_bug.cgi?id=1765265 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #24 from Aniket Pradhan --- Hey! Thanks for providing the files. I changed the name of the package, hence the path changed :P Here are the new files: spec: https://major.fedorapeople.org/pre-commit/pre-commit.spec srpm: https://major.fedorapeople.org/pre-commit/pre-commit-1.20.0-1.fc31.src.rpm The scratch build fails with some ambiguous reason: line 43: /usr/bin/git: No such file or directory Here is the scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=39460974 The package builds fine locally. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #23 from Artem --- https://atim.fedorapeople.org/for-review/pre-commit.spec https://atim.fedorapeople.org/for-review/pre-commit-1.20.0-1.fc32.src.rpm Full build log with enabled tests: https://atim.fedorapeople.org/for-review/build.log > I am not able to get the latest spec/srpm (getting a 404). Copr died today. I wrote in #fedora-buildsys about this. I can't check your spec and srpm as well - 404. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #22 from Miro Hrončok --- > how to apply the patches Does "%autosetup -p1" help? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #21 from Aniket Pradhan --- Hello everyone! I am not able to get the latest spec/srpm (getting a 404). Anyways, I had written a spec as I was not aware of this request. Out of all the failing tests, only one test fails as they only make sense when testing on a virtual environment [0] (that test also requires pytest-env, not yet packaged for Fedora). We can disable that test and proceed further on. We would also need to apply some patches to fix the remaining of the failing tests [1]-[2]. Other than that, here is my attempt at writing up a spec: https://major.fedorapeople.org/python-pre-commit/python-pre-commit.spec SRPM: https://major.fedorapeople.org/python-pre-commit/python-pre-commit-1.20.0-1.fc31.src.rpm The scratch build fails because I am not sure how to apply the patches for the same. For now, I have added the patches/diffs in the same directory. I will change the name of the package as discussed above. [0]: https://github.com/pre-commit/pre-commit/issues/1235#issuecomment-562868123 [1]: https://github.com/pre-commit/pre-commit/pull/1236 [2]: https://github.com/pre-commit/pre-commit/pull/1237 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Bug 1694366 depends on bug 1765265, which changed state. Bug 1765265 Summary: Review Request: python-identify - File identification library for Python https://bugzilla.redhat.com/show_bug.cgi?id=1765265 What|Removed |Added Status|POST|CLOSED Resolution|--- |EOL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Bug 1694366 depends on bug 1765196, which changed state. Bug 1765196 Summary: Review Request: python-aspy.yaml - Few extensions to pyyaml https://bugzilla.redhat.com/show_bug.cgi?id=1765196 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Bug 1694366 depends on bug 1765263, which changed state. Bug 1765263 Summary: Review Request: python-cfgv - Validate configuration and produce human readable error messages https://bugzilla.redhat.com/show_bug.cgi?id=1765263 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #20 from Anna Khaitovich --- Failed dependencies that I found: Package that is obsolete in Fedora: 'python3dist(importlib-metadata)': [1] Packages that have open Fedora Review requests: 'python3dist(aspy.yaml)': [2] 'python3dist(identify) >= 1.0.0' [3] [1] https://bugzilla.redhat.com/show_bug.cgi?id=1754151 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1765196 [3] https://bugzilla.redhat.com/show_bug.cgi?id=1765265 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #19 from Miro Hrončok --- I will gladly co-maintain this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #18 from Artem --- @Miro, thank you, learned a lot from you. > Here: > https://github.com/pre-commit/pre-commit/commit/f8f81db36d3f43cee3a73e3377ce07df93b54d0e This fixed and now it compiles fine with new python 3.8 in Rawhide. --- There is still some test which we need to fix or disable few of them: == 33 failed, 557 passed, 6 skipped in 122.10 seconds == --- For learning purposes i will choice another package next time, because IMHO this package is pretty serious and truth to be told i don't even need it now for my initial package which i want to have in repos, so i definitely ask for help you and co-maintain this pre-commit. Also i updating my package very quickly usually, but maybe i will not have to much time in future but this package requires good maintenance. All required packages for pre-commit packaged BTW, few of them still on review. --- https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01080573-pre-commit/pre-commit.spec https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01080573-pre-commit/pre-commit-1.18.3-8.fc31.src.rpm --- Build log F31: https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01080573-pre-commit/builder-live.log.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #17 from Miro Hrončok --- Here: https://github.com/pre-commit/pre-commit/commit/f8f81db36d3f43cee3a73e3377ce07df93b54d0e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #16 from Miro Hrončok --- f31: E git config --global user.email "y...@example.com" E git config --global user.name "Your Name" actually do that before running the tests rawhide: pre_commit/constants.py:4: in import importlib_metadata # TODO: importlib.metadata py38? E ModuleNotFoundError: No module named 'importlib_metadata' This will need an upstream patch. I can help, or if you want to try yourself, here are some examples: https://github.com/pytest-dev/pluggy/pull/223 https://github.com/pytest-dev/pytest/pull/5539 https://github.com/tox-dev/tox/pull/1368 (unless this is already fixed in pre-commit master) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #15 from Artem --- Miro Hrončok, thank you. Fixed a little bit... https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079306-pre-commit/pre-commit.spec https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079306-pre-commit/pre-commit-1.18.3-5.fc31.src.rpm --- Build log for F31: https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079306-pre-commit/builder-live.log Build log for Rawhide: https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-rawhide-x86_64/01079306-pre-commit/builder-live.log.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366
--- Comment #14 from Miro Hrončok ---
And please replace:
%{python3_sitelib}/pre_commit
%{python3_sitelib}/pre_commit-%{version}-py?.?.egg-info
With:
%{python3_sitelib}/pre_commit/
%{python3_sitelib}/pre_commit-%{version}-py%{python3_version}.egg-info/
The slashes make sure this will always remain a directory. The ?.? glob would
break with Python 3.10.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #13 from Miro Hrončok --- Another thing, I suggest using https://pre-commit.com as the URL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366
--- Comment #12 from Miro Hrončok ---
> ImportError: cannot import name 'windll' from 'ctypes'
Sounds very windows-y. Are you sure the way you run the test in %check is
correct? Try running them with pytest maybe, as does upstream.
%check
%{python3} -m pytest -v
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #11 from Artem --- (In reply to Miro Hrončok from comment #10) > BuildRequires: python3dist(importlib-metadata) > > This needs to be conditionalized for Fedora <= 31. ✅ https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079278-pre-commit/pre-commit.spec ✅ https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079278-pre-commit/pre-commit-1.18.3-5.fc31.src.rpm --- But we still need to fix tests. Now we here: empty_template_setup (unittest.loader._FailedTest) ... ERROR color_windows (unittest.loader._FailedTest) ... ERROR ImportError: cannot import name 'windll' from 'ctypes' (/usr/lib64/python3.7/ctypes/__init__.py) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #10 from Miro Hrončok --- BuildRequires: python3dist(importlib-metadata) This needs to be conditionalized for Fedora <= 31. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #9 from Artem --- All required packages packaged. pre-commit compiles and works, but without Tests. So TODO: fix Tests... https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079241-pre-commit/pre-commit.spec https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079241-pre-commit/pre-commit-1.18.3-4.fc31.src.rpm Build log: https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079241-pre-commit/builder-live.log.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Artem changed: What|Removed |Added Depends On||1765265 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1765265 [Bug 1765265] Review Request: python-identify - File identification library for Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Artem changed: What|Removed |Added Depends On||1765263 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1765263 [Bug 1765263] Review Request: python-cfgv - Validate configuration and produce human readable error messages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #8 from Artem --- https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079109-pre-commit/pre-commit.spec https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079109-pre-commit/pre-commit-1.18.3-3.fc31.src.rpm We also need package 'python-identify' for pre-commit. Required for Tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Artem changed: What|Removed |Added Depends On||1765196 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1765196 [Bug 1765196] Review Request: python-aspy.yaml - Few extensions to pyyaml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
