[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 Robert-André Mauchin changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-06-20 11:40:54 --- Comment #12 from Robert-André Mauchin --- Will build with the mass rebuild. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 Elliott Sales de Andrade changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #11 from Elliott Sales de Andrade --- LGTM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 --- Comment #10 from Robert-André Mauchin --- (In reply to Elliott Sales de Andrade from comment #8) > I don't see times in the prescribed Changelog format: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs > This is the new thangelog format in rpm 4.14. > Also, a heads up that upstream is thinking of switching from calver to > semver: > https://github.com/certifi/gocertifi/pull/10#issuecomment-481493704 > so you may want to start versioning at 0.2018.01.08 (or similar) to allow > for easier upgrades once they do that. > I've versioned it almost as you said: 0.0.20180108 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 --- Comment #9 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-certifi-gocertifi.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-certifi-gocertifi-0.0.20180118-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361
Elliott Sales de Andrade changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review?
--- Comment #8 from Elliott Sales de Andrade ---
I don't see times in the prescribed Changelog format:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
Also, a heads up that upstream is thinking of switching from calver to semver:
https://github.com/certifi/gocertifi/pull/10#issuecomment-481493704
so you may want to start versioning at 0.2018.01.08 (or similar) to allow for
easier upgrades once they do that.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* Mozilla Public License (v2.0)", "Unknown or
generated". 4 files have unknown license. Detailed output of
licensecheck in 1696361-golang-github-certifi-gocertifi/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 --- Comment #7 from Robert-André Mauchin --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=34086458 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 --- Comment #6 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-certifi-gocertifi.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-certifi-gocertifi-2018.01.18-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 --- Comment #5 from Robert-André Mauchin --- Right, sorry, searching certifi in Pagure didn't return any entry so I have no idea what Python and Erlang were doing. Thanks for all the infos. I'm testing the package and will update the bug asap. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 --- Comment #4 from Elliott Sales de Andrade --- The Erlang certifi bundles ca certs [1], but the Fedora package does not [2]. The Python certifi bundles ca certs [3], but the Fedora package does not [4]. This Go package contains bundled ca certs [5] that should be removed. [1] https://github.com/certifi/erlang-certifi/blob/master/priv/cacerts.pem [2] https://src.fedoraproject.org/rpms/erlang-certifi/blob/master/f/erlang-certifi-enforce_fedora_ca_bundle.patch [3] https://github.com/certifi/python-certifi/blob/master/certifi/cacert.pem [4] https://src.fedoraproject.org/rpms/python-certifi/blob/master/f/certifi-2018.10.15-use-system-cert.patch [5] https://github.com/certifi/gocertifi/blob/master/certifi.go#L14 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 --- Comment #3 from Robert-André Mauchin --- Updated the license. (In reply to Elliott Sales de Andrade from comment #2) > Given that the Erlang and Python versions of this package just refer to the > system directories, I think you will have to do similar patching here. > Sorry what do you mean? Patching what? I don't see what the Erlang or Python have to de with system directories. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #2 from Elliott Sales de Andrade --- Given that the Erlang and Python versions of this package just refer to the system directories, I think you will have to do similar patching here. Also, you forgot to fill the License tag. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1696361] Review Request: golang-github-certifi-gocertifi - Carefully curated collection of root certificates
https://bugzilla.redhat.com/show_bug.cgi?id=1696361 --- Comment #1 from Robert-André Mauchin --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33954922 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
