[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 Dan Radez changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-04-12 12:33:57 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-tempora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin --- All good, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 --- Comment #4 from Dan Radez --- (In reply to Raphael Groner from comment #1) > Are you interested in a review swap? Maybe you can continue to look into bug > #1669793 when I managed to provide the requested fixes. Sry I didn't get to review your package. Looks like you've got some discussion going on on it now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 --- Comment #3 from Dan Radez --- I've removed the requires and reuploaded the spec and srpm Thanks for the review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #2 from Robert-André Mauchin --- - Requires are not in the right place, they should be under the python3 subpackage: Requires: python3dist(freezegun) Requires: python3dist(jaraco-functools) >= 1.20 Requires: python3dist(pytz) Requires: python3dist(six) Note that we have https://fedoraproject.org/wiki/Changes/EnablingPythonGenerators by default now, so you can skip adding them or add %?python_enable_dependency_generator for older Fedora. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 22 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-tempora/review-python- tempora/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains Conflicts: tag(s) needing fix or justification. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %p
[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #1 from Raphael Groner --- Are you interested in a review swap? Maybe you can continue to look into bug #1669793 when I managed to provide the requested fixes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 Bug 1697687 depends on bug 1696399, which changed state. Bug 1696399 Summary: Review Request: python-jaraco-functools - Functools like those found in stdlib https://bugzilla.redhat.com/show_bug.cgi?id=1696399 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 Dan Radez changed: What|Removed |Added Blocks||1697711 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1697711 [Bug 1697711] Review Request: python-portend - TCP port monitoring utilities -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 Dan Radez changed: What|Removed |Added Blocks||1411746 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1411746 [Bug 1411746] python3-cherrypy-18.1.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1697687] Review Request: python-tempora - Objects and routines pertaining to date and time (tempora).
https://bugzilla.redhat.com/show_bug.cgi?id=1697687 Dan Radez changed: What|Removed |Added Depends On||1696399 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1696399 [Bug 1696399] Review Request: python-jaraco-functools - Functools like those found in stdlib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org