[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #19 from Fedora Update System --- kim-api-2.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #18 from Fedora Update System --- kim-api-2.0.2-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #17 from Christoph Junghans --- The actual models are in a different package, which is under review here: https://bugzilla.redhat.com/show_bug.cgi?id=1703235 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #16 from Fedora Update System --- kim-api-2.0.2-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-04-24 22:58:38 --- Comment #15 from Fedora Update System --- kim-api-2.0.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 Christoph Junghans changed: What|Removed |Added CC||upstream-release-monitoring ||@fedoraproject.org --- Comment #14 from Christoph Junghans --- *** Bug 1700469 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #13 from Fedora Update System --- kim-api-2.0.2-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1eec88ee5d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #12 from Fedora Update System --- kim-api-2.0.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-4434bd815d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #11 from Fedora Update System --- kim-api-2.0.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8cb688e233 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- kim-api-2.0.2-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-be96c73ae9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #9 from Fedora Update System --- kim-api-2.0.2-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-4434bd815d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #8 from Fedora Update System --- kim-api-2.0.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8cb688e233 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #7 from Fedora Update System --- kim-api-2.0.2-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1eec88ee5d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- kim-api-2.0.2-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-be96c73ae9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kim-api -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 --- Comment #4 from Christoph Junghans --- (In reply to Robert-André Mauchin from comment #3) > LGTM, package approved. Thanks. https://pagure.io/releng/fedora-scm-requests/issue/11065 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487
--- Comment #2 from Christoph Junghans ---
(In reply to Robert-André Mauchin from comment #1)
> - Not used:
>
> BuildRoot: %{_tmppath}/%{name}-%{version}-build
Removed
>
> - Missing isa:
>
> Requires: %{name}%{?_isa} = %{version}-%{release}
Added
>
> - mkdir -p %{buildroot}/usr/share/cmake/kim-api
>
> →
>
> mkdir -p %{buildroot}%{_datadir}/cmake/kim-api
Changed
>
> - Own %{_libexecdir}/kim-api
>
> %dir %{_libexecdir}/kim-api
Added
>
> - In onder to avoid unirtentional soname bumps, globbing the major soname
> version is now forbidden, be more specific instead:
>
> %{_libdir}/libkim-api.so.*
Added, %global sover
>
> - use %global, not %define
Changed
> [!]: Package requires other packages for directories it uses.
> Note: No known owner of /usr/libexec/kim-api
Fixed.
> [!]: Buildroot is not present
> Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-build
> See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
Fixed.
> [!]: Fully versioned dependency in subpackages if applicable.
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kim-api
> , kim-api-devel , kim-api-examples
Fixed
> [!]: Spec use %global instead of %define unless justified.
> Note: %define requiring justification: %define compdir %(pkg-config
> --variable=completionsdir bash-completion), %define compdir
> "/etc/bash_completion.d"
Fixed
Spec URL: https://junghans.fedorapeople.org/kim-api.spec
SRPM URL: https://junghans.fedorapeople.org/kim-api-2.0.2-2.fc31.src.rpm
TaskID: https://koji.fedoraproject.org/koji/taskinfo?taskID=34155946
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1699487] Review Request: kim-api - Open Knowledgebase of Interatomic Models KIM API
https://bugzilla.redhat.com/show_bug.cgi?id=1699487
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Not used:
BuildRoot: %{_tmppath}/%{name}-%{version}-build
- Missing isa:
Requires: %{name}%{?_isa} = %{version}-%{release}
- mkdir -p %{buildroot}/usr/share/cmake/kim-api
→
mkdir -p %{buildroot}%{_datadir}/cmake/kim-api
- Own %{_libexecdir}/kim-api
%dir %{_libexecdir}/kim-api
- In onder to avoid unirtentional soname bumps, globbing the major soname
version is now forbidden, be more specific instead:
%{_libdir}/libkim-api.so.*
- use %global, not %define
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Common Development and Distribution
License (v1.0)", "Common Development and Distribution License (v3.0)",
"Artistic License". 16 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/kim-api/review-kim-
api/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/libexec/kim-api
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/cmake(rapidjson-
devel, glm-devel, libwbxml-devel, python3-uranium, bash-completion,
python3-uranium-lulzbot, cmake-filesystem, cereal-devel, paraview-
devel, websocketpp-devel, libmodman-devel, viennacl-devel),
/usr/share/cmake/Modules(libwbxml-devel, python3-uranium, libmodman-
devel, python3-uranium-lulzbot, cmake-filesystem, libsolv-devel,
viennacl-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x
