[Bug 1699505] Review Request: rust-sd - An intuitive find & replace CLI

2019-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1699505
Bug 1699505 depends on bug 1699498, which changed state.

Bug 1699498 Summary: Review Request: rust-atomicwrites - Atomic file-writes
https://bugzilla.redhat.com/show_bug.cgi?id=1699498

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1699505] Review Request: rust-sd - An intuitive find & replace CLI

2019-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1699505

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2019-04-24 07:35:45



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1699505] Review Request: rust-sd - An intuitive find & replace CLI

2019-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1699505
Bug 1699505 depends on bug 1699493, which changed state.

Bug 1699493 Summary: Review Request: rust-unescape - Unescapes strings with 
escape sequences written out as literal characters
https://bugzilla.redhat.com/show_bug.cgi?id=1699493

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1699505] Review Request: rust-sd - An intuitive find & replace CLI

2019-04-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1699505



--- Comment #5 from Igor Gnatenko  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-sd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1699505] Review Request: rust-sd - An intuitive find & replace CLI

2019-04-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1699505



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
I forgot to add:
+ seems to work as advertised

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1699505] Review Request: rust-sd - An intuitive find & replace CLI

2019-04-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1699505

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
This is an automatically generated crate package, so just a quick check:
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ latest version

Package name matches executable name. The executable name is short, but does
not
seem to conflict with anything.

Package is APPROVED.

It would be useful to add a link to https://crates.io/crates/sd#quick-guide
somewhere. Maybe even both in --help output and %description.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1699505] Review Request: rust-sd - An intuitive find & replace CLI

2019-04-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1699505

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1699498
   ||(rust-atomicwrites),
   ||1699493 (rust-unescape)



--- Comment #2 from Robert-André Mauchin  ---
Thanks for the review.

I forgot to link the deps.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1699493
[Bug 1699493] Review Request: rust-unescape - Unescapes strings with escape
sequences written out as literal characters
https://bugzilla.redhat.com/show_bug.cgi?id=1699498
[Bug 1699498] Review Request: rust-atomicwrites - Atomic file-writes
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1699505] Review Request: rust-sd - An intuitive find & replace CLI

2019-04-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1699505

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
FTBFS in rawhide with:

No matching package to install: '(crate(atomicwrites/default) >= 0.2.2 with
crate(atomicwrites/default) < 0.3.0)'
No matching package to install: '(crate(unescape/default) >= 0.1.0 with
crate(unescape/default) < 0.2.0)'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org