[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 Ryan Curtin changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2019-11-19 03:42:39 --- Comment #26 from Ryan Curtin --- Oh, definitely, I just forgot to. Thank you again for your help! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #25 from Elliott Sales de Andrade --- Everything's stable now; can't we close this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #24 from Fedora Update System --- ensmallen-1.15.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #23 from Fedora Update System --- ensmallen-1.15.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #22 from Fedora Update System --- ensmallen-1.15.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #21 from Fedora Update System --- ensmallen-1.15.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b5dbfb1cb5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #20 from Fedora Update System --- ensmallen-1.15.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-96c517757d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System --- ensmallen-1.15.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e5d4aeaacc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #18 from Fedora Update System --- FEDORA-EPEL-2019-96c517757d has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-96c517757d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #17 from Fedora Update System --- FEDORA-2019-b5dbfb1cb5 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b5dbfb1cb5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #16 from Fedora Update System --- FEDORA-2019-e5d4aeaacc has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e5d4aeaacc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #15 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ensmallen -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #14 from Elliott Sales de Andrade --- No, it's approved already. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #13 from Ryan Curtin --- Thanks! And you're right, I did change the spec file after building the SRPM, but in this case I only changed comments. Sorry for any confusion. Does anything else need to be done by me here? And thanks again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659
Elliott Sales de Andrade changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #12 from Elliott Sales de Andrade ---
Your spec and srpm are not in sync; be sure to use the right one when you
import it.
Approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License", "Boost Software License BSL BSD 3-clause "New" or "Revised"
License", "*No copyright* BSL". 253 files have unknown license.
Detailed output of licensecheck in 1706659-ensmallen/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]:
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #11 from Ryan Curtin --- Ah, good point, disabling the SmallLovaszThetaSdp test is the better way to go. I'll try to keep digging and report a bug to the right place. The spec and SRPM are updated now; let me know what you think: http://www.ratml.org/misc/ensmallen.spec http://www.ratml.org/misc/ensmallen-1.15.1-1.fc31.src.rpm Thanks again for your review and help with this. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #10 from Elliott Sales de Andrade --- That indicates a real error: https://access.redhat.com/blogs/766093/posts/1976213 Please report a bug for it. Instead of disabling all the flags (and then possibly forgetting to re-enable them), I would skip the broken test instead by running: ./ensmallen_tests ~SmallLovaszThetaSdp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #9 from Ryan Curtin --- It took a while but I determined that the CXXFLAGS used by the %cmake macro cause the problem. Specifically, the -D_FORTIFY_SOURCE option causes the segfault. In any case, since ensmallen is not actually distributing that code and since the bug lies in some lower level library, I simply rewrote the spec to not use that particular flag. http://www.ratml.org/misc/ensmallen.spec http://www.ratml.org/misc/ensmallen-1.15.1-1.fc31.src.rpm (I also updated the version.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #8 from Elliott Sales de Andrade --- Well, unfortunately, it doesn't work on either Rawhide or F30 in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=35079859 https://koji.fedoraproject.org/koji/taskinfo?taskID=35080468 which is where you'll have to build it... Only failing on x86_64 is suspicious though, and looks a bit familiar. This may be an OpenBLAS (or something linking to it) bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #7 from Ryan Curtin --- I tried reproducing the issue in an fc31 docker container by running the tests over and over with different random seeds, but I wasn't able to reproduce it at all. It does look like a lower-level Armadillo bug perhaps, but even if I wanted to figure out what was going on and submit a patch I can't make heads or tails of the actual issue. What do you think? The package builds and tests successfully on my system (and the multiple Docker images I tested), so I don't know if it's worth digging into (unless I can reproduce it, which I currently can't). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659
--- Comment #6 from Elliott Sales de Andrade ---
Here is the backtrace if it's helpful? It looks like something is going wrong
in armadillo though.
#0 0x5564ebb4 in arma::Mat::~Mat (this=0x1,
__in_chrg=) at /usr/include/armadillo_bits/Mat_meat.hpp:23
#1 0x5574a594 in arma::auxlib::chol_band_common
(layout=, KD=, X=...)
at /usr/include/bits/string_fortified.h:34
#2 arma::auxlib::chol_band (layout=, KD=, X=...) at /usr/include/armadillo_bits/auxlib_meat.hpp:2008
#3 arma::op_chol::apply_direct > (A_expr=...,
layout=, out=...) at
/usr/include/armadillo_bits/op_chol_meat.hpp:72
#4 arma::op_chol::apply_direct > (layout=,
A_expr=..., out=...) at /usr/include/armadillo_bits/op_chol_meat.hpp:43
#5 arma::chol > (out=..., X=...,
layout=layout@entry=0x5578b6e4 "lower") at
/usr/include/armadillo_bits/fn_chol.hpp:59
#6 0x5573ae70 in ens::Alpha (A=..., dA=..., tau=0.98999,
alpha=@0x7fffb900: 4.9406564584124654e-323)
at
/builddir/build/BUILD/ensmallen-1.14.2/include/ensmallen_bits/sdp/primal_dual_impl.hpp:127
#7 0x55760ae6 in ens::PrimalDualSolver >
>::Optimize (this=this@entry=0x7fffd620, X=..., ysparse=...,
ydense=..., Z=...) at /usr/include/armadillo_bits/Glue_meat.hpp:47
#8 0x5573f9df in C_A_T_C_HT_E_S_T2 () at
/builddir/build/BUILD/ensmallen-1.14.2/tests/sdp_primal_dual_test.cpp:296
#9 0x555ee1f7 in Catch::TestCase::invoke (this=) at
/usr/include/c++/9/bits/shared_ptr_base.h:1020
#10 Catch::RunContext::invokeActiveTestCase (this=0x7fffe0c0) at
/builddir/build/BUILD/ensmallen-1.14.2/tests/catch.hpp:9745
#11 0x55601c7f in Catch::RunContext::runCurrentTest
(this=0x7fffe0c0, redirectedCout="", redirectedCerr="")
at /builddir/build/BUILD/ensmallen-1.14.2/tests/catch.hpp:9719
#12 0x55612280 in Catch::RunContext::runTest (this=0x7fffe0c0,
testCase=...)
at /builddir/build/BUILD/ensmallen-1.14.2/tests/catch.hpp:9495
#13 0x556167de in Catch::(anonymous namespace)::runTests
(config=std::shared_ptr (use count 4, weak count 0) = {...})
at /builddir/build/BUILD/ensmallen-1.14.2/tests/catch.hpp:10035
#14 Catch::Session::runInternal (this=0x7fffe320) at
/builddir/build/BUILD/ensmallen-1.14.2/tests/catch.hpp:10236
#15 0x55616c6f in Catch::Session::run (this=0x7fffe320) at
/builddir/build/BUILD/ensmallen-1.14.2/tests/catch.hpp:10193
#16 0x555e0ddb in Catch::Session::run (argv=0x7fffe598, argc=1,
this=0x7fffe320)
at /builddir/build/BUILD/ensmallen-1.14.2/tests/catch.hpp:10161
#17 Catch::Session::run (argv=0x7fffe598, argc=1, this=0x7fffe320) at
/builddir/build/BUILD/ensmallen-1.14.2/tests/catch.hpp:10156
#18 main (argc=1, argv=0x7fffe598) at
/builddir/build/BUILD/ensmallen-1.14.2/tests/main.cpp:33
What versions of everything do you get? Is one of us outdated somewhere?
Dependencies resolved.
==
Package Architecture
Version Repository Size
==
Installing:
armadillo-devel x86_64
9.400.3-1.fc31fedora 1.4 M
cmakex86_64
3.14.4-1.fc31 fedora 8.9 M
gcc-c++ x86_64
9.1.1-1.fc31 fedora 12 M
Installing dependencies:
SuperLU x86_64
5.2.1-6.fc30 fedora 169 k
SuperLU-develx86_64
5.2.1-6.fc30 fedora 23 k
annobin x86_64
8.76-1.fc31 fedora 180 k
armadillox86_64
9.400.3-1.fc31fedora 26 k
arpack x86_64
3.5.0-6.fc28 fedora 195 k
arpack-devel x86_64
3.5.0-6.fc28 fedora 12 k
atlasx86_64
3.10.3-8.fc30 fedora 6.3 M
atlas-devel
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #5 from Ryan Curtin --- I should add, since ensmallen is header-only, the tests are primarily of importance for ensuring everything compiles. They are also tests of the internal optimizers, but given that during development the issue you see hasn't been encountered at all, I'm not sure we can effectively resolve it at the packaging level. We could report it upstream (although I am part of upstream :)) but I have no idea how long it will take to even reproduce, and I don't know if it makes sense to hold up adding the package on that. (Especially since adding ensmallen is a dependency for new versions of mlpack, so mlpack can't be updated until then.) Let me know what you think, and thanks again for your time. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #4 from Ryan Curtin --- Hi Elliott, I spent a while working with it but I can't reproduce the segfault at all (I ran with tons of different random seeds). Do you think we should then just ignore running the tests in this case? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #3 from Elliott Sales de Andrade --- Putting %package and %description all the way at the end there is a bit odd; it's usually before %prep. Unfortunately, the tests segfault for me: + ./ensmallen_tests ensmallen version: 1.14.2 (Difficult Crimp) armadillo version: 9.400.3 (Surrogate Miscreant) ~~~ ensmallen_tests is a Catch v2.4.1 host application. Run with -? for options --- SmallLovaszThetaSdp --- /builddir/build/BUILD/ensmallen-1.14.2/tests/sdp_primal_dual_test.cpp:286 ... /builddir/build/BUILD/ensmallen-1.14.2/tests/sdp_primal_dual_test.cpp:286: FAILED: due to a fatal error condition: SIGSEGV - Segmentation violation signal === test cases: 102 | 101 passed | 1 failed assertions: 5732 | 5731 passed | 1 failed BUILDSTDERR: /var/tmp/rpm-tmp.xRlIat: line 31: 628 Segmentation fault (core dumped) ./ensmallen_tests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 --- Comment #2 from Ryan Curtin --- Hi Elliott, Thanks so much for your quick review. I handled each of the issues you pointed out and updated https://www.ratml.org/misc/ensmallen.spec and https://www.ratml.org/misc/ensmallen-1.14.2-1.fc30.src.rpm. > - The URL and Source look like they can use https://. Yeah, you're right, fixed. > - rm -rf $RPM_BUILD_ROOT should be removed Oops, didn't realize this was unnecessary. Gone now. > - You do not need to install LICENSE.txt manually; just list it as a relative > path and it will be installed for you. Ah, nice! I didn't know that. Thanks. > - Summary should not end in a period. Fixed. > - If you've built the tests, why not run them in %check? Good point, they run in %check now. > - %changelog is missing version-release Oops, simple oversight. Fixed now. > - This fails to build for me due to missing armadillo; why is it not in > BuildRequires also? (I don't think a new enough armadillo is packaged in > Fedora, though.) Ah, yeah, you're right, Armadillo should be `BuildRequires` also. It is now, and the versions in Fedora should be new enough that it isn't a problem (6.500.0 or newer is necessary, and that was quite a while ago now). Let me know if you see any other issues and I'll get them handled. Thanks again! Ryan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706659] Review Request: ensmallen - header-only C++ library for efficient mathematical optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1706659 Elliott Sales de Andrade changed: What|Removed |Added Status|NEW |ASSIGNED CC||quantum.anal...@gmail.com Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com Flags||fedora-review? --- Comment #1 from Elliott Sales de Andrade --- - The URL and Source look like they can use https://. - rm -rf $RPM_BUILD_ROOT should be removed - You do not need to install LICENSE.txt manually; just list it as a relative path and it will be installed for you. - Summary should not end in a period. - If you've built the tests, why not run them in %check? - %changelog is missing version-release - This fails to build for me due to missing armadillo; why is it not in BuildRequires also? (I don't think a new enough armadillo is packaged in Fedora, though.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
