[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 Raphael Groner changed: What|Removed |Added Whiteboard|NotReady| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 Raphael Groner changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||python-javabridge-1.0.18-3. ||20190729gitc7ccaed.fc32 Resolution|--- |RAWHIDE Last Closed||2020-02-08 09:13:41 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #17 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-javabridge -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #16 from Raphael Groner --- https://pagure.io/releng/fedora-scm-requests/issue/19764 Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|POST Flags||fedora-review+ --- Comment #15 from Zbigniew Jędrzejewski-Szmek --- + package name is OK + latest version (git snapshot) + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + BR/R/P look correct + package seems functional rpmlint: python3-javabridge.x86_64: E: description-line-too-long C The javabridge Python package makes it easy to start a Java virtual machine (JVM) → maybe "Start the Java VM from the Python interpreter" ? Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #14 from Raphael Groner --- https://github.com/LeeKamentsky/python-javabridge/issues/170 SPEC: https://raphgro.fedorapeople.org/review/py/python-javabridge/python-javabridge.spec SRPM: https://raphgro.fedorapeople.org/review/py/python-javabridge/python-javabridge-1.0.18-3.20190729gitc7ccaed.fc30.src.rpm https://koji.fedoraproject.org/koji/taskinfo?taskID=39019836 * Sat Jul 27 2019 Raphael Groner <> - 1.0.18-3.20190729gitc7ccaed * use new snapshot - exclusive x86 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #13 from Raphael Groner --- https://koji.fedoraproject.org/koji/taskinfo?taskID=39019772 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #12 from Raphael Groner --- The python warning seems to have been a bug in the build environment. % grep Warn build.log /usr/lib64/python3.7/site-packages/Cython/Compiler/Main.py:367: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /home/builder/rpmbuild/BUILD/python-javabridge-16d6c91c3aa9dbf8c80de1fc442aca696a6197fa/_javabridge_mac.pxd /usr/lib64/python3.7/site-packages/Cython/Compiler/Main.py:367: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /home/builder/rpmbuild/BUILD/python-javabridge-16d6c91c3aa9dbf8c80de1fc442aca696a6197fa/_javabridge_nomac.pxd Übereinstimmungen in Binärdatei build.log https://koji.fedoraproject.org/koji/taskinfo?taskID=39019569 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037
--- Comment #11 from Zbigniew Jędrzejewski-Szmek ---
(In reply to Raphael Groner from comment #10)
> Thanks for your advice. Though, I don't see any blockers to approve,
> otherwise please guide me in our official packaging guidelines.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> Missing: BR: gcc
https://docs.fedoraproject.org/en-US/packaging-guidelines/#buildrequires
> > Also, having a description for the binary package which does not get
> > created is strange.
> It's suggested in the official python sample. No idea if rpmbuild accepts an
> empty main description.
Hmm, I think I was totally wrong here, please ignore.
> > → maybe add BR: python%{python3_pkgversion}-coverage to avoid the warning?
> No, coverage is not relevant for the package build, that seems to be a
> feature for upstream only.
Ack.
> > It seems unversioned python is being called.
> I fail to see for what step of the build task this counts.
Calling unversioned python is against the guidelines
(https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python_version_support):
"Packages in Fedora MUST NOT use /usr/bin/python".
Among other things, it will also be allowed to have no /usr/bin/python
at all in local installations. /usr/bin/python3 should be called.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037
--- Comment #10 from Raphael Groner ---
Thanks for your advice. Though, I don't see any blockers to approve, otherwise
please guide me in our official packaging guidelines.
https://docs.fedoraproject.org/en-US/packaging-guidelines/
> Also, having a description for the binary package which does not get created
> is strange.
It's suggested in the official python sample. No idea if rpmbuild accepts an
empty main description.
> → maybe add BR: python%{python3_pkgversion}-coverage to avoid the warning?
No, coverage is not relevant for the package build, that seems to be a feature
for upstream only.
> It seems unversioned python is being called.
I fail to see for what step of the build task this counts.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
--- Comment #9 from Zbigniew Jędrzejewski-Szmek ---
Missing: BR: gcc
Something's off with the spacing in description:
$ rpm -qp --qf '%{description}'
/var/lib/mock/fedora-rawhide-x86_64/result/python3-javabridge-1.0.18-2.20190723git16d6c91.fc32.x86_64.rpm|nl
-ba
1
2 The javabridge Python package makes it easy to start a Java virtual
machine (JVM)
3 from Python and interact with it. Python code can interact with the JVM
using a
4 low-level API or a more convenient high-level API.
Also, having a description for the binary package which does not get created is
strange.
My suggestion:
%global _description %{expand:
The javabridge Python package makes it easy to start a Java virtual machine
(JVM)
from Python and interact with it. Python code can interact with the JVM using a
low-level API or a more convenient high-level API.}
%description %_description
%description -n python%{python3_pkgversion}-%{modname} %_description
From %check:
> nose.plugins.cover: ERROR: Coverage not available: unable to import coverage
> module
→ maybe add BR: python%{python3_pkgversion}-coverage to avoid the warning?
> sh: python: command not found
> Warning: Error loading
It seems unversioned python is being called.
The call is:
> /bin/sh bin/python -c import sysconfig; from os.path import join;
> print(join(sysconfig.get_config_var('LIBDIR'),
> sysconfig.get_config_var('multiarchsubdir')[1:],
> sysconfig.get_config_var('LDLIBRARY')))
This is going to give wrong results. I think that file needs to be patched to
call
%__python3 instead.
You build twice... I see setup.py manipulates sys.path to do import from $PWD,
which
doesn't work, because the binary module is missing. Too bad, I don't see an
easy way
to avoid this issue. Building twice doesn't seem so bad... OK.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037
--- Comment #8 from Raphael Groner ---
Asked in IRC #fedora-java:
[06.08.19 12:13] RaphGro,
https://github.com/LeeKamentsky/python-javabridge/blob/master/javabridge/locate.py#L242
[06.08.19 12:13] arches = ('amd64', 'i386', '') if is_linux
[06.08.19 12:13] seems they support only x86
[06.08.19 12:16] or just make the code arch independent
[06.08.19 12:16] what's the point of hardcoding lists of arches?
... maybe I can disable that piece of restrictive code with a downstream
patch, later.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #7 from Raphael Groner --- Suspection for FTBFS is that setup.py doesn't find jvm.so, for ppc64le and aarch64. BUILDSTDERR: File "setup.py", line 140, in ext_modules BUILDSTDERR: library_dirs = [os.path.dirname(jvm_so)] The relevant code for find_jre_bin_jdk_so() return value read into jvm_so variable: https://github.com/LeeKamentsky/python-javabridge/blob/master/javabridge/locate.py#L233 Maybe there's no java_home ($JAVA_HOME environment variable) or any other pathes are b0rken. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 Raphael Groner changed: What|Removed |Added Whiteboard|NotReady FTBFS |NotReady --- Comment #6 from Raphael Groner --- epel7 on x86 only... Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=36608068 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 Raphael Groner changed: What|Removed |Added Whiteboard||NotReady FTBFS -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #5 from Raphael Groner --- Ohno... FTBFS with latest git. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #4 from Raphael Groner --- SPEC: https://raphgro.fedorapeople.org/review/py/python-javabridge/python-javabridge.spec SRPM: https://raphgro.fedorapeople.org/review/py/python-javabridge/python-javabridge-1.0.18-2.20190723git16d6c91.fc30.src.rpm Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=36607367 %changelog * Sat Jul 27 2019 Raphael Groner <> - 1.0.18-2.20190723git16d6c91 - use latest git snapshot to support cython with python3 Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #3 from Raphael Groner --- (In reply to Robert-André Mauchin from comment #2) > Add the commit > https://github.com/LeeKamentsky/python-javabridge/commit/ > 7a914577f0f13328d0e315c18fb3505c5113c82e as a patch? Will do ASAP, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #2 from Robert-André Mauchin --- Add the commit https://github.com/LeeKamentsky/python-javabridge/commit/7a914577f0f13328d0e315c18fb3505c5113c82e as a patch? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #1 from Raphael Groner --- Currently, FTBFS except on epel7 with x86_64. https://koji.fedoraproject.org/koji/taskinfo?taskID=34814909 There's some need for a patch to Cython with Python 3, as noticed with failed builds in Rawhide and F30. https://github.com/LeeKamentsky/python-javabridge/issues/164 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
