[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 --- Comment #19 from Fedora Update System --- FEDORA-2020-703f118e1c has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 --- Comment #18 from Fedora Update System --- FEDORA-2020-84cb4ece2f has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 --- Comment #17 from Fedora Update System --- FEDORA-2020-703f118e1c has been pushed to the Fedora 30 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-703f118e1c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-703f118e1c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-04-20 22:14:55 --- Comment #16 from Fedora Update System --- FEDORA-2020-473d3f7a77 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- FEDORA-2020-84cb4ece2f has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-84cb4ece2f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-84cb4ece2f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 --- Comment #14 from Fedora Update System --- FEDORA-2020-703f118e1c has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-703f118e1c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 --- Comment #13 from Fedora Update System --- FEDORA-2020-473d3f7a77 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-473d3f7a77 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2020-84cb4ece2f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-84cb4ece2f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 --- Comment #11 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/apostrophe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 --- Comment #10 from Artem --- Slightly license description update https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342551-apostrophe/apostrophe.spec https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342551-apostrophe/apostrophe-2.2.0.1-3.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 Vitaly Zaitsev changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Vitaly Zaitsev --- Thanks for the quick fix. LGTM now. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 --- Comment #8 from Artem --- https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342432-apostrophe/apostrophe.spec https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342432-apostrophe/apostrophe-2.2.0.1-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 --- Comment #7 from Vitaly Zaitsev --- Please fix the following rpmlint errors: > apostrophe.noarch: E: explicit-lib-dependency glib2 Remove glib2 from Requires. > apostrophe.noarch: E: non-executable-script > /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/bibtexparser/bparser.py > 644 /usr/bin/env python > apostrophe.noarch: E: non-executable-script > /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/bibtexparser/bwriter.py > 644 /usr/bin/env python > apostrophe.noarch: E: non-executable-script > /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/bibtexparser/customization.py > 644 /usr/bin/env python > apostrophe.noarch: E: non-executable-script > /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/bibtexparser/latexenc.py > 644 /usr/bin/env python > apostrophe.noarch: E: non-executable-script > /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/fuzzywuzzy/StringMatcher.py > 644 /usr/bin/env python > apostrophe.noarch: E: non-executable-script > /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/fuzzywuzzy/fuzz.py > 644 /usr/bin/env python > apostrophe.noarch: E: non-executable-script > /usr/lib/python3.8/site-packages/apostrophe/plugins/bibtex/fuzzywuzzy/process.py > 644 /usr/bin/env python Remove shebangs from these files in %prep using find and sed. > apostrophe.noarch: W: hidden-file-or-dir > /usr/lib/python3.8/site-packages/apostrophe/.pylintrc Remove this file in %prep too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558
Vitaly Zaitsev changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||vit...@easycoding.org
Assignee|nob...@fedoraproject.org|vit...@easycoding.org
Flags||fedora-review?
--- Comment #6 from Vitaly Zaitsev ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
publishes
[Bug 1734558] Review Request: apostrophe - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 Artem changed: What|Removed |Added Summary|Review Request: uberwriter |Review Request: apostrophe |- Distraction free Markdown |- Distraction free Markdown |editor for GNU/Linux made |editor for GNU/Linux made |with GTK+ |with GTK+ --- Comment #5 from Artem --- Good news: ported to Meson and renamed to Apostrophe now. Spec URL: https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342374-apostrophe/apostrophe.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/apostrophe/fedora-32-x86_64/01342374-apostrophe/apostrophe-2.2.0.1-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
