[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 --- Comment #17 from Fedora Update System --- qimgv-0.8.6-7.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-10-25 17:01:07 --- Comment #16 from Fedora Update System --- qimgv-0.8.6-7.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 --- Comment #15 from Fedora Update System --- qimgv-0.8.6-7.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f09be760db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- qimgv-0.8.6-7.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-577f3d7de2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 --- Comment #13 from Fedora Update System --- FEDORA-2019-f09be760db has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-f09be760db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2019-577f3d7de2 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-577f3d7de2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 --- Comment #11 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qimgv -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 Artem changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #10 from Artem --- Last minute fix https://atim.fedorapeople.org/for-review/qimgv.spec https://atim.fedorapeople.org/for-review/qimgv-0.8.6-7.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 Vitaly Zaitsev changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #9 from Vitaly Zaitsev --- LGTM now. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 --- Comment #8 from Vitaly Zaitsev --- res/translations/ru_RU.qm is a binary file. It cannot be loaded. Ask upstream to add regular localization files. Now you must remove this unknown origin binary in %prep: sed -e '/translations/d' -i qimgv/resources.qrc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 --- Comment #7 from Artem --- https://atim.fedorapeople.org/for-review/qimgv.spec https://atim.fedorapeople.org/for-review/qimgv-0.8.6-6.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 Artem changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #6 from Artem --- https://atim.fedorapeople.org/for-review/qimgv.spec https://atim.fedorapeople.org/for-review/qimgv-0.8.6-5.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203
--- Comment #5 from Vitaly Zaitsev ---
> [!]: Package must own all directories that it creates.
Requires: hicolor-icon-theme
> install -m 0644 -Dp %{name}/res/translations/ru_RU.qm
> %{buildroot}%{_datadir}/%{name}/translations/%{name}_ru.qm
Should be removed with %find_lang %{name} --with-qt macro, because this app
bundle traslations into executable:
https://github.com/easymodo/qimgv/blob/831f0c4c3a185c5345fc00df7f40273c6e3811c9/qimgv/resources.qrc#L104
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203
--- Comment #4 from Vitaly Zaitsev ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/qimgv,
/usr/share/qimgv/translations
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/32x32, /usr/share/qimgv/translations,
/usr/share/icons/hicolor/128x128/apps,
/usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/32x32/apps,
/usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/22x22,
/usr/share/icons/hicolor/36x36, /usr/share/icons/hicolor/48x48/apps,
/usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/16x16,
/usr/share/qimgv, /usr/share/icons/hicolor/64x64,
/usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/36x36/apps,
/usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor,
/usr/share/icons/hicolor/128x128,
/usr/share/icons/hicolor/scalable/apps,
/usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/16x16/apps,
/usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/scalable
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 Vitaly Zaitsev changed: What|Removed |Added Status|NEW |ASSIGNED CC||vit...@easycoding.org Assignee|nob...@fedoraproject.org|vit...@easycoding.org Flags||fedora-review? --- Comment #3 from Vitaly Zaitsev --- I will review this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 Vasiliy Glazov changed: What|Removed |Added Assignee|vasc...@gmail.com |nob...@fedoraproject.org Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 --- Comment #2 from Artem --- Now with AppData manifest. https://copr-be.cloud.fedoraproject.org/results/atim/qimgv/fedora-31-x86_64/01059892-qimgv/qimgv.spec https://copr-be.cloud.fedoraproject.org/results/atim/qimgv/fedora-31-x86_64/01059892-qimgv/qimgv-0.8.6-4.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 --- Comment #1 from Artem --- https://copr-be.cloud.fedoraproject.org/results/atim/qimgv/fedora-31-x86_64/01059228-qimgv/qimgv.spec https://copr-be.cloud.fedoraproject.org/results/atim/qimgv/fedora-31-x86_64/01059228-qimgv/qimgv-0.8.6-3.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 Vasiliy Glazov changed: What|Removed |Added CC||vasc...@gmail.com Assignee|nob...@fedoraproject.org|vasc...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
