[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 --- Comment #15 from Fedora Update System --- golang-github-creack-goselect-0.1.1-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-02-19 01:28:14 --- Comment #14 from Fedora Update System --- golang-github-creack-goselect-0.1.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 --- Comment #13 from Fedora Update System --- golang-github-creack-goselect-0.1.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0d24924e33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- golang-github-creack-goselect-0.1.1-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4ea6922f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 --- Comment #11 from Fedora Update System --- FEDORA-2020-0d24924e33 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0d24924e33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2020-4ea6922f20 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4ea6922f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-creack-goselect -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|quantum.anal...@gmail.com |zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- I need this to fix the FTBFS of golang-bug-serial-1. - License ok - Latest version packaged - Builds in mock - Tests ok - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Elliott Sales de Andrade changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|lkund...@v3.sk |quantum.anal...@gmail.com Flags|fedora-review? | |needinfo?(lkund...@v3.sk) | --- Comment #7 from Elliott Sales de Andrade --- Unassigning as per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1799434 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1799434 [Bug 1799434] golang-bug-serial-1: FTBFS in Fedora rawhide/f32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1778549 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1778549 [Bug 1778549] tinygo install fails : nothing provides clang-libs = 8.0.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Elliott Sales de Andrade changed: What|Removed |Added Blocks|182235 (FE-Legal) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Elliott Sales de Andrade changed: What|Removed |Added Flags||needinfo?(lkund...@v3.sk) --- Comment #6 from Elliott Sales de Andrade --- So is there anything left to do now? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 --- Comment #5 from Elliott Sales de Andrade --- Upstream added a note in the readme. Spec URL: https://qulogic.fedorapeople.org//golang-github-creack-goselect.spec SRPM URL: https://qulogic.fedorapeople.org//golang-github-creack-goselect-0.1.1-1.fc30.src.rpm > 2.) Please add BuildRequires: go-rpm-macros > > You're using the macros from the package. Not necessary; it's added by %gometa: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_dependencies -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Lubomir Rintel changed: What|Removed |Added Blocks||182235 (FE-Legal) --- Comment #4 from Lubomir Rintel --- Thanks for the response. (In reply to Elliott Sales de Andrade from comment #3) > That's only a recommendation of the FSF for GPL. It's not required to > annotate all source files, and just take a look at the instructions on the > sidebar for choose a license, for example: > https://choosealicense.com/licenses/mit/ > tldr legal: https://tldrlegal.com/license/mit-license "You must include the > license notice in all copies or substantial uses of the work." > or this SE answer: > https://opensource.stackexchange.com/questions/4534/how-to-apply-mit-license- > in-the-github-repo-for-fully-free-project "No, a license header is not > necessary, at least for MIT and the Unlicense. Some other licenses encourage > you to add such a header but that is not the case of these two." None of the above is what I'm talking about, or relevant at all. What is missing here is any indication by whoever owns the copyright that the LICENSE file that is shipped applies to the source files in the tarball. >> Please ask upstream to clarify this, preferrably by including a comment in >> the source files about how are they licensed. If this was unclear, please let me rephrase this: Upstream needs to clarify this somehow, because it's not clear at the moment. The best way to do this is to add a comment in the actual source files. If there's any reason upstream has to object this, they could do something else, such as adding a statement in the README file. There's might be a chance that "this software" in the MIT license text could be understood as referring to whatever is in the same directory or tarball, but I don't know whether that's universally understood and would prefer a clarification to guessing. I'm adding a FE-LEGAL blocker, to give the legal a chance to chime in about this, but I believe it would be much easier if you just asked upstream to clear up how is the software licensed. Also, one more nit here: 2.) Please add BuildRequires: go-rpm-macros You're using the macros from the package. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 --- Comment #3 from Elliott Sales de Andrade --- That's only a recommendation of the FSF for GPL. It's not required to annotate all source files, and just take a look at the instructions on the sidebar for choose a license, for example: https://choosealicense.com/licenses/mit/ tldr legal: https://tldrlegal.com/license/mit-license "You must include the license notice in all copies or substantial uses of the work." or this SE answer: https://opensource.stackexchange.com/questions/4534/how-to-apply-mit-license-in-the-github-repo-for-fully-free-project "No, a license header is not necessary, at least for MIT and the Unlicense. Some other licenses encourage you to add such a header but that is not the case of these two." -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Lubomir Rintel changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk Assignee|nob...@fedoraproject.org|lkund...@v3.sk Flags||fedora-review? --- Comment #2 from Lubomir Rintel --- * Package named correctly * Packaging the latest version * License text included * License okay for Fedora * Builds fine in mock * SPEC file clean and concise * rpmlint reasonably happy 1.) The license is not clear There doesn't seem to be any word in documentation or source files about how they are licensed. The MIT license file is just there, with no indication about how is it relevant. Please ask upstream to clarify this, preferrably by including a comment in the source files about how are they licensed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1763145 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1763145 [Bug 1763145] Review Request: golang-bug-serial-1 - Cross-platform serial library for Golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org