[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-11-04 00:54:26 --- Comment #10 from Fedora Update System --- python-cssselect2-0.2.2-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- python-cssselect2-0.2.2-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-915ee45686 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2019-915ee45686 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-915ee45686 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 --- Comment #4 from Felix Schwarz --- Thanks, Artem. I like your suggestions, will fix before import. (repo requested) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 --- Comment #7 from Felix Schwarz --- > One more thing: can we replace in this package Requires as dynamic requires? > %?python_enable_dependency_generator As far as I know this is enabled automatically for F30 (F29?) so I omitted it. Also I noticed upstream forgot to list a dependency so only tinycss2 is found automatically. I fixed the source url (I got the tarball from pypi) and also the egg-info wildcard. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 Felix Schwarz changed: What|Removed |Added Blocks||1331947, 1475749 CC||space...@gmail.com --- Comment #6 from Felix Schwarz --- *** Bug 1704917 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1331947 [Bug 1331947] python-cairosvg-2.4.2 is available https://bugzilla.redhat.com/show_bug.cgi?id=1475749 [Bug 1475749] weasyprint 0.45 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cssselect2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322
Artem changed:
What|Removed |Added
Status|NEW |POST
CC||ego.corda...@gmail.com
Assignee|nob...@fedoraproject.org|ego.corda...@gmail.com
QA Contact|extras...@fedoraproject.org |ego.corda...@gmail.com
Flags||fedora-review+
--- Comment #2 from Artem ---
Felix, LGTM to me. Just a few tiny things:
- Linter warned about sources hash sum and spec file differ in RHBZ and SRPM.
- The one new thing i learned just yesterday from @churchyard :)
%{python3_sitelib}/%{srcname}-%{version}-py?.?.egg-info/
to
%{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}.egg-info/
Because:
> The ?.? glob would break with Python 3.10.
Please fix this minor issues before import.
---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in /mnt/data-
linux/tmp/1765322-python-cssselect2/diff.txt
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License", "*No copyright* BSD (unspecified)", "BSD (unspecified)". 23
files have unknown license. Detailed output of licensecheck in
/mnt/data-linux/tmp/1765322-python-cssselect2/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/python3.8/site-
packages/cssselect2(C, Failed, locale,, to, defaulting, set),
/usr/lib/python3.8/site-packages/cssselect2-0.2.2-py3.8.egg-info(C,
Failed, locale,, to, defaulting, set), /usr/lib/python3.8/site-
packages/cssselect2/__pycache__(C, Failed, locale,, to, defaulting,
set), /usr/lib/python3.8/site-packages/cssselect2/tests(C, Failed,
locale,, to, defaulting, set), /usr/lib/python3.8/site-
packages/cssselect2/tests/__pycache__(C, Failed, locale,, to,
defaulting, set), /usr/share/doc/python3-cssselect2(C, Failed,
locale,, to, defaulting, set),
/usr/share/licenses/python3-cssselect2(C, Failed, locale,, to,
defaulting, set)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 --- Comment #3 from Artem --- One more thing: can we replace in this package Requires as dynamic requires? %?python_enable_dependency_generator https://fedoraproject.org/wiki/Changes/EnablingPythonGenerators#How_To_Test -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 --- Comment #1 from Felix Schwarz --- copr build: https://copr.fedorainfracloud.org/coprs/fschwarz/python-cssselect2/build/1079276/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
