[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 Brandon Perkins changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 15:29:27 --- Comment #15 from Brandon Perkins --- CLOSED. In Rawhide (f33) and in progress for f32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 --- Comment #14 from Mohan Boddu --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gehirninc-crypt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 --- Comment #13 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-gehirninc-crypt.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-32-x86_64/01373680-golang-github-gehirninc-crypt/golang-github-gehirninc-crypt-0-0.3.20200415gitbb7000b.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 Brandon Perkins changed: What|Removed |Added Blocks|1773717 |1773720 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1773717 [Bug 1773717] Review Request: golang-github-haproxytech-models - HAProxy Go structs for API https://bugzilla.redhat.com/show_bug.cgi?id=1773720 [Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 Ryan O'Hara changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #12 from Ryan O'Hara --- Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716
--- Comment #11 from Brandon Perkins ---
Trying to get ahead of any issues, I went through the fedora-review report for
all five packages as they exist now and provided comments where needed:
> = MUST items =
>
> Generic:
> [ ]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
$ rpm -q --queryformat="%{NAME}: %{LICENSE}\n"
RPMS/golang-github-gehirninc-crypt-devel-0-0.2.20200214git6c0105a.fc31.noarch.rpm
SRPMS/golang-github-gehirninc-crypt-0-0.2.20200214git6c0105a.fc31.src.rpm
golang-github-gehirninc-crypt-devel: BSD
golang-github-gehirninc-crypt: BSD
> [ ]: License field in the package spec file matches the actual license.
> Note: There is no build directory. Running licensecheck on vanilla
> upstream sources. Licenses found: "Unknown or generated". 1 files have
> unknown license. Detailed output of licensecheck in
> ~/git/haproxytech/1773716-golang-github-gehirninc-
> crypt/licensecheck.txt
Unknown or generated
~/git/haproxytech/1773716-golang-github-gehirninc-crypt/upstream-unpacked/Source0/crypt-6c0105aabd460ae06c87afeb5a47c869f6a7557e.tar.gz
$ rpm -qpL
RPMS/golang-github-gehirninc-crypt-devel-0-0.2.20200214git6c0105a.fc31.noarch.rpm
/usr/share/licenses/golang-github-gehirninc-crypt-devel/LICENSE
$ tar -tf
1773716-golang-github-gehirninc-crypt/upstream-unpacked/Source0/crypt-6c0105aabd460ae06c87afeb5a47c869f6a7557e.tar.gz
| grep /LICENSE$
crypt-6c0105aabd460ae06c87afeb5a47c869f6a7557e/LICENSE
$ tar -xvzf
1773716-golang-github-gehirninc-crypt/upstream-unpacked/Source0/crypt-6c0105aabd460ae06c87afeb5a47c869f6a7557e.tar.gz
crypt-6c0105aabd460ae06c87afeb5a47c869f6a7557e/LICENSE
crypt-6c0105aabd460ae06c87afeb5a47c869f6a7557e/LICENSE
$ rpm -qp --queryformat="%{NAME}: %{LICENSE}\n"
RPMS/golang-github-gehirninc-crypt-devel-0-0.2.20200214git6c0105a.fc31.noarch.rpm
golang-github-gehirninc-crypt-devel: BSD
$ licensecheck crypt-6c0105aabd460ae06c87afeb5a47c869f6a7557e/LICENSE
crypt-6c0105aabd460ae06c87afeb5a47c869f6a7557e/LICENSE: BSD 2-clause
"Simplified" License
$ grep '^# Upstream license specification: '
1773716-golang-github-gehirninc-crypt/srpm-unpacked/golang-github-gehirninc-crypt.spec
# Upstream license specification: BSD-2-Clause
> [ ]: Package does not own files or directories owned by other packages.
> Note: Dirs in package are owned also by:
This is an issue across all 'golang-github' packages. In reality, the
'/usr/share/gocode/src/github.com' directory should only be owned by the
'golang' package itself:
$ rpm -qf /usr/share/gocode/src/github.com
golang-1.13.6-1.fc31.x86_64
> [ ]: %build honors applicable compiler flags or justifies otherwise.
Not Applicable as there is no %build section:
$ grep -A7 ^%build SPECS/golang-github-gehirninc-crypt.spec
> [ ]: Package contains no bundled libraries without FPC exception.
None:
$ rpm -qp --provides
RPMS/golang-github-gehirninc-crypt-devel-0-0.2.20200214git6c0105a.fc31.noarch.rpm
| grep bundled
> [ ]: Changelog in prescribed format.
Should all be fixed now.
> [ ]: Sources contain only permissible code or content.
Yes.
> [ ]: Package contains desktop file if it is a GUI application.
Not Applicable.
> [ ]: Development files must be in a -devel package
RPMS/golang-github-gehirninc-crypt-devel-0-0.2.20200214git6c0105a.fc31.noarch.rpm
> [ ]: Package uses nothing in %doc for runtime.
None:
golang-github-gehirninc-crypt-devel:
/usr/share/doc/golang-github-gehirninc-crypt-devel/AUTHORS.md
/usr/share/doc/golang-github-gehirninc-crypt-devel/README.rst
/usr/share/gocode/src/github.com/GehirnInc/crypt/AUTHORS.md
> [ ]: Package consistently uses macros (instead of hard-coded directory
> names).
Yes.
> [ ]: Package is named according to the Package Naming Guidelines.
Yes.
> [ ]: Package does not generate any conflict.
None.
> [ ]: Package obeys FHS, except libexecdir and /usr/target.
Yes.
> [ ]: If the package is a rename of another package, proper Obsoletes and
> Provides are present.
Not Applicable.
> [ ]: Requires correct, justified where necessary.
Yes:
golang-github-gehirninc-crypt-devel:
go-filesystem
> [ ]: Spec file is legible and written in American English.
Yes.
> [ ]: Package contains systemd file(s) if in need.
Not Applicable.
> [ ]: Package is not known to require an ExcludeArch tag.
ExcludeArch tag not required.
> [ ]: Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
> Note: Documentation size is 10240 bytes in 2 files.
Not needed as 10240 bytes is less than 1MB.
> [ ]: Package complies to the Packaging Guidelines
Yes.
> [x]: Package successfully compiles and builds into binary rpms on at least
> one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 --- Comment #10 from Brandon Perkins --- (In reply to Brandon Perkins from comment #7) > (In reply to Ryan O'Hara from comment #5) > > Rpmlint > > --- > > Checking: > > golang-github-gehirninc-crypt-devel-0-0.1.20191113git6c0105a.fc32.noarch.rpm > > > > golang-github-gehirninc-crypt-0-0.1.20191113git6c0105a.fc32.src.rpm > > golang-github-gehirninc-crypt-devel.noarch: W: hidden-file-or-dir > > /usr/share/gocode/src/github.com/GehirnInc/crypt/.goipath > > golang-github-gehirninc-crypt.src: W: no-%build-section > > 2 packages and 0 specfiles checked; 0 errors, 2 warnings. > > > > > > - No issues. First, there should not be a %build section for a -devel go > > package. Second, I believe that .goipath are unavoidable with go packages. > > Both statements are correct. > > > golang-github-gehirninc-crypt-devel.noarch: W: hidden-file-or-dir > > /usr/share/gocode/src/github.com/GehirnInc/crypt/.goipath > > 1 packages and 0 specfiles checked; 0 errors, 2 warnings. > > > > - Same as above. I believe these .goipath files are unavoidable. > > I've at least learned a lot more about rpmlint. This may be a feature request for rpmlint, but basically, the problem is that we're missing a filter in /usr/share/rpmlint/config. I figured it out by looking at the line: addFilter(r"hidden-file-or-dir .*/man5/\.k5login\.5[^/]+$") so, by adding an equivalent line: addFilter(r"hidden-file-or-dir /usr/share/gocode/src/github\.com/.*/.*/.goipath$") for .goipath, we can get a clean rpmlint: $ sudo mkdir -p /var/lib/mock/fedora-rawhide-x86_64/root/root/.config $ echo "addFilter(r\"hidden-file-or-dir /usr/share/gocode/src/github\.com/.*/.*/.goipath$\")" > /tmp/rpmlint.config $ sudo cp /tmp/rpmlint.config /var/lib/mock/fedora-rawhide-x86_64/root/root/.config/rpmlint $ LANG=C.utf8 mock -q -r fedora-rawhide-x86_64 --no-bootstrap-chroot --no-cleanup-after --no-clean --enable-network --chroot -- rpmlint -f /root/.config/rpmlint golang-github-gehirninc-crypt-devel 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 --- Comment #9 from Brandon Perkins --- (In reply to Brandon Perkins from comment #7) > (In reply to Ryan O'Hara from comment #5) > > golang-github-gehirninc-crypt-devel.noarch: W: invalid-url URL: > > https://github.com/GehirnInc/crypt > not known> > > > > - This URL is valid for me. What is it trying to do here? > > I have an idea on this one that I will test shortly. > Workaround: NOTE: seems like a bug in fedora-review to me that they run mock --chroot without --enable-network for that particular test and they enable network for a lot of other tests. Test can be manually performed as follows: 1. Run full 'fedora-review' 2. Verify package under test is installed: $ LANG=C.utf8 mock -q -r fedora-rawhide-x86_64 --no-bootstrap-chroot --no-cleanup-after --no-clean --enable-network --chroot -- rpm -q golang-github-gehirninc-crypt-devel golang-github-gehirninc-crypt-devel-0-0.2.20200214git6c0105a.fc31.noarch 3. Run rpmlint on installed package: $ LANG=C.utf8 mock -q -r fedora-rawhide-x86_64 --no-bootstrap-chroot --no-cleanup-after --no-clean --enable-network --chroot -- rpmlint golang-github-gehirninc-crypt-devel golang-github-gehirninc-crypt-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/GehirnInc/crypt/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716
--- Comment #8 from Brandon Perkins ---
(In reply to Brandon Perkins from comment #7)
> (In reply to Ryan O'Hara from comment #5)
> > Rpmlint (installed packages)
> >
> > perl: warning: Setting locale failed.
> > perl: warning: Please check that your locale settings:
> > LANGUAGE = (unset),
> > LC_ALL = (unset),
> > LC_CTYPE = "C.UTF-8",
> > LANG = "en_US.UTF-8"
> > are supported and installed on your system.
> > perl: warning: Falling back to the standard locale ("C").
> > perl: warning: Setting locale failed.
> > perl: warning: Please check that your locale settings:
> > LANGUAGE = (unset),
> > LC_ALL = (unset),
> > LC_CTYPE = "C.UTF-8",
> > LANG = "en_US.UTF-8"
> > are supported and installed on your system.
> > perl: warning: Falling back to the standard locale ("C").
> >
> > - I can't seem to avoid this. Is it really a problem?
>
> I'm still looking at this, but I doubt it since it is still running.
>
SOLVED: run fedora-review with the LANG environment variable set to C.utf8:
$ LANG=C.utf8 fedora-review -b 1773716
INFO: Processing bugzilla bug: 1773716
INFO: Getting .spec and .srpm Urls from : 1773716
INFO: --> SRPM url:
https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01281732-golang-github-gehirninc-crypt/golang-github-gehirninc-crypt-0-0.2.20191113git6c0105a.fc31.src.rpm
INFO: --> Spec url:
https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-gehirninc-crypt.spec
INFO: Using review directory:
/home/bperkins/git/haproxytech/1773716-golang-github-gehirninc-crypt
INFO: Downloading .spec and .srpm files
INFO: Downloading (Source0):
https://github.com/GehirnInc/crypt/archive/6c0105aabd460ae06c87afeb5a47c869f6a7557e/crypt-6c0105aabd460ae06c87afeb5a47c869f6a7557e.tar.gz
INFO: Running checks and generating report
INFO: Results and/or logs in:
/home/bperkins/git/haproxytech/1773716-golang-github-gehirninc-crypt/results
INFO: Reading configuration from /etc/mock/site-defaults.cfg
INFO: Reading configuration from /etc/mock/fedora-rawhide-x86_64.cfg
INFO: Build completed
WARNING: Package golang-github-gehirninc-crypt-debuginfo-0-0.2.fc33 not built
WARNING: Package golang-github-gehirninc-crypt-debugsource-0-0.2.fc33 not built
INFO: Installing built package(s)
INFO: Active plugins: Generic, Shell-api
INFO: ExclusiveArch dependency checking disabled, enable with EXARCH flag
Review template in:
/home/bperkins/git/haproxytech/1773716-golang-github-gehirninc-crypt/review.txt
fedora-review is automated tool, but *YOU* are responsible for manually
reviewing the results and finishing the review. Do not just copy-paste
the results without understanding them.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 Brandon Perkins changed: What|Removed |Added Comment #7 is|1 |0 private|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 --- Comment #6 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-gehirninc-crypt.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01281732-golang-github-gehirninc-crypt/golang-github-gehirninc-crypt-0-0.2.20191113git6c0105a.fc31.src.rpm Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01281732-golang-github-gehirninc-crypt/ Changelog: * Mon Mar 02 2020 Brandon Perkins - 0-0.2.20200302git6c0105a - Clean changelog * Wed Nov 13 2019 Brandon Perkins - 0-0.1.20191113git6c0105a - Initial package RPM Lint: golang-github-gehirninc-crypt.src: W: no-%build-section golang-github-gehirninc-crypt-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/GehirnInc/crypt/.goipath 2 packages and 0 specfiles checked; 0 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716
--- Comment #5 from Ryan O'Hara ---
Latest run of fedora-review using latest copr build (1114119), with comments:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
- This isn't a prebuilt package, it is a development package. Ignoring this.
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
- License is BSD 2-clause.
[ ]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in /home/rohara/copr-
build-1114119/review-golang-github-gehirninc-crypt/licensecheck.txt
- Don't understand this "unknown of generated". I inspected the license and it
clearly appears to be BSD 2-clause. Also, the licensecheck.txt file is not
helpful.
[ ]: %build honors applicable compiler flags or justifies otherwise.
- No %build here since this is devel only package.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
- Changelog needs attention. I'd would personally not use UTC time format, but
technically it is fine. Definitely change name from "mockbuild" to your actual
name and .
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
- No issues with above.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
Not sure about this. The fedora-review tool builds in mock, so I am inclined to
say this works as intended. However I was not able to manually build this
package in mock.
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Description and summary sections in the package spec file contains
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 --- Comment #4 from Brandon Perkins --- == golang-github-gehirninc-crypt-0-0.1.20191113git6c0105a.fc31.src.rpm == golang-github-gehirninc-crypt.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ## golang-github-gehirninc-crypt ## == golang-github-gehirninc-crypt-devel == golang-github-gehirninc-crypt-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/GehirnInc/crypt/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Copr build tested: https://copr.fedorainfracloud.org/coprs/bdperkin/haproxytech/build/1114119/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 --- Comment #3 from Brandon Perkins --- Turns out that a %build section breaks the go macros, as a result, I've reverted the change that made rpmlint happy: https://github.com/bdperkin/haproxytech/commit/6361a781c2f51ae9c11c317fd9cf4445e116cd7f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 Brandon Perkins changed: What|Removed |Added Comment #2 is|1 |0 private|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 Ryan O'Hara changed: What|Removed |Added Assignee|nob...@fedoraproject.org|roh...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716
--- Comment #1 from Ryan O'Hara ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in /home/rohara/copr-
build-1093544/review-golang-github-gehirninc-crypt/licensecheck.txt
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 Brandon Perkins changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 Brandon Perkins changed: What|Removed |Added Blocks||1773717 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1773717 [Bug 1773717] Review Request: golang-github-haproxytech-models - HAProxy Go structs for API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
