[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Bug 1773719 depends on bug 1773717, which changed state. Bug 1773717 Summary: Review Request: golang-github-haproxytech-models - HAProxy Go structs for API https://bugzilla.redhat.com/show_bug.cgi?id=1773717 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Brandon Perkins changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 15:29:41 --- Comment #16 from Brandon Perkins --- CLOSED. In Rawhide (f33) and in progress for f32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Bug 1773719 depends on bug 1773718, which changed state. Bug 1773718 Summary: Review Request: golang-github-haproxytech-config-parser - HAProxy configuration parser https://bugzilla.redhat.com/show_bug.cgi?id=1773718 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #15 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-haproxytech-client-native -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #14 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-client-native.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-32-x86_64/01391392-golang-github-haproxytech-client-native/golang-github-haproxytech-client-native-2.0.2-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #13 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-client-native.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-32-x86_64/01373689-golang-github-haproxytech-client-native/golang-github-haproxytech-client-native-2.0.1-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Brandon Perkins changed: What|Removed |Added Depends On||1773717 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1773717 [Bug 1773717] Review Request: golang-github-haproxytech-models - HAProxy Go structs for API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #12 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-client-native.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01352907-golang-github-haproxytech-client-native/golang-github-haproxytech-client-native-2.0.0-1.fc31.src.rpm Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01352907-golang-github-haproxytech-client-native/ Changelog: * Mon Apr 27 2020 Brandon Perkins - 2.0.0-1 - Upgrade to version 2.0.0 * Wed Apr 15 2020 Brandon Perkins - 1.2.7-1 - Update to version 1.2.7 * Tue Apr 14 2020 Brandon Perkins - 1.2.6-4 - Add specific versions for haproxytech BuildRequires * Mon Apr 13 2020 Brandon Perkins - 1.2.6-3 - Remove runtime/README.md * Mon Mar 02 2020 Brandon Perkins - 1.2.6-2 - Clean changelog * Wed Nov 13 2019 Brandon Perkins - 1.2.6-1 - Initial package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #11 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-client-native.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01337933-golang-github-haproxytech-client-native/golang-github-haproxytech-client-native-1.2.6-4.fc31.src.rpm Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01337933-golang-github-haproxytech-client-native/ Changelog: * Tue Apr 14 14:27:35 EST 2020 Brandon Perkins - 1.2.6-4 - Add specific versions for haproxytech BuildRequires * Mon Apr 13 17:29:12 EST 2020 Brandon Perkins - 1.2.6-3 - Remove runtime/README.md * Mon Mar 02 15:30:56 EST 2020 Brandon Perkins - 1.2.6-2 - Clean changelog * Wed Nov 13 12:24:19 UTC 2019 Brandon Perkins - 1.2.6-1 - Initial package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Ryan O'Hara changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Ryan O'Hara --- Thanks, Brandon! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719
--- Comment #9 from Brandon Perkins ---
(In reply to Ryan O'Hara from comment #7)
>
> Issues:
> ===
> - Package does not contain duplicates in %files.
> Note: warning: File listed twice: /usr/share/doc/golang-github-
> haproxytech-client-native-devel/README.md
> See: https://docs.fedoraproject.org/en-US/packaging-
> guidelines/#_duplicate_files
>
> - I don't quite understand this because the files aren't really listed in
> the spec file, but rather wee use %gopkgfiles. Also note that this did not
> happen with any of the other Go pacakges we are reviewing as part of the
> haproxy dataplaneapi. This is interesting, though:
>
> # rpm -q --filesbypkg
> golang-github-haproxytech-client-native-devel-1.2.6-2.fc33.noarch.rpm | grep
> README
> golang-github-haproxytech-client-native-devel
> /usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
> golang-github-haproxytech-client-native-devel
> /usr/share/gocode/src/github.com/haproxytech/client-native/README.md
> golang-github-haproxytech-client-native-devel
> /usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md
>
>
> # md5sum
> usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
> usr/share/gocode/src/github.com/haproxytech/client-native/README
> usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md
> 0a47f2b62cb73f6f84520d404d44f9e2
> usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
> 0173e68acc6998d347f71ae13122390d
> usr/share/gocode/src/github.com/haproxytech/client-native/README.md
> 0a47f2b62cb73f6f84520d404d44f9e2
> usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md
>
> So two of these files are identical, installed in different directories. If
> you look at github.com, you can see this README.md is duplicated in the git
> repo, too. Perhaps the easiest was to fix this is to ask upstream to remove
> one of the files?
>
Fixed with 1.2.6-3:
[x]: Package does not contain duplicates in %files.
[bperkins@bperkins haproxytech]$ rpm -ql
golang-github-haproxytech-client-native-devel | grep '/README.md$'
/usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
/usr/share/gocode/src/github.com/haproxytech/client-native/README.md
[bperkins@bperkins haproxytech]$ rpm -ql
golang-github-haproxytech-client-native-devel | grep '/README.md$' | xargs -i
md5sum {}
0173e68acc6998d347f71ae13122390d
/usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
0173e68acc6998d347f71ae13122390d
/usr/share/gocode/src/github.com/haproxytech/client-native/README.md
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #8 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-client-native.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01337234-golang-github-haproxytech-client-native/golang-github-haproxytech-client-native-1.2.6-3.fc31.src.rpm Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01337234-golang-github-haproxytech-client-native/ Changelog: * Mon Apr 13 2020 Brandon Perkins - 1.2.6-3 - Remove runtime/README.md * Mon Mar 02 2020 Brandon Perkins - 1.2.6-2 - Clean changelog * Wed Nov 13 2019 Brandon Perkins - 1.2.6-1 - Initial package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719
--- Comment #7 from Ryan O'Hara ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/share/doc/golang-github-
haproxytech-client-native-devel/README.md
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_duplicate_files
- I don't quite understand this because the files aren't really listed in the
spec file, but rather wee use %gopkgfiles. Also note that this did not happen
with any of the other Go pacakges we are reviewing as part of the haproxy
dataplaneapi. This is interesting, though:
# rpm -q --filesbypkg
golang-github-haproxytech-client-native-devel-1.2.6-2.fc33.noarch.rpm | grep
README
golang-github-haproxytech-client-native-devel
/usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
golang-github-haproxytech-client-native-devel
/usr/share/gocode/src/github.com/haproxytech/client-native/README.md
golang-github-haproxytech-client-native-devel
/usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md
# md5sum usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
usr/share/gocode/src/github.com/haproxytech/client-native/README
usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md
0a47f2b62cb73f6f84520d404d44f9e2
usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
0173e68acc6998d347f71ae13122390d
usr/share/gocode/src/github.com/haproxytech/client-native/README.md
0a47f2b62cb73f6f84520d404d44f9e2
usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md
So two of these files are identical, installed in different directories. If you
look at github.com, you can see this README.md is duplicated in the git repo,
too. Perhaps the easiest was to fix this is to ask upstream to remove one of
the files?
= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
- ASL 2.0
[ ]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in
/home/rohara/1773719-golang-github-haproxytech-client-
native/licensecheck.txt
- The source contains LICENSE file containig Apache License 2.0.
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
- This seems like an issue with all Go modules, as mentioned above.
[ ]: %build honors applicable compiler flags or justifies otherwise.
- No %build here.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
- All good.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
- All good.
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719
--- Comment #6 from Brandon Perkins ---
Trying to get ahead of any issues, I went through the fedora-review report for
all five packages as they exist now and provided comments where needed:
> Issues:
> ===
> - Package does not contain duplicates in %files.
> Note: warning: File listed twice: /usr/share/doc/golang-github-
> haproxytech-client-native-devel/README.md
> See: https://docs.fedoraproject.org/en-US/packaging-
> guidelines/#_duplicate_files
This appears to be an issue in the %godevelfiles macro in
/usr/lib/rpm/macros.d/macros.go-srpm. However, it does not appear it is
something that I can override.
>
>
> = MUST items =
>
> Generic:
> [ ]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
$ rpm -q --queryformat="%{NAME}: %{LICENSE}\n"
RPMS/golang-github-haproxytech-client-native-devel-1.2.6-2.fc31.noarch.rpm
SRPMS/golang-github-haproxytech-client-native-1.2.6-2.fc31.src.rpm
golang-github-haproxytech-client-native-devel: ASL 2.0
golang-github-haproxytech-client-native: ASL 2.0
> [ ]: License field in the package spec file matches the actual license.
> Note: There is no build directory. Running licensecheck on vanilla
> upstream sources. Licenses found: "Unknown or generated". 1 files have
> unknown license. Detailed output of licensecheck in
> ~/git/haproxytech/1773719-golang-github-haproxytech-
> client-native/licensecheck.txt
Unknown or generated
~/git/haproxytech/1773719-golang-github-haproxytech-client-native/upstream-unpacked/Source0/client-native-1.2.6.tar.gz
$ rpm -qpL
RPMS/golang-github-haproxytech-client-native-devel-1.2.6-2.fc31.noarch.rpm
/usr/share/licenses/golang-github-haproxytech-client-native-devel/LICENSE
$ tar -tf
1773719-golang-github-haproxytech-client-native/upstream-unpacked/Source0/client-native-1.2.6.tar.gz
| grep /LICENSE$
client-native-1.2.6/LICENSE
$ tar -xvzf
1773719-golang-github-haproxytech-client-native/upstream-unpacked/Source0/client-native-1.2.6.tar.gz
client-native-1.2.6/LICENSE
client-native-1.2.6/LICENSE
$ rpm -qp --queryformat="%{NAME}: %{LICENSE}\n"
RPMS/golang-github-haproxytech-client-native-devel-1.2.6-2.fc31.noarch.rpm
golang-github-haproxytech-client-native-devel: ASL 2.0
$ licensecheck client-native-1.2.6/LICENSE
client-native-1.2.6/LICENSE: *No copyright* Apache License (v2.0)
$ grep '^# Upstream license specification: '
1773719-golang-github-haproxytech-client-native/srpm-unpacked/golang-github-haproxytech-client-native.spec
# Upstream license specification: Apache-2.0
> [ ]: Package does not own files or directories owned by other packages.
> Note: Dirs in package are owned also by:
This is an issue across all 'golang-github' packages. In reality, the
'/usr/share/gocode/src/github.com' directory should only be owned by the
'golang' package itself:
$ rpm -qf /usr/share/gocode/src/github.com
golang-1.13.6-1.fc31.x86_64
> [ ]: %build honors applicable compiler flags or justifies otherwise.
Not Applicable as there is no %build section:
$ grep -A7 ^%build SPECS/golang-github-haproxytech-client-native.spec
> [ ]: Package contains no bundled libraries without FPC exception.
None:
$ rpm -qp --provides
RPMS/golang-github-haproxytech-client-native-devel-1.2.6-2.fc31.noarch.rpm |
grep bundled
> [ ]: Changelog in prescribed format.
Should all be fixed now.
> [ ]: Sources contain only permissible code or content.
Yes.
> [ ]: Package contains desktop file if it is a GUI application.
Not Applicable.
> [ ]: Development files must be in a -devel package
RPMS/golang-github-haproxytech-client-native-devel-1.2.6-2.fc31.noarch.rpm
> [ ]: Package uses nothing in %doc for runtime.
None:
golang-github-haproxytech-client-native-devel:
/usr/share/doc/golang-github-haproxytech-client-native-devel/README.md
/usr/share/gocode/src/github.com/haproxytech/client-native/README.md
/usr/share/gocode/src/github.com/haproxytech/client-native/runtime/README.md
> [ ]: Package consistently uses macros (instead of hard-coded directory
> names).
Yes.
> [ ]: Package is named according to the Package Naming Guidelines.
Yes.
> [ ]: Package does not generate any conflict.
None.
> [ ]: Package obeys FHS, except libexecdir and /usr/target.
Yes.
> [ ]: If the package is a rename of another package, proper Obsoletes and
> Provides are present.
Not Applicable.
> [ ]: Requires correct, justified where necessary.
Yes:
golang-github-haproxytech-client-native-devel:
go-filesystem
golang(github.com/go-openapi/errors)
golang(github.com/go-openapi/strfmt)
golang(github.com/google/uuid)
golang(github.com/haproxytech/config-parser)
golang(github.com/haproxytech/config-parser/common)
golang(github.com/haproxytech/config-parser/errors)
golang(github.com/haproxytech/config-parser/params)
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #5 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-client-native.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01281735-golang-github-haproxytech-client-native/golang-github-haproxytech-client-native-1.2.6-2.fc31.src.rpm Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01281735-golang-github-haproxytech-client-native/ Changelog: * Mon Mar 02 2020 Brandon Perkins - 1.2.6-2 - Clean changelog * Wed Nov 13 2019 Brandon Perkins - 1.2.6-1 - Initial package RPM Lint: golang-github-haproxytech-client-native.src: W: no-%build-section golang-github-haproxytech-client-native-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/client-native/.goipath 2 packages and 0 specfiles checked; 0 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #4 from Brandon Perkins --- == golang-github-haproxytech-client-native-1.2.6-1.fc31.src.rpm == golang-github-haproxytech-client-native.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ## golang-github-haproxytech-client-native ## == golang-github-haproxytech-client-native-devel == golang-github-haproxytech-client-native-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/client-native/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Copr build tested: https://copr.fedorainfracloud.org/coprs/bdperkin/haproxytech/build/1114122/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #3 from Brandon Perkins --- Turns out that a %build section breaks the go macros, as a result, I've reverted the change that made rpmlint happy: https://github.com/bdperkin/haproxytech/commit/6361a781c2f51ae9c11c317fd9cf4445e116cd7f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 --- Comment #2 from Brandon Perkins --- # golang-github-haproxytech-client-native-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/client-native/.goipath Nothing to worry about, all go devel packages have this in /usr/share/gocode/src/*/*/*/.goipath # golang-github-haproxytech-client-native.src: W: no-%build-section Added in: https://github.com/bdperkin/haproxytech/commit/cb4476b58a85b16eb068e58f06fd68fa7dfae13d # Build failure Likely due to missing BuildRequires: golang-github-haproxytech-client-native.spec:BuildRequires: golang(github.com/haproxytech/config-parser) golang-github-haproxytech-client-native.spec:BuildRequires: golang(github.com/haproxytech/config-parser/common) golang-github-haproxytech-client-native.spec:BuildRequires: golang(github.com/haproxytech/config-parser/errors) golang-github-haproxytech-client-native.spec:BuildRequires: golang(github.com/haproxytech/config-parser/params) golang-github-haproxytech-client-native.spec:BuildRequires: golang(github.com/haproxytech/config-parser/parsers/filters) golang-github-haproxytech-client-native.spec:BuildRequires: golang(github.com/haproxytech/config-parser/parsers/http/actions) golang-github-haproxytech-client-native.spec:BuildRequires: golang(github.com/haproxytech/config-parser/parsers/tcp/actions) golang-github-haproxytech-client-native.spec:BuildRequires: golang(github.com/haproxytech/config-parser/types) golang-github-haproxytech-client-native.spec:BuildRequires: golang(github.com/haproxytech/models) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719
--- Comment #1 from Ryan O'Hara ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in /home/rohara/copr-
build-1093804/review-golang-github-haproxytech-client-
native/licensecheck.txt
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]:
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Ryan O'Hara changed: What|Removed |Added Assignee|nob...@fedoraproject.org|roh...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Brandon Perkins changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Brandon Perkins changed: What|Removed |Added Blocks||1773720 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1773720 [Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API
https://bugzilla.redhat.com/show_bug.cgi?id=1773719 Brandon Perkins changed: What|Removed |Added Depends On||1773718 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1773718 [Bug 1773718] Review Request: golang-github-haproxytech-config-parser - HAProxy configuration parser -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
