[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Bug 1773720 depends on bug 1773719, which changed state. Bug 1773719 Summary: Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API https://bugzilla.redhat.com/show_bug.cgi?id=1773719 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Bug 1773720 depends on bug 1773717, which changed state. Bug 1773717 Summary: Review Request: golang-github-haproxytech-models - HAProxy Go structs for API https://bugzilla.redhat.com/show_bug.cgi?id=1773717 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Bug 1773720 depends on bug 1833511, which changed state. Bug 1833511 Summary: Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation https://bugzilla.redhat.com/show_bug.cgi?id=1833511 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Bug 1773720 depends on bug 1773718, which changed state. Bug 1773718 Summary: Review Request: golang-github-haproxytech-config-parser - HAProxy configuration parser https://bugzilla.redhat.com/show_bug.cgi?id=1773718 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Bug 1773720 depends on bug 1773716, which changed state. Bug 1773716 Summary: Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation https://bugzilla.redhat.com/show_bug.cgi?id=1773716 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Brandon Perkins changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 15:29:24 --- Comment #23 from Brandon Perkins --- CLOSED. In Rawhide (f33) and in progress for f32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #22 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-haproxytech-dataplaneapi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #21 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-dataplaneapi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-32-x86_64/01419481-golang-github-haproxytech-dataplaneapi/golang-github-haproxytech-dataplaneapi-2.0.3-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #20 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-dataplaneapi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-32-x86_64/01391394-golang-github-haproxytech-dataplaneapi/golang-github-haproxytech-dataplaneapi-2.0.2-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #19 from Brandon Perkins --- New version has been released and I can verify that v2.0.1 is functional. This should be unblocked now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #18 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-dataplaneapi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-32-x86_64/01373691-golang-github-haproxytech-dataplaneapi/golang-github-haproxytech-dataplaneapi-2.0.1-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Brandon Perkins changed: What|Removed |Added Depends On||1773716 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1773716 [Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Brandon Perkins changed: What|Removed |Added Depends On||1773717 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1773717 [Bug 1773717] Review Request: golang-github-haproxytech-models - HAProxy Go structs for API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Brandon Perkins changed: What|Removed |Added Depends On||1773718 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1773718 [Bug 1773718] Review Request: golang-github-haproxytech-config-parser - HAProxy configuration parser -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Brandon Perkins changed: What|Removed |Added Depends On||1833511 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1833511 [Bug 1833511] Review Request: golang-github-dustinkirkland-petname - An RFC1178 implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #17 from Brandon Perkins --- Upstream has fixed the issue with: https://github.com/haproxytech/dataplaneapi/pull/86 but there is not a release for it yet. This is blocked until a new version is released. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #16 from Brandon Perkins --- As of now, dataplaneapi is not functional as reported at: https://github.com/haproxytech/dataplaneapi/issues/85 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #15 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-dataplaneapi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01352909-golang-github-haproxytech-dataplaneapi/golang-github-haproxytech-dataplaneapi-2.0.0-1.fc31.src.rpm Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01352909-golang-github-haproxytech-dataplaneapi/ Changelog: * Mon Apr 27 2020 Brandon Perkins - 2.0.0-1 - Upgrade to version 2.0.0 * Wed Apr 15 2020 Brandon Perkins - 1.2.5-1 - Update to version 1.2.5 * Tue Apr 14 2020 Brandon Perkins - 1.2.4-7 - Change haproxy requires to >= 2.0 as 1.9 was never packaged - Add specific versions for haproxytech BuildRequires * Wed Mar 04 2020 Brandon Perkins - 1.2.4-6 - Use global instead of define macro - Remove defattr macro that is not needed * Mon Mar 02 2020 Brandon Perkins - 1.2.4-5 - Clean changelog * Thu Nov 21 2019 Brandon Perkins - 1.2.4-4 - Suggest logrotate and fix logrotate configuration * Wed Nov 20 2019 Brandon Perkins - 1.2.4-3 - Add man page * Wed Nov 13 2019 Brandon Perkins - 1.2.4-2 - Implement systemd * Wed Nov 13 2019 Brandon Perkins - 1.2.4-1 - Initial package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Ryan O'Hara changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #14 from Brandon Perkins --- $ rpm -qp --requires golang-github-haproxytech-dataplaneapi-1.2.4-7.fc33.x86_64.rpm | grep ^haproxy haproxy >= 2.0 $ rpm -qp --requires golang-github-haproxytech-dataplaneapi-1.2.4-7.fc33.x86_64.rpm | grep ^logrotate logrotate $ rpm -qp --requires golang-github-haproxytech-dataplaneapi-1.2.4-7.fc33.src.rpm | grep haproxytech golang(github.com/haproxytech/client-native) >= 1.2.6 golang(github.com/haproxytech/client-native/configuration) >= 1.2.6 golang(github.com/haproxytech/client-native/runtime) >= 1.2.6 golang(github.com/haproxytech/config-parser) >= 1.2.0 golang(github.com/haproxytech/config-parser/types) >= 1.2.0 golang(github.com/haproxytech/models) >= 1.2.4 $ LANG=C.utf8 rpmlint *.rpm golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-haproxytech-dataplaneapi. golang-github-haproxytech-dataplaneapi-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/dataplaneapi/.goipath 5 packages and 0 specfiles checked; 1 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #13 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-dataplaneapi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01337934-golang-github-haproxytech-dataplaneapi/golang-github-haproxytech-dataplaneapi-1.2.4-7.fc31.src.rpm Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01337934-golang-github-haproxytech-dataplaneapi/ Changelog: * Tue Apr 14 14:27:35 EST 2020 Brandon Perkins - 1.2.4-7 - Change haproxy requires to >= 2.0 as 1.9 was never packaged - Require instead of Suggest logrotate due to logging by default - Add specific versions for haproxytech BuildRequires * Wed Mar 04 14:54:06 EST 2020 Brandon Perkins - 1.2.4-6 - Use global instead of define macro - Remove defattr macro that is not needed * Mon Mar 02 15:30:56 EST 2020 Brandon Perkins - 1.2.4-5 - Clean changelog * Thu Nov 21 13:50:08 UTC 2019 Brandon Perkins - 1.2.4-4 - Suggest logrotate and fix logrotate configuration * Wed Nov 20 22:03:49 UTC 2019 Brandon Perkins - 1.2.4-3 - Add man page * Wed Nov 13 12:25:57 UTC 2019 Brandon Perkins - 1.2.4-2 - Implement systemd * Wed Nov 13 12:25:57 UTC 2019 Brandon Perkins - 1.2.4-1 - Initial package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720
--- Comment #12 from Brandon Perkins ---
(In reply to Ryan O'Hara from comment #11)
> (In reply to Brandon Perkins from comment #10)
> > (In reply to Ryan O'Hara from comment #9)
> >
> > The /etc/logrotate.d directory is owned by the 'logrotate' package:
> >
> > $ rpm -qf /etc/logrotate.d
> > logrotate-3.15.1-1.fc31.x86_64
> >
> > This issue is properly satisfied by the logrotate 'Suggests' in the RPM:
> >
> > $ grep ^Suggests: SPECS/golang-github-haproxytech-dataplaneapi.spec
> > Suggests: logrotate
> > $ rpm -qp --suggests
> > RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
> > logrotate
> >
> > To me, it's better to have a possible orphan directory than to have this
> > package become the owner of the directory. And, we certainly wouldn't be
> > the first to go down this path. Quick query shows me:
> >
> > [bperkins@bperkins haproxytech]$ dnf repoquery --queryformat="%{NAME}"
> > --whatsuggests logrotate
> > mariadb-server
> > plymouth
> >
> > However, many more do the ownership thing (which just seems wrong to me):
> >
> > [bperkins@bperkins haproxytech]$ dnf repoquery --queryformat="%{NAME}"
> > --whatprovides /etc/logrotate.d
> > bes
> > copr-dist-git
> > gap-pkg-scscp
> > gerbera
> > kdm-settings
> > lightdm
> > logrotate
> > macromilter
> > openqa
> > ppp
> > psad
> > samba-common
> > sssd-common
> > yast2-filesystem
> >
> > Or, we could go down what I *really* think is wrong and just ignore the
> > issue completely (which is by far the most popular path).
> >
> > I'm personally inclined to do what I did, but I can certainly change it.
>
> Another option would be to *require* logrotate as a dependency. Thoughts?
> I'm on the fence with this one.
>
Yeah, I thought about that as well. When I reviewed the command run again, it
is in fact logging by default (which HAProxy does not do by default). So, log
rotation in this case should be the default and not the exception. I'll go
ahead and make that change.
> >
> > Using the %gopkg macro, I don't see how this could be accomplished. This
> > really doesn't seem like a critical requirement to me.
>
> I know the above warning is complaining about about the -devel subpackage,
> but I am more curious if we can do something like this:
>
> BuildRequires: golang(github.com/haproxytech/config-parser) >= 1.2.0
>
I'm happy to make that change and I'll do it for client-native as well.
> Sorry, I should have been more specific. On a related note, I saw that the
> dataplaneapi spec file has this requirement:
>
> Requires: haproxy >= 1.9
>
> We might want to make that 2.0 unless we've tested this with 1.9 -- the API
> might have changed. Plus, I never put 1.9 in Fedora.
>
Will make that change.
> >
> > Because of using the %gopkg macro, we're kind of stuck with what it creates.
> > Outside of modifying the macro (which is a non-starter), the only thing that
> > could be done would be to shorten the package name, which is also a
> > non-starter. I think it's an error we just have to live with. Unless you
> > have any other thoughts.
>
> I think at the very least we should file a bug against whatever is defining
> those macros and see if they can prevent this from happening.
Bug entered as: https://bugzilla.redhat.com/show_bug.cgi?id=1823915
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720
--- Comment #11 from Ryan O'Hara ---
(In reply to Brandon Perkins from comment #10)
> (In reply to Ryan O'Hara from comment #9)
> >
> > [ ]: License file installed when any subpackage combination is installed.
> >
> > - The license is definitely installed with the regular rpm and/or the -devel
> > package. Does this requirement also apply to debuginfo and debugsource
> > packages? I'm going to assume not.
> >
>
> So, this is a great question that, AFAICT has not been resolved:
>
> https://lists.fedoraproject.org/archives/list/le...@lists.fedoraproject.org/
> thread/V3JDB74XPJQVNWO7SJVVDYFP3AR6GQD4/
>
> and I don't get clarity from:
>
> https://fedoraproject.org/wiki/Packaging:
> LicensingGuidelines#Subpackage_Licensing
> or
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/
>
> I would say that we defer to the auto-generation done by the macros which
> appears to not include it.
OK. Fair enough.
> > [ ]: Package must own all directories that it creates.
> > Note: Directories without known owners: /etc/logrotate.d
> >
> > - I don't think this is optional. Having the "suggests" line is the spec
> > seems ok, but this package is creating a directory with no owner.
> >
>
> The /etc/logrotate.d directory is owned by the 'logrotate' package:
>
> $ rpm -qf /etc/logrotate.d
> logrotate-3.15.1-1.fc31.x86_64
>
> This issue is properly satisfied by the logrotate 'Suggests' in the RPM:
>
> $ grep ^Suggests: SPECS/golang-github-haproxytech-dataplaneapi.spec
> Suggests: logrotate
> $ rpm -qp --suggests
> RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
> logrotate
>
> To me, it's better to have a possible orphan directory than to have this
> package become the owner of the directory. And, we certainly wouldn't be
> the first to go down this path. Quick query shows me:
>
> [bperkins@bperkins haproxytech]$ dnf repoquery --queryformat="%{NAME}"
> --whatsuggests logrotate
> mariadb-server
> plymouth
>
> However, many more do the ownership thing (which just seems wrong to me):
>
> [bperkins@bperkins haproxytech]$ dnf repoquery --queryformat="%{NAME}"
> --whatprovides /etc/logrotate.d
> bes
> copr-dist-git
> gap-pkg-scscp
> gerbera
> kdm-settings
> lightdm
> logrotate
> macromilter
> openqa
> ppp
> psad
> samba-common
> sssd-common
> yast2-filesystem
>
> Or, we could go down what I *really* think is wrong and just ignore the
> issue completely (which is by far the most popular path).
>
> I'm personally inclined to do what I did, but I can certainly change it.
Another option would be to *require* logrotate as a dependency. Thoughts? I'm
on the fence with this one.
> > [ ]: Package does not own files or directories owned by other packages.
> > Note: Dirs in package are owned also by:
> >
> > - This seems like an issue with all Go modules, as mentioned above.
> >
>
> > [ ]: Fully versioned dependency in subpackages if applicable.
> > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
> > github-haproxytech-dataplaneapi-devel
> >
> > - Can we do this? I know upstream is versioning the releases of the various
> > dataplaneapi components. I'm not sure if this works for go packages.
> >
>
> Using the %gopkg macro, I don't see how this could be accomplished. This
> really doesn't seem like a critical requirement to me.
I know the above warning is complaining about about the -devel subpackage, but
I am more curious if we can do something like this:
BuildRequires: golang(github.com/haproxytech/config-parser) >= 1.2.0
Sorry, I should have been more specific. On a related note, I saw that the
dataplaneapi spec file has this requirement:
Requires: haproxy >= 1.9
We might want to make that 2.0 unless we've tested this with 1.9 -- the API
might have changed. Plus, I never put 1.9 in Fedora.
> >
> > Rpmlint
> > ---
> > Checking: golang-github-haproxytech-dataplaneapi-1.2.4-6.fc33.x86_64.rpm
> >
> > golang-github-haproxytech-dataplaneapi-devel-1.2.4-6.fc33.noarch.rpm
> >
> > golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-6.fc33.x86_64.rpm
> >
> > golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-6.fc33.x86_64.rpm
> > golang-github-haproxytech-dataplaneapi-1.2.4-6.fc33.src.rpm
> > golang-github-haproxytech-dataplaneapi-devel.noarch: W: hidden-file-or-dir
> > /usr/share/gocode/src/github.com/haproxytech/dataplaneapi/.goipath
> > golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E:
> > description-line-too-long C This package provides debug sources for package
> > golang-github-haproxytech-dataplaneapi.
> > 5 packages and 0 specfiles checked; 1 errors, 1 warnings.
> >
> >
> >
> >
> > Rpmlint (debuginfo)
> > ---
> > Checking:
> > golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-6.fc33.x86_64.rpm
> > 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> >
> >
> >
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720
Brandon Perkins changed:
What|Removed |Added
Flags|needinfo?(bperkins@redhat.c |
|om) |
--- Comment #10 from Brandon Perkins ---
(In reply to Ryan O'Hara from comment #9)
>
> [ ]: License file installed when any subpackage combination is installed.
>
> - The license is definitely installed with the regular rpm and/or the -devel
> package. Does this requirement also apply to debuginfo and debugsource
> packages? I'm going to assume not.
>
So, this is a great question that, AFAICT has not been resolved:
https://lists.fedoraproject.org/archives/list/le...@lists.fedoraproject.org/thread/V3JDB74XPJQVNWO7SJVVDYFP3AR6GQD4/
and I don't get clarity from:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing
or
https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/
I would say that we defer to the auto-generation done by the macros which
appears to not include it.
> [ ]: Package must own all directories that it creates.
> Note: Directories without known owners: /etc/logrotate.d
>
> - I don't think this is optional. Having the "suggests" line is the spec
> seems ok, but this package is creating a directory with no owner.
>
The /etc/logrotate.d directory is owned by the 'logrotate' package:
$ rpm -qf /etc/logrotate.d
logrotate-3.15.1-1.fc31.x86_64
This issue is properly satisfied by the logrotate 'Suggests' in the RPM:
$ grep ^Suggests: SPECS/golang-github-haproxytech-dataplaneapi.spec
Suggests: logrotate
$ rpm -qp --suggests
RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
logrotate
To me, it's better to have a possible orphan directory than to have this
package become the owner of the directory. And, we certainly wouldn't be the
first to go down this path. Quick query shows me:
[bperkins@bperkins haproxytech]$ dnf repoquery --queryformat="%{NAME}"
--whatsuggests logrotate
mariadb-server
plymouth
However, many more do the ownership thing (which just seems wrong to me):
[bperkins@bperkins haproxytech]$ dnf repoquery --queryformat="%{NAME}"
--whatprovides /etc/logrotate.d
bes
copr-dist-git
gap-pkg-scscp
gerbera
kdm-settings
lightdm
logrotate
macromilter
openqa
ppp
psad
samba-common
sssd-common
yast2-filesystem
Or, we could go down what I *really* think is wrong and just ignore the issue
completely (which is by far the most popular path).
I'm personally inclined to do what I did, but I can certainly change it.
> [ ]: Package does not own files or directories owned by other packages.
> Note: Dirs in package are owned also by:
>
> - This seems like an issue with all Go modules, as mentioned above.
>
> [ ]: Fully versioned dependency in subpackages if applicable.
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
> github-haproxytech-dataplaneapi-devel
>
> - Can we do this? I know upstream is versioning the releases of the various
> dataplaneapi components. I'm not sure if this works for go packages.
>
Using the %gopkg macro, I don't see how this could be accomplished. This
really doesn't seem like a critical requirement to me.
>
> Rpmlint
> ---
> Checking: golang-github-haproxytech-dataplaneapi-1.2.4-6.fc33.x86_64.rpm
>
> golang-github-haproxytech-dataplaneapi-devel-1.2.4-6.fc33.noarch.rpm
>
> golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-6.fc33.x86_64.rpm
>
> golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-6.fc33.x86_64.rpm
> golang-github-haproxytech-dataplaneapi-1.2.4-6.fc33.src.rpm
> golang-github-haproxytech-dataplaneapi-devel.noarch: W: hidden-file-or-dir
> /usr/share/gocode/src/github.com/haproxytech/dataplaneapi/.goipath
> golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E:
> description-line-too-long C This package provides debug sources for package
> golang-github-haproxytech-dataplaneapi.
> 5 packages and 0 specfiles checked; 1 errors, 1 warnings.
>
>
>
>
> Rpmlint (debuginfo)
> ---
> Checking:
> golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-6.fc33.x86_64.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>
>
>
> Rpmlint (installed packages)
>
> perl: warning: Setting locale failed.
> perl: warning: Please check that your locale settings:
> LANGUAGE = (unset),
> LC_ALL = (unset),
> LC_CTYPE = "C.UTF-8",
> LANG = "en_US.UTF-8"
> are supported and installed on your system.
> perl: warning: Falling back to the standard locale ("C").
> perl: warning: Setting locale failed.
> perl: warning: Please check that your locale settings:
> LANGUAGE = (unset),
> LC_ALL = (unset),
> LC_CTYPE = "C.UTF-8",
> LANG = "en_US.UTF-8"
> are supported and
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720
Ryan O'Hara changed:
What|Removed |Added
Flags||needinfo?(bperkins@redhat.c
||om)
--- Comment #9 from Ryan O'Hara ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
- ASL 2.0
[ ]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 4 files have
unknown license. Detailed output of licensecheck in
/home/rohara/1773720-golang-github-haproxytech-
dataplaneapi/licensecheck.txt
- The source contains LICENSE file containig Apache License 2.0.
[ ]: License file installed when any subpackage combination is installed.
- The license is definitely installed with the regular rpm and/or the -devel
package. Does this requirement also apply to debuginfo and debugsource
packages? I'm going to assume not.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/logrotate.d
- I don't think this is optional. Having the "suggests" line is the spec seems
ok, but this package is creating a directory with no owner.
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
- This seems like an issue with all Go modules, as mentioned above.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
- All good.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
- All good.
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in golang-github-haproxytech-
dataplaneapi
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720
--- Comment #8 from Brandon Perkins ---
(In reply to Brandon Perkins from comment #6)
> > [ ]: Each %files section contains %defattr if rpm < 4.4
> > Note: %defattr present but not needed
>
> Fixed with 1.2.4-6.
>
>
Fixed, but there is no line for this in the new review report.
$ grep %defattr SPECS/golang-github-haproxytech-dataplaneapi.spec
> > [ ]: Spec use %global instead of %define unless justified.
> > Note: %define requiring justification: %define gorepo dataplaneapi,
> > %define haproxy_user haproxy, %define haproxy_group %{haproxy_user},
> > %define haproxy_homedir %{_localstatedir}/lib/haproxy
>
> Fixed with 1.2.4-6.
>
>
Fixed:
[x]: Spec use %global instead of %define unless justified.
$ grep -E "%(global|define)" SPECS/golang-github-haproxytech-dataplaneapi.spec
%global gorepo dataplaneapi
%global haproxy_userhaproxy
%global haproxy_group %{haproxy_user}
%global haproxy_homedir %{_localstatedir}/lib/haproxy
%global _hardened_build 1
%global goipath github.com/haproxytech/dataplaneapi
%global common_description %{expand:
%global golicenses LICENSE
%global godocs README.md CONTRIBUTING.md
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #7 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-dataplaneapi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01284546-golang-github-haproxytech-dataplaneapi/golang-github-haproxytech-dataplaneapi-1.2.4-6.fc31.src.rpm Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01284546-golang-github-haproxytech-dataplaneapi/ Changelog: * Wed Mar 04 2020 Brandon Perkins - 1.2.4-6 - Use global instead of define macro - Remove defattr macro that is not needed * Mon Mar 02 2020 Brandon Perkins - 1.2.4-5 - Clean changelog * Thu Nov 21 2019 Brandon Perkins - 1.2.4-4 - Suggest logrotate and fix logrotate configuration * Wed Nov 20 2019 Brandon Perkins - 1.2.4-3 - Add man page * Wed Nov 13 2019 Brandon Perkins - 1.2.4-2 - Implement systemd * Wed Nov 13 2019 Brandon Perkins - 1.2.4-1 - Initial package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720
--- Comment #6 from Brandon Perkins ---
Trying to get ahead of any issues, I went through the fedora-review report for
all five packages as they exist now and provided comments where needed:
> = MUST items =
>
> Generic:
> [ ]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
$ rpm -q --queryformat="%{NAME}: %{LICENSE}\n"
RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
RPMS/golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-5.fc31.x86_64.rpm
RPMS/golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-5.fc31.x86_64.rpm
RPMS/golang-github-haproxytech-dataplaneapi-devel-1.2.4-5.fc31.noarch.rpm
SRPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.src.rpm
golang-github-haproxytech-dataplaneapi: ASL 2.0
golang-github-haproxytech-dataplaneapi-debuginfo: ASL 2.0
golang-github-haproxytech-dataplaneapi-debugsource: ASL 2.0
golang-github-haproxytech-dataplaneapi-devel: ASL 2.0
golang-github-haproxytech-dataplaneapi: ASL 2.0
> [ ]: License field in the package spec file matches the actual license.
> Note: There is no build directory. Running licensecheck on vanilla
> upstream sources. Licenses found: "Unknown or generated". 4 files have
> unknown license. Detailed output of licensecheck in
> ~/git/haproxytech/1773720-golang-github-haproxytech-
> dataplaneapi/licensecheck.txt
Unknown or generated
~/git/haproxytech/1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source0/dataplaneapi-1.2.4.tar.gz
$ rpm -qpL RPMS/golang-github-haproxytech-dataplaneapi-*.rpm
/usr/share/licenses/golang-github-haproxytech-dataplaneapi/LICENSE
/usr/share/licenses/golang-github-haproxytech-dataplaneapi-devel/LICENSE
$ tar -tf
1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source0/dataplaneapi-1.2.4.tar.gz
| grep /LICENSE$
dataplaneapi-1.2.4/LICENSE
$ tar -xvzf
1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source0/dataplaneapi-1.2.4.tar.gz
dataplaneapi-1.2.4/LICENSE
dataplaneapi-1.2.4/LICENSE
$ rpm -qp --queryformat="%{NAME}: %{LICENSE}\n"
RPMS/golang-github-haproxytech-dataplaneapi-*.rpm
golang-github-haproxytech-dataplaneapi: ASL 2.0
golang-github-haproxytech-dataplaneapi-debuginfo: ASL 2.0
golang-github-haproxytech-dataplaneapi-debugsource: ASL 2.0
golang-github-haproxytech-dataplaneapi-devel: ASL 2.0
$ licensecheck dataplaneapi-1.2.4/LICENSE
dataplaneapi-1.2.4/LICENSE: *No copyright* Apache License (v2.0)
$ grep '^# Upstream license specification: '
1773720-golang-github-haproxytech-dataplaneapi/srpm-unpacked/golang-github-haproxytech-dataplaneapi.spec
# Upstream license specification: Apache-2.0
~/git/haproxytech/1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source1/dataplaneapi.service
~/git/haproxytech/1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source2/dataplaneapi.logrotate
~/git/haproxytech/1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source3/dataplaneapi.sysconfig
Not Applicable for dataplaneapi.service, dataplaneapi.logrotate, and
dataplaneapi.sysconfig.
> [ ]: License file installed when any subpackage combination is installed.
$ rpm -qpL --queryformat="\n%{NAME}: %{LICENSE}\n"
RPMS/golang-github-haproxytech-dataplaneapi-*.rpm
golang-github-haproxytech-dataplaneapi: ASL 2.0
/usr/share/licenses/golang-github-haproxytech-dataplaneapi/LICENSE
golang-github-haproxytech-dataplaneapi-debuginfo: ASL 2.0
golang-github-haproxytech-dataplaneapi-debugsource: ASL 2.0
golang-github-haproxytech-dataplaneapi-devel: ASL 2.0
/usr/share/licenses/golang-github-haproxytech-dataplaneapi-devel/LICENSE
$ for r in $(ls RPMS/golang-github-haproxytech-dataplaneapi-*.rpm); do for d in
conflicts enhances obsoletes provides recommends requires suggests supplements;
do o=$(rpm -qp --${d} ${r} | grep dataplaneapi); if [ "${o}" != "" ]; then echo
-e "=== ${r} ${d} ===\n${o}\n"; fi; done; done
=== RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
provides ===
config(golang-github-haproxytech-dataplaneapi) = 1.2.4-5.fc31
golang-github-haproxytech-dataplaneapi = 1.2.4-5.fc31
golang-github-haproxytech-dataplaneapi(x86-64) = 1.2.4-5.fc31
=== RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
requires ===
config(golang-github-haproxytech-dataplaneapi) = 1.2.4-5.fc31
===
RPMS/golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-5.fc31.x86_64.rpm
provides ===
golang-github-haproxytech-dataplaneapi-debuginfo = 1.2.4-5.fc31
golang-github-haproxytech-dataplaneapi-debuginfo(x86-64) = 1.2.4-5.fc31
===
RPMS/golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-5.fc31.x86_64.rpm
recommends ===
golang-github-haproxytech-dataplaneapi-debugsource(x86-64) = 1.2.4-5.fc31
===
RPMS/golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-5.fc31.x86_64.rpm
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #5 from Brandon Perkins --- Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-haproxytech-dataplaneapi.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01281736-golang-github-haproxytech-dataplaneapi/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.src.rpm Successful copr build: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fedora-31-x86_64/01281736-golang-github-haproxytech-dataplaneapi/ Changelog: * Mon Mar 02 2020 Brandon Perkins - 1.2.4-5 - Clean changelog * Thu Nov 21 2019 Brandon Perkins - 1.2.4-4 - Suggest logrotate and fix logrotate configuration * Wed Nov 20 2019 Brandon Perkins - 1.2.4-3 - Add man page * Wed Nov 13 2019 Brandon Perkins - 1.2.4-2 - Implement systemd * Wed Nov 13 2019 Brandon Perkins - 1.2.4-1 - Initial package RPM Lint: golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-haproxytech-dataplaneapi. golang-github-haproxytech-dataplaneapi-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/dataplaneapi/.goipath 5 packages and 0 specfiles checked; 1 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #4 from Brandon Perkins --- == golang-github-haproxytech-dataplaneapi-1.2.4-4.fc31.src.rpm == 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ## golang-github-haproxytech-dataplaneapi ## == golang-github-haproxytech-dataplaneapi-devel == golang-github-haproxytech-dataplaneapi-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/dataplaneapi/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. == golang-github-haproxytech-dataplaneapi == 1 packages and 0 specfiles checked; 0 errors, 0 warnings. == golang-github-haproxytech-dataplaneapi-debugsource == golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-haproxytech-dataplaneapi. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. == golang-github-haproxytech-dataplaneapi-debuginfo == 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Copr build tested: https://copr.fedorainfracloud.org/coprs/bdperkin/haproxytech/build/1114123/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #3 from Brandon Perkins --- # golang-github-haproxytech-dataplaneapi.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/dataplaneapi # golang-github-haproxytech-dataplaneapi.x86_64: E: missing-dependency-to-logrotate for logrotate script /etc/logrotate.d/dataplaneapi Fixed in: https://github.com/bdperkin/haproxytech/commit/b5d2e8b00b701d49ffaed524ea19ce3c172497d8 # golang-github-haproxytech-dataplaneapi.x86_64: W: no-manual-page-for-binary dataplaneapi Added in: https://github.com/bdperkin/haproxytech/commit/bada4ed3bcc363124ef950242159a93a46ad995b # golang-github-haproxytech-dataplaneapi-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/dataplaneapi/.goipath Nothing to worry about, all go devel packages have this in /usr/share/gocode/src/*/*/*/.goipath # golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-haproxytech-dataplaneapi. I don't have a good idea on how to fix this as the macros just kind of take care of everything under the hood. # Build failure Likely due to missing BuildRequires: golang-github-haproxytech-dataplaneapi.spec:BuildRequires: golang(github.com/GehirnInc/crypt) golang-github-haproxytech-dataplaneapi.spec:BuildRequires: golang(github.com/GehirnInc/crypt/md5_crypt) golang-github-haproxytech-dataplaneapi.spec:BuildRequires: golang(github.com/GehirnInc/crypt/sha256_crypt) golang-github-haproxytech-dataplaneapi.spec:BuildRequires: golang(github.com/GehirnInc/crypt/sha512_crypt) golang-github-haproxytech-dataplaneapi.spec:BuildRequires: golang(github.com/haproxytech/client-native) golang-github-haproxytech-dataplaneapi.spec:BuildRequires: golang(github.com/haproxytech/client-native/configuration) golang-github-haproxytech-dataplaneapi.spec:BuildRequires: golang(github.com/haproxytech/client-native/runtime) golang-github-haproxytech-dataplaneapi.spec:BuildRequires: golang(github.com/haproxytech/config-parser) golang-github-haproxytech-dataplaneapi.spec:BuildRequires: golang(github.com/haproxytech/config-parser/types) golang-github-haproxytech-dataplaneapi.spec:BuildRequires: golang(github.com/haproxytech/models) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #2 from Brandon Perkins --- man page added: https://github.com/bdperkin/haproxytech/commit/bada4ed3bcc363124ef950242159a93a46ad995b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720
--- Comment #1 from Ryan O'Hara ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 4 files have
unknown license. Detailed output of licensecheck in /home/rohara/copr-
build-1112715/review-golang-github-haproxytech-
; dataplaneapi/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/logrotate.d
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in golang-github-haproxytech-
dataplaneapi
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-haproxytech-dataplaneapi-devel
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Ryan O'Hara changed: What|Removed |Added Assignee|nob...@fedoraproject.org|roh...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Brandon Perkins changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 Brandon Perkins changed: What|Removed |Added Depends On||1773719 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1773719 [Bug 1773719] Review Request: golang-github-haproxytech-client-native - Go client for HAProxy configuration and runtime API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
