[Bug 1789940] Review Request: Pound - Reverse proxy and load balancer
https://bugzilla.redhat.com/show_bug.cgi?id=1789940 Breno changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NOTABUG Last Closed||2021-03-30 12:52:39 --- Comment #5 from Breno --- This request has been attended a long time ago. Closing the ticket. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1789940] Review Request: Pound - Reverse proxy and load balancer
https://bugzilla.redhat.com/show_bug.cgi?id=1789940 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #4 from Robert-André Mauchin --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1789940] Review Request: Pound - Reverse proxy and load balancer
https://bugzilla.redhat.com/show_bug.cgi?id=1789940 --- Comment #3 from Breno --- Spec URL: https://src.fedoraproject.org/fork/brandfbb/rpms/Pound/tree/epel8 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/brandfbb/Pound-2.8-patrodyne/srpm-builds/01144167/Pound-2.8-1.el8.src.rpm Description: Hi Robert-André, thanks for your feedback. I've updated the spec file with your corrections and ran another build. The diff can be seen here[1]. - Breno 1 - https://src.fedoraproject.org/fork/brandfbb/rpms/Pound/c/b63a0a0f789e1e3b51b3e1fd651455e923bc432f?branch=epel8 Fedora Account System Username:brandfbb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1789940] Review Request: Pound - Reverse proxy and load balancer
https://bugzilla.redhat.com/show_bug.cgi?id=1789940 --- Comment #2 from Robert-André Mauchin --- Disregards the Epoch comment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1789940] Review Request: Pound - Reverse proxy and load balancer
https://bugzilla.redhat.com/show_bug.cgi?id=1789940
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin ---
- Why the Epoch?
- Why no parallel building?
make all → %make_build all
- make install DESTDIR=%{buildroot} → %make_install
- Don't use %{__install}, macro prefixed by __ are generally for rpm private
use
- Please be more descriptive for the service description:
"Pound user" → "User for the Pound reverse proxy and load balancer"
- Why is there this stuff:
Requires(post): systemd-sysv
Requires(post): systemd-units
Requires(preun): systemd-units
Requires(postun): systemd-units
You just need BuildRequires: systemd-rpm-macros for Fedora.
Not sure what it is on EPEL8, test BuildRequires: systemd-rpm-macros first
then if not available use BuildRequires: systemd-devel
- https://www.apsis.ch/pound/ is 403? Isn't there another official site? Using
the fork as main page may be better: https://github.com/patrodyne/pound
- License seems to include an exception:
License: GPLv3 with exceptions
- License mist be included with %license not %doc:
%files
%doc CHANGELOG FAQ README.md
%license GPL.txt
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
