[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 Tomas Tomecek changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-03-30 09:58:11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 Tomas Tomecek changed: What|Removed |Added Status|POST|MODIFIED --- Comment #16 from Tomas Tomecek --- Robert, thank you very much for completing the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #15 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/nyancat
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 11 files have unknown license. Detailed
output of licensecheck in /home/bob/packaging/review/nyancat/review-
nyancat/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912
--- Comment #14 from Artur Iwicki ---
Taking a brief peek at "rpmbuild --showrc", %{set_build_flags} is called
automatically when using %{configure}, %{cmake} or %{meson} - I guess that
because of this, most Fedora packages have no need to call it explicitly in
%build.
Still, yeah, it would be a good idea to add that somewhere to the packaging
docs - I think the C/C++ guidelines would be the most appropriate place.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 --- Comment #13 from Tomas Tomecek --- I wish %set_build_flags was documented somewhere. Couldn't find any docs for it. Spec URL: https://raw.githubusercontent.com/TomasTomecek/nyancat/fe37d0684a453499dddeb1a397963913a0044124/nyancat.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/TomasTomecek-nyancat-2/fedora-rawhide-x86_64/01315881-nyancat/nyancat-1.5.2-5.gfe37d068.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #12 from Robert-André Mauchin --- Bump, just missing %set_build_flags from https://raw.githubusercontent.com/TomasTomecek/nyancat/c67dc905e26babcf2254b4a226be5ae02f238bb9/nyancat.spec and then should be good -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 --- Comment #11 from Tomas Tomecek --- Good points, thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912
--- Comment #10 from Artur Iwicki ---
>%build
>make %{?_smp_mflags} nyancat
You should call "%set_build_flags" before invoking make.
>install -m 0544 nyancat.1 %{buildroot}/%{_mandir}/man1/
0544 is read+execute,read,read - I think you wanted read+write,read,read = 0644
here.
>awk '1;/\*\//{exit}' < src/nyancat.c > LICENSE
Personally, I'd move this to %prep.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 --- Comment #9 from Tomas Tomecek --- Spec URL: https://raw.githubusercontent.com/TomasTomecek/nyancat/8a323f84067a3cbdda116c366b724e70b4d592fe/nyancat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/packit/TomasTomecek-nyancat-2/srpm-builds/01207709/nyancat-1.5.2-4.g8a323f84.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 --- Comment #8 from Tomas Tomecek --- Hm, you're right. The github archive contains everything while the archive generated with `make dist` contains only a handful of files - that's what I was using. Thanks for helping me out! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 --- Comment #7 from Artur Iwicki --- >But the manpage is not included in the tarball: Uhh, are you sure? When I fetch the Source0 URL specified in the spec I get a tarball that has nyancat-1.5.2/nyancat.1 happily sitting there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 --- Comment #6 from Tomas Tomecek --- Spec URL: https://raw.githubusercontent.com/TomasTomecek/nyancat/704d271ba1ac0a4736e44fb206a6475cc4e333e4/nyancat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/packit/TomasTomecek-nyancat-2/srpm-builds/01206320/nyancat-1.5.2-3.g704d271b.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912
--- Comment #5 from Tomas Tomecek ---
(In reply to Artur Iwicki from comment #4)
> ># upstream doesn't ship manpage yet:
> The man page is in the repo, it's just not included in the install script -
> which you don't use either way, so I see no reason why not to install the
> man page manually.
But the manpage is not included in the tarball:
https://github.com/klange/nyancat/pull/54
> >%license
> This should not be empty. Either ask upstream to provide a LICENCE file, or
> you can use awk to extract the copyright header (and thus, the licence) from
> src/nyancat.c:
> $ awk '1;/\*\//{exit}' < src/nyancat.c > LICENSE
yeah, the license file is not part in the upstream repo
thank you for the comments
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #4 from Artur Iwicki ---
># upstream doesn't ship manpage yet:
The man page is in the repo, it's just not included in the install script -
which you don't use either way, so I see no reason why not to install the man
page manually.
># %%{_mandir}/man1/nyancat.1.gz
Do not assume that man pages will be gzipped; use a wildcard that can match any
compression method (including no compression).
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
>%doc
If it's gonna be empty, just remove it.
>%license
This should not be empty. Either ask upstream to provide a LICENCE file, or you
can use awk to extract the copyright header (and thus, the licence) from
src/nyancat.c:
$ awk '1;/\*\//{exit}' < src/nyancat.c > LICENSE
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 --- Comment #3 from Tomas Tomecek --- Spec URL: https://raw.githubusercontent.com/TomasTomecek/nyancat/5983b2eaae752bbace63ddadc0691af59c3b291a/nyancat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/packit/TomasTomecek-nyancat-2/srpm-builds/01192113/nyancat-1.5.2-2.g5983b2ea.fc30.src.rpm third time's the charm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 --- Comment #2 from Tomas Tomecek --- Spec URL: https://raw.githubusercontent.com/TomasTomecek/nyancat/eebbd651fcde1a2b500c2b02750c644aed1f0413/nyancat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/packit/TomasTomecek-nyancat-1/srpm-builds/01178509/nyancat-1.5.2.7.geebbd65-1.fc30.src.rpm forgot to use the raw url for spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.
https://bugzilla.redhat.com/show_bug.cgi?id=1794912 Tomas Tomecek changed: What|Removed |Added CC||i...@ianweller.org --- Comment #1 from Tomas Tomecek --- *** Bug 824083 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
