https://bugzilla.redhat.com/show_bug.cgi?id=1795029
Artem changed:
What|Removed |Added
Status|NEW |POST
CC||ego.corda...@gmail.com
Assignee|nob...@fedoraproject.org|ego.corda...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review+
--- Comment #1 from Artem ---
1. Source0: %{url}/archive/%{commit0}.tar.gz#/%{name}-%{shortcommit0}.tar.gz
->
Source0:
%{url}/archive/%{commit0}/%{name}-%{version}.%{date}git%{shortcommit}.tar.gz
2. Description field we can stretch to 80 symbols:
The Quotient project aims to produce a Qt5-based SDK to develop
applications for Matrix. libQuotient is a library that enables
client applications. It is the backbone of Quaternion, Spectral
and other projects. Versions 0.5.x and older use the previous
name - libQMatrixClient.
->
The Quotient project aims to produce a Qt5-based SDK to develop applications
for
Matrix. libQuotient is a library that enables client applications. It is the
backbone of Quaternion, Spectral and other projects. Versions 0.5.x and older
use the previous name - libQMatrixClient.
3. We should use 'RelWithDebInfo'. Probably.
-DCMAKE_BUILD_TYPE=Release \
->
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
4. Summary: A Qt5 library to write cross-platform clients for Matrix
->
Summary: Qt5 library to write cross-platform clients for Matrix
5. %{_libdir}/cmake/%{appname}
->
%{_libdir}/cmake/%{appname}/
---
All this minor issues could be fixed during import. Please fix before import.
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
C/C++:
[x]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/include/Quotient(Failed,
C, defaulting, locale,, to, set), /usr/include/Quotient/application-
service(Failed, C, defaulting, locale,, to, set),
/usr/include/Quotient/application-service/definitions(Failed, C,
defaulting, locale,, to, set), /usr/include/Quotient/csapi(Failed, C,
defaulting, locale,, to, set),
/usr/include/Quotient/csapi/definitions(Failed, C, defaulting,
locale,, to, set),
/usr/include/Quotient/csapi/definitions/wellknown(Failed, C,
defaulting, locale,, to, set), /usr/include/Quotient/events(Failed, C,
defaulting, locale,, to, set), /usr/include/Quotient/identity(Failed,
C, defaulting, locale,, to, set),
/usr/include/Quotient/identity/definitions(Failed, C, defaulting,
locale,, to, set), /usr/include/Quotient/jobs(Failed, C, defaulting,
locale,, to, set), /usr/lib64/cmake/Quotient(Failed, C, defaulting,
locale,, to, set), /usr/share/doc/libquotient(Failed, C, defaulting,
locale,, to, set), /usr/share/licenses/libquotient(Failed, C,
defaulting, locale,, to, set)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any confli
