[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #22 from Fedora Update System --- rstudio-1.2.5033-10.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #21 from Fedora Update System --- rstudio-1.2.5033-10.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-03-12 21:57:01 --- Comment #20 from Fedora Update System --- rstudio-1.2.5033-10.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #19 from Fedora Update System --- rstudio-1.2.5033-10.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-65ff671dba -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- rstudio-1.2.5033-10.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-24812a08fd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #17 from Fedora Update System --- FEDORA-2020-24812a08fd has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-24812a08fd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #16 from Iñaki Ucar --- Thanks for a thorough review, I've learnt a lot! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 Jerry James changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #15 from Jerry James --- Sorry to go silent on you. I got bombarded last week. I'm looking over the latest results from fedora-review and everything looks good to me. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #14 from Iñaki Ucar --- Spec URL: https://iucar.fedorapeople.org/pkgs/rstudio.spec SRPM URL: https://iucar.fedorapeople.org/pkgs/rstudio-1.2.5033-9.fc31.src.rpm koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41953151 The NewsCycle font has been approved and pushed to stable in rawhide. Font unbundling done here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #13 from Iñaki Ucar --- (In reply to Kevin Kofler from comment #12) > FYI, since this depends on qt5-qtwebengine, you can find dictionaries in > Chromium format on the target system in the: > /usr/share/qt5/qtwebengine_dictionaries > directory. They are automatically converted from installed system-wide > Hunspell dictionaries by a file trigger (written by me) in qt5-qtwebengine: > https://src.fedoraproject.org/rpms/qt5-qtwebengine/blob/master/f/qt5- > qtwebengine.spec#_499 > If you install an additional hunspell-* package, the file trigger will > immediately convert it. (That's the big advantage of a file trigger over a > regular %post scriptlet.) > > So it is possible to avoid bundling those outdated bdic files. The dictionaries are unbundled already. I'm just pointing to /usr/share/myspell because there were no .bdic files, just .dic and .aff. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #12 from Kevin Kofler --- FYI, since this depends on qt5-qtwebengine, you can find dictionaries in Chromium format on the target system in the: /usr/share/qt5/qtwebengine_dictionaries directory. They are automatically converted from installed system-wide Hunspell dictionaries by a file trigger (written by me) in qt5-qtwebengine: https://src.fedoraproject.org/rpms/qt5-qtwebengine/blob/master/f/qt5-qtwebengine.spec#_499 If you install an additional hunspell-* package, the file trigger will immediately convert it. (That's the big advantage of a file trigger over a regular %post scriptlet.) So it is possible to avoid bundling those outdated bdic files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #11 from Iñaki Ucar --- Here's the newscycle-fonts package review request: https://bugzilla.redhat.com/show_bug.cgi?id=1807239 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #10 from Iñaki Ucar --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/iucar/rstudio/fedora-31-x86_64/01251826-rstudio/rstudio.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/iucar/rstudio/fedora-31-x86_64/01251826-rstudio/rstudio-1.2.5033-8.fc31.src.rpm Changes implemented: - Explicitly list gcc-c++ and java-devel as BuildRequires - Change Source0 URL to include the package name - Add isa flag to subpackages - Require hicolor-icon-theme and shared-mimo-info in -desktop - Mark config file as noreplace in -server - Add comments to justify patches - Unbundle Lato font - Some refactoring Additionally, I've downgraded gwt to v2.8.1. For some reason, the original OpenSUSE packaging changed the version to 2.8.2, but this RStudio version is not prepared for that. I tested the package during the weekend and it was constantly crashing when working with notebooks. This downgrade solves the issue. Two things left: - I can package the NewsCycle font for Fedora and unbunle it here. Then I need to set that review request as blocking for this one, right? - Under /usr/libexec/rstudio/www/fonts, however, there is no standard font files. There is a very small .woff file that contains just 8 free icons from icomoon.io, and they are re-distributed under the same license as RStudio. I don't think it makes sense to unbundle this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528
--- Comment #9 from Jerry James ---
Here's a full review. There are still a few issues, mostly minor except for
some bundled fonts.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
That's the same warning fedora-review generated last time. This time I
actually went to the referenced URL and read it. I know I said I didn't
care, but the policy is quite clear. The BuildRequires is required. The
wording of the policy leaves no wiggle room, so far as I can see.
- Please consider changing the Source0 URL to this, so that the tarball
contains
the package name: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
- Please add %{?_isa} to the Requires on the main package in the subpackages:
Requires: %{name}%{?_isa} = %{version}-%{release}. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package
- The -desktop subpackage should Requires: hicolor-icon-theme, which owns the
directories the icons are installed into.
- The -desktop subpackage should also Requires: shared-mime-info, which owns
/usr/share/mime/packages.
- The -server subpackage contains a file marked %config but not
%config(noreplace). Please either add the noreplace, or add a comment
stating
why it is inappropriate.
- The main package has bundled fonts in these directories:
/usr/libexec/rstudio/resources/presentation/revealjs.bundled/fonts
/usr/libexec/rstudio/www/fonts
The Lato fonts are available in the lato-fonts package. The others do not
seem to be available from Fedora. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/
for how they should be handled.
- One of the SHOULD items is "Patches link to upstream bugs/comments/lists or
are otherwise justified." Please consider doing so.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Affero General Public License",
"AGPL", "*No copyright* GNU General Public License (v2)", "*No
copyright* AGPL", "zlib/libpng license", "BSD 3-clause "New" or
"Revised" License", "BSD 3-clause "New" or "Revised" License GNU
Affero General Public License", "*No copyright* Apache License
(v2.0)", "Apache License (v2.0)", "Expat License", "ISC License",
"Mozilla Public License (v1.1 or later) GNU General Public License (v2
or later)", "Mozilla Public License (v1.1) GNU General Public License
(v2 or later) or GNU Lesser General Public License (v2.1 or later)",
"BSD 2-clause "Simplified" License", "Mozilla Public License GNU
Lesser General Public License (v2.1)", "Apache License". 9273 files
have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/systemd/system,
/usr/share/icons/hicolor/32x32/mimetypes,
/usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/256x256/apps,
/usr/share/icons/hicolor/24x24/mimetypes,
/usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32/apps,
/usr/share/icons/hicolor/256x256/mimetypes, /usr/share/icons/hicolor,
/usr/share/icons/hicolor/48x48/mimetypes,
/usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/24x24,
/usr/share/icons/hicolor/16x16/mimetypes,
/usr/share/icons/hicolor/24x24/apps, /usr/share/mime,
/usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/256x256,
/usr/lib/systemd, /usr/share/mime/packages,
/usr/share/icons/hicolor/16x16/apps
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/pam.d/rstudio
[-]: Development files must be in a -devel package
[x]: Package
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #8 from Iñaki Ucar --- Spec URL: https://iucar.fedorapeople.org/pkgs/rstudio.spec SRPM URL: https://iucar.fedorapeople.org/pkgs/rstudio-1.2.5033-6.fc31.src.rpm koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41760859 More work: - We're building against the system's rapidxml and websocketpp (solved the symlink issue). - RStudio relies on old synctex and hunspell APIs. I'll try to push upstream to update those interfaces, but for the time being, we need to bundle them. - I'm testing a build with unbundled dictionaries and the spelling check works just fine, so let's keep the symlink to /usr/share/myspell. I've listed hunspell in Requires accordingly. And hopefully that's all. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #7 from Jerry James --- That's okay. You've made great progress. Specific comments below. (In reply to Iñaki Ucar from comment #4) > This conflicts with the "minimum requirements" guideline. RStudio requires > R-devel, which in turn already requires gcc, gcc-c++ and others. That's why > the guidelines for R packages state that only the R build-dependency is > needed. This is not an R package though. And I don't have any special > preference about this. What do you think? I don't feel strongly about this either way. If R-devel already pulls in the compiler, then I'm okay with that. > You're right. They provide the .aff and the .dic, but also some .dic_delta > with additions. What if I symlink the first two and keep the delta? Not sure > what happens if there are definitions in the delta that are already in the > .dic (I suppose it may happen if there's a version mismatch). Those dictionary files are different enough that I worry that symlinking will lead to trouble. Maybe you should keep the bundled dictionaries and add the Provides: bundled(whatever-needs-to-go-here). > > - rapidxml-devel: src/cpp/core/include/core/rapidxml > > This is just a header-only library, same version, and doesn't require any > .so afterwards. I can substitute the file with a symlink. Is it worthwhile? The reason for symlinking is so that, if the Fedora rapidxml package is patched to fix some bug, rstudio will get the patch. You're right that if Fedora is shipping the straight unpatched upstream version, then there is nothing to be gained. > > - zlib: src/cpp/core/zlib and src/cpp/core/include/core/zlib > > I think we are fine here, because the one provided by the system should be > picked. In fact, libz.so is listed in the automatic requires and no other > libz.so is produced. So if I didn't miss anything, no change should be > required. Yes, I agree. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #6 from Iñaki Ucar --- Sorry, this is not ok: I thought 'ln -sf' also replaced directories, but it doesn't. It needs some more work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #5 from Iñaki Ucar --- Spec URL: https://iucar.fedorapeople.org/pkgs/rstudio.spec SRPM URL: https://iucar.fedorapeople.org/pkgs/rstudio-1.2.5033-5.fc31.src.rpm koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41733614 Here we go. I inspected carefully the source tree to unbundle some more things and declare others as bundled. Declared as bundled: - gwt-websockets, guice, aopalliance: Java add-ins for the gwt SDK. - json-spirit, sundown: small C++/C libraries for JSON and Markdown parsing. - datatables, pdfjs, revealjs: included as-is under /usr/libexec/rstudio/resources - jsbn, highlightjs, qunitjs: some parts of them included in other resources, such as HTML templates Unbundled: - qtsingleapplication, websocketpp, hunspell + dictionaries, rapidxml, synctex, jQuery Other changes: - Validate .desktop file - Expose rstudio-server script in /usr/bin - Mark NOTICE as license, clean up more files - Rebase patches -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528
--- Comment #4 from Iñaki Ucar ---
(In reply to Jerry James from comment #3)
> These are the issues fedora-review found:
>
> - If your application is a C or C++ application you must list a
> BuildRequires against gcc, gcc-c++ or clang.
> Note: No gcc, gcc-c++ or clang found in BuildRequires
> See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
This conflicts with the "minimum requirements" guideline. RStudio requires
R-devel, which in turn already requires gcc, gcc-c++ and others. That's why the
guidelines for R packages state that only the R build-dependency is needed.
This is not an R package though. And I don't have any special preference about
this. What do you think?
> - Package installs a %{name}.desktop using desktop-file-install or desktop-
> file-validate if there is such a file.
The file is automatically installed, so I need to run desktop-file-validate.
Thanks.
> - If (and only if) the source package includes the text of the license(s)
> in its own file, then that file, containing the text of the license(s)
> for the package is included in %license.
> Note: License file LICENSE is not marked as %license
> See: https://docs.fedoraproject.org/en-US/packaging-
> guidelines/LicensingGuidelines/#_license_text
>
> I think that last one is talking about these files:
> - src/gwt/lib/gin/2.1.2/LICENSE
> - src/cpp/session/resources/presentation/revealjs/LICENSE
I missed those, thanks.
> Also, while the dictionaries may have come from Chromium, they are
> ultimately derived from hunspell. We have many hunspell dictionaries in
> Fedora, and not just the English ones. For the source of the bundled
> dictionaries in this package, see hunspell-en, hunspell-en-GB, and
> hunspell-en-US. I'm not sure how this should be handled, but you must
> either unbundle these dictionaries or add "Provides: bundled(hunspell-en)",
> etc. to the spec file.
You're right. They provide the .aff and the .dic, but also some .dic_delta with
additions. What if I symlink the first two and keep the delta? Not sure what
happens if there are definitions in the delta that are already in the .dic (I
suppose it may happen if there's a version mismatch).
> Speaking of bundling, this package bundles other software that we already
> have in Fedora. This is what I have found so far:
> - js-jquery: src/cpp/session/resources/grid/datatables/js/jquery.js
And in fact, I've just discovered that we have xstatic-datatables-common, but
the contents differ a little. The one bundled in RStudio is an older version.
So I propose declaring bundled(js-datatables) (and thus I need to add MIT to
the list of licenses) and substituting that version of jQuery with a symlink to
the one provided by the system.
> - rapidxml-devel: src/cpp/core/include/core/rapidxml
This is just a header-only library, same version, and doesn't require any .so
afterwards. I can substitute the file with a symlink. Is it worthwhile?
> - texlive-synctex: src/cpp/core/tex/synctex
Ok, I see that's in texlive-lib-devel. Another symlink.
> - zlib: src/cpp/core/zlib and src/cpp/core/include/core/zlib
I think we are fine here, because the one provided by the system should be
picked. In fact, libz.so is listed in the automatic requires and no other
libz.so is produced. So if I didn't miss anything, no change should be
required.
> I think we're going to have to go through the source tree carefully to see
> what else is bundled in it.
Yeap, I'll take another closer look, especially to the "resources" directory.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528
--- Comment #3 from Jerry James ---
These are the issues fedora-review found:
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
I think that last one is talking about these files:
- src/gwt/lib/gin/2.1.2/LICENSE
- src/cpp/session/resources/presentation/revealjs/LICENSE
Also, while the dictionaries may have come from Chromium, they are ultimately
derived from hunspell. We have many hunspell dictionaries in Fedora, and not
just the English ones. For the source of the bundled dictionaries in this
package, see hunspell-en, hunspell-en-GB, and hunspell-en-US. I'm not sure how
this should be handled, but you must either unbundle these dictionaries or add
"Provides: bundled(hunspell-en)", etc. to the spec file.
Speaking of bundling, this package bundles other software that we already have
in Fedora. This is what I have found so far:
- js-jquery: src/cpp/session/resources/grid/datatables/js/jquery.js
- rapidxml-devel: src/cpp/core/include/core/rapidxml
- texlive-synctex: src/cpp/core/tex/synctex
- zlib: src/cpp/core/zlib and src/cpp/core/include/core/zlib
I think we're going to have to go through the source tree carefully to see what
else is bundled in it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #2 from Jerry James --- Good job on fixing the s390x build! I will take this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #1 from Iñaki Ucar --- I've solved the issue with the s390x arch. New Spec URL: https://copr-be.cloud.fedoraproject.org/results/iucar/rstudio/fedora-31-x86_64/01244761-rstudio/rstudio.spec New SRPM URL: https://copr-be.cloud.fedoraproject.org/results/iucar/rstudio/fedora-31-x86_64/01244761-rstudio/rstudio-1.2.5033-4.fc31.src.rpm New koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41650088 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803528] Review Request: rstudio - Integrated development environment for the R programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1803528 Dmitrij S. Kryzhevich changed: What|Removed |Added CC||kryz...@ispms.ru Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
