[Bug 1805718] Review Request: gfs-orpheus-classic-fonts - A 19th century Greek font family

2020-02-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805718

Nicolas Mailhot  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2020-02-24 23:06:09



--- Comment #4 from Nicolas Mailhot  ---
Done for F32 & F33. Thanks Parag and Gwyn.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805718] Review Request: gfs-orpheus-classic-fonts - A 19th century Greek font family

2020-02-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805718



--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/gfs-orpheus-classic-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805718] Review Request: gfs-orpheus-classic-fonts - A 19th century Greek font family

2020-02-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805718



--- Comment #2 from Nicolas Mailhot  ---
Ok, I’ll add a blanket defattr to all doc subpackages

Fixed the descriptions too

Thanks for the review!

http://www.greekfontsociety-gfs.gr/typefaces/19th_century

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805718] Review Request: gfs-orpheus-classic-fonts - A 19th century Greek font family

2020-02-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805718

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Review:

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: gfs-orpheus-classic-fonts-20161102-1.fc33.noarch.rpm
  gfs-orpheus-classic-fonts-doc-20161102-1.fc33.noarch.rpm
  gfs-orpheus-classic-fonts-20161102-1.fc33.src.rpm
gfs-orpheus-classic-fonts.noarch: W: spelling-error %description -l en_US
characterised -> characterized, characteristic, characterize
gfs-orpheus-classic-fonts.noarch: W: spelling-error %description -l en_US
letterforms -> letter forms, letter-forms, letterbombs
gfs-orpheus-classic-fonts-doc.noarch: W: summary-not-capitalized C
gfs-orpheus-classic-fonts optional documentation files
gfs-orpheus-classic-fonts-doc.noarch: E: description-line-too-long C This
package provides optional documentation files shipped with
gfs-orpheus-classic-fonts.
gfs-orpheus-classic-fonts-doc.noarch: E: non-readable
/usr/share/doc/gfs-orpheus-classic-fonts-doc/GFS_Orpheus_Classic_Specimen.pdf
640
gfs-orpheus-classic-fonts.src: W: spelling-error %description -l en_US
characterised -> characterized, characteristic, characterize
gfs-orpheus-classic-fonts.src: W: spelling-error %description -l en_US
letterforms -> letter forms, letter-forms, letterbombs
3 packages and 0 specfiles checked; 2 errors, 5 warnings.

Source checksums

http://www.greekfontsociety-gfs.gr/_assets/fonts/GFS_Orpheus_Classic.zip :
  CHECKSUM(SHA256) this package :
4cae1a7104be63627f04184e690514ca4371dc4e9ab2026694e03a44388b577a
  CHECKSUM(SHA256) upstream package :
4cae1a7104be63627f04184e690514ca4371dc4e9ab2026694e03a44388b577a


Requires

gfs-orpheus-classic-fonts (rpmlib, GLIBC filtered):
config(gfs-orpheus-classic-fonts)
fontpackages-filesystem

gfs-orpheus-classic-fonts-doc (rpmlib, GLIBC filtered):



Provides

gfs-orpheus-classic-fonts:
config(gfs-orpheus-classic-fonts)
font(gfsorpheusclassic)
gfs-orpheus-classic-fonts
metainfo()
metainfo(org.fedoraproject.gfs-orpheus-classic-fonts.metainfo.xml)

gfs-orpheus-classic-fonts-doc:
gfs-orpheus-classic-fonts-doc


All other things like license, config, metainfo files looks good.

Issues:
1) Fix the rpmlint warnings/errors before this package import

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805718] Review Request: gfs-orpheus-classic-fonts - A 19th century Greek font family

2020-02-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805718

Nicolas Mailhot  changed:

   What|Removed |Added

 CC||fonts-bugs@lists.fedoraproj
   ||ect.org
   Doc Type|--- |If docs needed, set a value



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org