[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870

Nicolas Mailhot  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2020-02-25 00:13:45



--- Comment #7 from Nicolas Mailhot  ---
Done for F32 & F33. Thanks Parag and Gwyn.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870



--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/sil-apparatus-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870



--- Comment #5 from Nicolas Mailhot  ---
Also fixed the URL

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22406

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Parag AN(पराग)  ---

Review:

I downloaded manually required srpm file and did below review of this package.

This package follows new fonts packaging guidelines.

Rpmlint
---
Checking: sil-apparatus-fonts-1.0-1.fc33.noarch.rpm
  sil-apparatus-fonts-1.0-1.fc33.src.rpm
sil-apparatus-fonts.noarch: W: invalid-url URL:
https://software.sil.org/ApparatusSIL/ HTTP Error 404: Not Found
sil-apparatus-fonts.src: W: invalid-url URL:
https://software.sil.org/ApparatusSIL/ HTTP Error 404: Not Found
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums

https://scripts.sil.org/cms/scripts/render_download.php?format=file_id=AppSIL1.0.zip=ApparatusSIL.zip#/ApparatusSIL.zip
:
  CHECKSUM(SHA256) this package :
0d8e3143b9c46c97916ab2cf85ae2187fe33b9b40859567a5524266dd58581bc
  CHECKSUM(SHA256) upstream package :
0d8e3143b9c46c97916ab2cf85ae2187fe33b9b40859567a5524266dd58581bc


Requires

sil-apparatus-fonts (rpmlib, GLIBC filtered):
config(sil-apparatus-fonts)
fontpackages-filesystem



Provides

sil-apparatus-fonts:
config(sil-apparatus-fonts)
font(apparatussil)
metainfo()
metainfo(org.fedoraproject.sil-apparatus-fonts.metainfo.xml)
sil-apparatus-fonts


All other things like license, config, metainfo files looks good.


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870



--- Comment #3 from Nicolas Mailhot  ---
Sorry about that, I messed up the last refactoring of SIL specs in that case
(Apparatus is one of their oldest projects and it is not published the same way
as others)

copr, mock, rpmbuild & spectool are quite happy with the spec except the source
is named %{archivename.sip} (not really what you want it to be).

Please use:
https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01249599-sil-apparatus-fonts/sil-apparatus-fonts.spec
https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01249599-sil-apparatus-fonts/sil-apparatus-fonts-1.0-3.fc33.noarch.rpm

They should work better.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|pnem...@redhat.com  |panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Parag AN(पराग)  ---
ERROR: 'Cannot parse Source0 url
https://scripts.sil.org/cms/scripts/render_download.php?format=file_id=AppSIL1.0.zip=%{archivename.zip}#/%{archivename.zip}'
 

debug log says
02-23 12:23 root DEBUGReviewError: 'Cannot parse Source0 url
https://scripts.sil.org/cms/scripts/render_download.php?format=file_id=AppSIL1.0.zip=%{archivename.zip}#/%{archivename.zip}'
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/FedoraReview/spec_file.py", line 171,
in _get_sources
result[tag] = self.spec.sourceHeader.format(unquote(url))
_rpm.error: unknown tag: "archivename.zip"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870



--- Comment #1 from Nicolas Mailhot  ---
*** Bug 1805869 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1805870] Review Request: sil-apparatus-fonts - A font family for rendering Greek & Hebrew biblical texts

2020-02-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1805870

Nicolas Mailhot  changed:

   What|Removed |Added

 CC||fonts-bugs@lists.fedoraproj
   ||ect.org,
   ||peter...@redhat.com,
   ||pnem...@redhat.com,
   ||ta...@redhat.com
   Doc Type|--- |If docs needed, set a value



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org