[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 --- Comment #12 from Fedora Update System --- FEDORA-2020-5166ba8c57 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 Bug 1806537 depends on bug 1806544, which changed state. Bug 1806544 Summary: Review Request: gnome-panel - GNOME Flashback panel https://bugzilla.redhat.com/show_bug.cgi?id=1806544 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-03-28 00:15:19 --- Comment #11 from Fedora Update System --- FEDORA-2020-e78e2c2583 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 --- Comment #10 from Fedora Update System --- FEDORA-2020-e78e2c2583 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e78e2c2583 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e78e2c2583 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 Fedora Update System changed: What|Removed |Added Status|POST|ON_QA --- Comment #9 from Fedora Update System --- FEDORA-2020-5166ba8c57 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-5166ba8c57 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5166ba8c57 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-flashback -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #7 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 --- Comment #6 from Artem --- Thanks everyone for help. Fixed, but successful validation desktop file and this new XDG entries still not possible in Fedora. https://atim.fedorapeople.org/for-review/gnome-flashback.spec https://atim.fedorapeople.org/for-review/gnome-flashback-3.34.2-4.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 Alberts Muktupāvels changed: What|Removed |Added CC||alberts.muktupavels@gmail.c ||om --- Comment #5 from Alberts Muktupāvels --- https://gitlab.freedesktop.org/xdg/desktop-file-utils/-/merge_requests/2 https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537
--- Comment #4 from Yaakov Selkowitz ---
(In reply to Robert-André Mauchin from comment #3)
> - You need to check the desktop file:
>
> desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
It cannot be validated because GNOME Flashback uses an still-unregistered
desktop name/variant, nor can it be X-prefixed because it relies on the exact
naming internally.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #3 from Robert-André Mauchin ---
- You need to check the desktop file:
desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
- You need to add SystemD user units scriptlets:
- systemd_user_post is invoked in %post and systemd_user_preun in %preun
for Systemd user units service files.
Note: Systemd user unit service file(s) in gnome-flashback
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Scriptlets/#_user_units
BuildRequires: systemd-rpm-macros
[…]
%post
%systemd_user_post %{name}.service
%preun
%systemd_user_preun %{name}.service
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
- systemd_user_post is invoked in %post and systemd_user_preun in %preun
for Systemd user units service files.
Note: Systemd user unit service file(s) in gnome-flashback
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Scriptlets/#_user_units
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "FSF All Permissive License", "GPL (v3
or later)", "FSF Unlimited License (with Retention)", "Expat License",
"FSF Unlimited License (with Retention) GNU General Public License GNU
Lesser General Public License", "FSF Unlimited License (with
Retention) GNU General Public License (v2)", "GNU General Public
License", "GPL (v2 or later)", "NTP License (legal disclaimer)", "GPL
(v2 or later) (with incorrect FSF address)". 243 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/gnome-flashback/review-gnome-
flashback/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplic
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 --- Comment #2 from Artem --- Note: for fedora-review use fedora-review -b 1806537 -m fedora-31-x86_64 since this is for current GNOME 3.34 version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1806537] Review Request: gnome-flashback - GNOME Flashback session
https://bugzilla.redhat.com/show_bug.cgi?id=1806537 Artem changed: What|Removed |Added CC||yselk...@redhat.com Depends On||1806544 Doc Type|--- |If docs needed, set a value --- Comment #1 from Artem --- I would really like to co-maintain this with Yaakov Selkowitz and appreciate his efforts to package it. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1806544 [Bug 1806544] Review Request: gnome-panel - GNOME Flashback panel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
