[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272 Fabian Affolter changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-19 09:37:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272 Bug 1815272 depends on bug 1815267, which changed state. Bug 1815267 Summary: Review Request: python-restfly - A library to make API wrappers creation easier https://bugzilla.redhat.com/show_bug.cgi?id=1815267 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272 --- Comment #5 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytenable -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272 --- Comment #4 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272 Bug 1815272 depends on bug 1815258, which changed state. Bug 1815258 Summary: Review Request: python-requests-pkcs12 - Add PKCS12 support to the requests library https://bugzilla.redhat.com/show_bug.cgi?id=1815258 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272 --- Comment #2 from Fabian Affolter --- Thanks for the feedback. (In reply to Robert-André Mauchin from comment #1) > - Package is not installable: > > DEBUG util.py:621: Error: > DEBUG util.py:621: Problem: conflicting requests > DEBUG util.py:621:- nothing provides python3.8dist(ipaddress) >= 1.0.22 > needed by python3-pytenable-1.1.0-1.fc33.noarch > DEBUG util.py:623: (try to add '--skip-broken' to skip uninstallable > packages or '--nobest' to use not only best candidate packages) > > It's orphaned: https://src.fedoraproject.org/rpms/python-ipaddress It's not needed for Python 3. > - Remove this file: > > python-pytenable-doc.noarch: W: hidden-file-or-dir > /usr/share/doc/python-pytenable-doc/html/.nojekyll > python-pytenable-doc.noarch: E: zero-length > /usr/share/doc/python-pytenable-doc/html/.nojekyll File removed * Thu Apr 02 2020 Fabian Affolter - 1.1.1-1 - Remove configuration file for publishing - Remove standard library (rhbz#1815272) - Update to latest upstream release 1.1.1 Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytenable.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytenable-1.1.1-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272 Bug 1815272 depends on bug 1815246, which changed state. Bug 1815246 Summary: Review Request: python-pytest-datafiles - A pytest plugin to create a 'tmpdir' containing predefined content https://bugzilla.redhat.com/show_bug.cgi?id=1815246 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Package is not installable:
DEBUG util.py:621: Error:
DEBUG util.py:621: Problem: conflicting requests
DEBUG util.py:621:- nothing provides python3.8dist(ipaddress) >= 1.0.22
needed by python3-pytenable-1.1.0-1.fc33.noarch
DEBUG util.py:623: (try to add '--skip-broken' to skip uninstallable packages
or '--nobest' to use not only best candidate packages)
It's orphaned: https://src.fedoraproject.org/rpms/python-ipaddress
- Remove this file:
python-pytenable-doc.noarch: W: hidden-file-or-dir
/usr/share/doc/python-pytenable-doc/html/.nojekyll
python-pytenable-doc.noarch: E: zero-length
/usr/share/doc/python-pytenable-doc/html/.nojekyll
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License". 664 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/python-pytenable/review-
python-pytenable/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages
[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272 Fabian Affolter changed: What|Removed |Added Blocks||563471 (FE-SECLAB) Depends On||1815267, 1815246, 1815258 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages https://bugzilla.redhat.com/show_bug.cgi?id=1815246 [Bug 1815246] Review Request: python-pytest-datafiles - A pytest plugin to create a 'tmpdir' containing predefined content https://bugzilla.redhat.com/show_bug.cgi?id=1815258 [Bug 1815258] Review Request: python-requests-pkcs12 - Add PKCS12 support to the requests library https://bugzilla.redhat.com/show_bug.cgi?id=1815267 [Bug 1815267] Review Request: python-restfly - A library to make API wrappers creation easier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
