[Bug 1821809] Review Request: golang-github-sourcemap - Source maps consumer
https://bugzilla.redhat.com/show_bug.cgi?id=1821809 Fabian Affolter changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2023-02-22 20:33:39 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1821809 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 1821809] Review Request: golang-github-sourcemap - Source maps consumer
https://bugzilla.redhat.com/show_bug.cgi?id=1821809 Hirotaka Wakabayashi changed: What|Removed |Added Assignee|hiw...@yahoo.com|m...@fabian-affolter.ch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1821809] Review Request: golang-github-sourcemap - Source maps consumer
https://bugzilla.redhat.com/show_bug.cgi?id=1821809 Hirotaka Wakabayashi changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Hirotaka Wakabayashi --- Hello Fabian, Package approved. Please see my review attached. This package contains test suites. If they are practical, you should run them because of the the guidelines[1][2]. I found tests run correctly when changing the spec file as followings. ``` $ diff golang-github-sourcemap.spec.orig golang-github-sourcemap.spec 37c37,38 < %gocheck --- > GOPATH=%{gobuilddir}:%{gobuilddir}/_build:/usr/share/gocode:/usr/share/gocode > GO111MODULE=off make ``` Thanks you very much, Hirotaka Wakabayashi --- 1: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites 2: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_testing Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License". 10 files have unknown license. Detailed output of licensecheck in /home/build/dev/fedora_packaging/1821809-golang-github- sourcemap/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]
[Bug 1821809] Review Request: golang-github-sourcemap - Source maps consumer
https://bugzilla.redhat.com/show_bug.cgi?id=1821809 Hirotaka Wakabayashi changed: What|Removed |Added Flags|needinfo?(hiw...@yahoo.com) | --- Comment #3 from Hirotaka Wakabayashi --- Sorry for my late response because of my early summer vacation. I will check this again this week. Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 1821809] Review Request: golang-github-sourcemap - Source maps consumer
Product: Fedora Version: rawhide Component: Package Review Hirotaka Wakabayashi has canceled Package Review 's request for Hirotaka Wakabayashi 's needinfo: Bug 1821809: Review Request: golang-github-sourcemap - Source maps consumer https://bugzilla.redhat.com/show_bug.cgi?id=1821809 --- Comment #3 from Hirotaka Wakabayashi --- Sorry for my late response because of my early summer vacation. I will check this again this week. Thanks in advance, Hirotaka Wakabayashi ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1821809] Review Request: golang-github-sourcemap - Source maps consumer
https://bugzilla.redhat.com/show_bug.cgi?id=1821809 --- Comment #1 from Hirotaka Wakabayashi --- Hello Fabian, I'm not sure, but no tests seem not to have run in %check. The spec file looks good. If you know anything, please tell me. Here is an excerpt of my rpmbuild log. ``` Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.Z0UYtg + umask 022 + cd /home/vagrant/rpmbuild/BUILD + cd sourcemap-2.1.3 + LDFLAGS='-X github.com/go-sourcemap/sourcemap/version=2.1.3' + GO_TEST_FLAGS='-buildmode pie -compiler gc' + GO_TEST_EXT_LD_FLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld ' + go-rpm-integration check -i github.com/go-sourcemap/sourcemap -b /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build/bin -s /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build -V 2.1.3-1.fc33 -p /home/vagrant/rpmbuild/BUILDROOT/golang-github-sourcemap-2.1.3-1.fc33.x86_64 -g /usr/share/gocode -r '.*example.*' Testingin: /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build/src PATH: /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build/bin:/home/vagrant/.local/bin:/home/vagrant/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin GOPATH: /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build:/usr/share/gocode GO111MODULE: off command: go test -buildmode pie -compiler gc -ldflags "-X github.com/go-sourcemap/sourcemap/version=2.1.3 -extldflags '-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '" testing: github.com/go-sourcemap/sourcemap + RPM_EC=0 ++ jobs -p + exit 0 ``` I find this upstream prepares tests and I could run. ``` [vagrant@localhost sourcemap-2.1.3]$ export GOPATH=/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build:/usr/share/gocode [vagrant@localhost sourcemap-2.1.3]$ make go test ./... ok _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3 0.315s ok _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/internal/base64vlq 0.002s go test ./... -short -race ok _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3 0.373s ok _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/internal/base64vlq 0.029s go vet ``` Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821809] Review Request: golang-github-sourcemap - Source maps consumer
https://bugzilla.redhat.com/show_bug.cgi?id=1821809 Hirotaka Wakabayashi changed: What|Removed |Added Status|NEW |ASSIGNED CC||hiw...@yahoo.com Assignee|nob...@fedoraproject.org|hiw...@yahoo.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821809] Review Request: golang-github-sourcemap - Source maps consumer
https://bugzilla.redhat.com/show_bug.cgi?id=1821809 Fabian Affolter changed: What|Removed |Added Blocks||1821815 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1821815 [Bug 1821815] Review Request: golang-github-dop251-goja - ECMAScript 5.1(+) implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org