[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-07-15 01:11:22 --- Comment #21 from Fedora Update System --- FEDORA-2020-aeb83bf598 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System --- FEDORA-2020-aeb83bf598 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-aeb83bf598 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-aeb83bf598 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #19 from Fedora Update System --- FEDORA-2020-aeb83bf598 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-aeb83bf598 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #18 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libvirt-test-API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 Richard W.M. Jones changed: What|Removed |Added Flags||fedora-review+ --- Comment #17 from Richard W.M. Jones --- **Package is APPROVED by rjones** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 lnie changed: What|Removed |Added Flags|needinfo?(l...@redhat.com) | --- Comment #16 from lnie --- Hi Richard, (In reply to Richard W.M. Jones from comment #15) > I was chatting with Miro on IRC and he thinks the Requires: /usr/bin/python > which is generated may be incorrect. (I don't really know). > > 17:25 < mhroncok> rwmjones: the /usr/bin/python require is generated by the > "template" files > 17:26 < mhroncok> rwmjones: hence I suppose the runtime requirement should > not be generated by them, as they will not be executed on the system where > the package is installed > 17:27 < mhroncok> rwmjones: the filter will make them be not considered when > generating the requires > > There is a way to filter out the require, but I'm not very clear if > someone installing libvirt-test-api would require /usr/bin/python > in order to use the package at all, or if it's optional. /usr/bin/python requires is generated by jenkins.py and virtlab.py in excute dir. jenkins.py is used by virt-QE to work with libvirt-ci,and virt-QE also use virtlab.py frequently. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 Richard W.M. Jones changed: What|Removed |Added Flags||needinfo?(l...@redhat.com) --- Comment #15 from Richard W.M. Jones --- I was chatting with Miro on IRC and he thinks the Requires: /usr/bin/python which is generated may be incorrect. (I don't really know). 17:25 < mhroncok> rwmjones: the /usr/bin/python require is generated by the "template" files 17:26 < mhroncok> rwmjones: hence I suppose the runtime requirement should not be generated by them, as they will not be executed on the system where the package is installed 17:27 < mhroncok> rwmjones: the filter will make them be not considered when generating the requires There is a way to filter out the require, but I'm not very clear if someone installing libvirt-test-api would require /usr/bin/python in order to use the package at all, or if it's optional. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #14 from lnie --- Hi Richard, > (4) You said in your answer to Miro here: > https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/IVTYKIOMCQPMW5SJZZ7LKUQ5SMVIULEM/ > that you would update the doc. Does this package include the updated > documentation with this change? yes:) Here are the links of the new built: Spec URL:https://download.copr.fedorainfracloud.org/results/lnie/libvirt-test-API/fedora-32-x86_64/01469834-libvirt-test-api/libvirt-test-api.spec SRPM URL:https://download.copr.fedorainfracloud.org/results/lnie/libvirt-test-API/fedora-32-x86_64/01469834-libvirt-test-api/libvirt-test-api-1.1-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #13 from Richard W.M. Jones --- Nearly there, we're getting into nitpicking now: (1) Please fix the whitespace in: Requires:libvirt-python (2) BuildRequires: mock is listed twice. (3) It would be nice if the %check section came after the %install section. This reflects the order in which rpmbuild runs the sections: %prep -> %build -> %install -> %check (4) You said in your answer to Miro here: https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/IVTYKIOMCQPMW5SJZZ7LKUQ5SMVIULEM/ that you would update the doc. Does this package include the updated documentation with this change? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #12 from lnie --- Hi Richard, I have put the updated pdf file to a -doc subpackage,and here are the new built links: Spec URL:https://download.copr.fedorainfracloud.org/results/lnie/libvirt-test-API/fedora-32-x86_64/01466300-libvirt-test-api/libvirt-test-api.spec SRPM URL:https://download.copr.fedorainfracloud.org/results/lnie/libvirt-test-API/fedora-32-x86_64/01466300-libvirt-test-api/libvirt-test-api-1.1-1.fc32.src.rpm koji:https://koji.fedoraproject.org/koji/taskinfo?taskID=45784136 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #11 from Richard W.M. Jones --- (In reply to lnie from comment #10) > Hi Richard, > > > What is the license of the PDF file? > > GFDL. That's a "good license" (https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses_2) This means if you want to you could package this file in a separate -doc package, but that's optional. > > Weirdly it works now, but didn't when I tried it on Friday. > > I also have seen the URL error when I ran fedora-review on this package,and > I thought it is a wrong alert. > I have tried several times yesterday and today,it works all the time,so > there is no need for me to change it,right? No need to change this as the URL now seems correct. May have been a temporary server problem. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #10 from lnie --- Hi Richard, > What is the license of the PDF file? GFDL. > Weirdly it works now, but didn't when I tried it on Friday. I also have seen the URL error when I ran fedora-review on this package,and I thought it is a wrong alert. I have tried several times yesterday and today,it works all the time,so there is no need for me to change it,right? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #9 from Richard W.M. Jones --- (In reply to lnie from comment #7) > >There is documentation supplied upstream but it is not packaged. > You mean I should package the pdf ,right? What is the license of the PDF file? In any case it's up to you whether or not to package this file. If packaged it should go into a -doc subpackage because it's quite large. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation > >The source URL is indeed wrong - please fix it. > > I can wget > https://gitlab.com/libvirt/libvirt-test-API/-/archive/1.0/libvirt-test-api-1. > 0.tar.gz manually, > and I can open https://gitlab.com/libvirt/libvirt-test-API > successfully,will try to work it out. Weirdly it works now, but didn't when I tried it on Friday. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456
--- Comment #8 from lnie ---
(In reply to Miro Hrončok from comment #5)
> What about:
>
>
>
> %if %{with_python3}
> %global __python %{__python3}
> %else
> %global __python %{__python2}
> %endif
>
> ...
>
> %check
> %{__python} setup.py test
>
> %build
> %py_build
>
> %install
> %py_install
>
> ...
>
> %files
> %{python_sitelib}/libvirt_test_api*
> %{python_sitelib}/libvirttestapi*
Will update the spec file accordingly,thanks for your review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456
--- Comment #7 from lnie ---
>In the section %if %{with_python3} ... %else ... %endif that defines
>BuildRequires and Requires,
> it is better to factor out the common BRs/Rs,
yeah,much clearer now,thanks.
>Is it really the case that qemu-img is only required if using
>Python 3, or is that a mistake revealed by the refactoring?
Sorry,I shouldn't overlook python2 part even if we don't use it in Fedora,
won't make this kind of mistake again.
>There is documentation supplied upstream but it is not packaged.
You mean I should package the pdf ,right?
>The source URL is indeed wrong - please fix it.
I can wget
https://gitlab.com/libvirt/libvirt-test-API/-/archive/1.0/libvirt-test-api-1.0.tar.gz
manually,
and I can open https://gitlab.com/libvirt/libvirt-test-API successfully,will
try to work it out.
> Please fix the other things while we're waiting for a
> response from the Fedora community.
Sure,thanks a lot for your review:)
> Lili, could you please also see Miro's question here:
> https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/3UL6WXFP4JHUJRH6BUT5XSWLKTTDT5XE/
Sure thing,replied.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #6 from Richard W.M. Jones --- Lili, could you please also see Miro's question here: https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/3UL6WXFP4JHUJRH6BUT5XSWLKTTDT5XE/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456
Miro Hrončok changed:
What|Removed |Added
CC||mhron...@redhat.com
--- Comment #5 from Miro Hrončok ---
%check
%if %{with_python3}
%{__python3} setup.py test
%else
%{__python2} setup.py test
%endif
%build
%if %{with_python3}
%py3_build
%else
%py2_build
%endif
%install
%if %{with_python3}
%py3_install
%else
%py2_install
%endif
...
%files
%if %{with_python2}
%{python2_sitelib}/libvirt_test_api*
%{python2_sitelib}/libvirttestapi*
%endif
%if %{with_python3}
%{python3_sitelib}/libvirt_test_api*
%{python3_sitelib}/libvirttestapi*
%endif
What about:
%if %{with_python3}
%global __python %{__python3}
%else
%global __python %{__python2}
%endif
...
%check
%{__python} setup.py test
%build
%py_build
%install
%py_install
...
%files
%{python_sitelib}/libvirt_test_api*
%{python_sitelib}/libvirttestapi*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #4 from Richard W.M. Jones --- https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/thread/2IXDR32RWPKHZWA43HVHBZFL5FHHBKNH/ Please fix the other things while we're waiting for a response from the Fedora community. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456
--- Comment #3 from Richard W.M. Jones ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
License if GPLv2+ and upstream includes a license file.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License",
"GNU General Public License (v2 or later)", "GPL (v2 or later)". 414
files have unknown license. Detailed output of licensecheck in
/var/tmp/1825456-libvirt-test-api/licensecheck.txt
The vast majority of files have correct licenses in them, and
the ones which don't are things like documentation, conf, XML
where adding a license is hard.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
Not really applicable because this isn't a library.
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
I started a thread on devel list which should appear here:
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/2020/6/
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
Requires: qemu-img may be missing.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
There is documentation supplied upstream but it is not packaged.
[ ]: Package complies to the Packaging Guidelines
Unclear on whether Python packaging guidelines apply. See
thread on devel list.
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0: https://gitlab.com/libvirt/libvirt-
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456
--- Comment #2 from Richard W.M. Jones ---
Some general comments on the spec file:
(1) There are some typos / formatting issues in the very first # comment
at the top of the file. It would be better reformatted as:
# Disable the shebangs checks on scripts that currently don't
# define a Python version. The point here is that these scripts
# will be copied to guest VM instances, which may be running
# operating systems that can have either Python 2 or Python 3,
# but it's impossible to know for sure at packaging time.
(2) In the section %if %{with_python3} ... %else ... %endif that
defines BuildRequires and Requires, it is better to factor out the
common BRs/Rs, ie:
BuildRequires: mock
%if %{with_python3}
BuildRequires: python3-devel
BuildRequires: python3-lxml
BuildRequires: python3-pytest
BuildRequires: python3-setuptools
BuildRequires: python3-six
BuildRequires: python3-attrs
BuildRequires: python3-libvirt
BuildRequires: python3-pexpect
Requires: qemu-img
Requires: python3-six
Requires: python3-lxml
Requires: python3-libvirt
%else
BuildRequires: python2-devel
BuildRequires: python2-pytest
BuildRequires: python2-setuptools
BuildRequires: python2-attrs
BuildRequires: python-six
BuildRequires: python2-pexpect
Requires: python-six
Requires: python-lxml
%endif
Requires: libvirt
Requires: qemu-kvm
Requires: virt-install
(3) Is it really the case that qemu-img is only required if using
Python 3, or is that a mistake revealed by the refactoring?
(4) Whitespace in:
%if 0%{?rhel} && 0%{?rhel} < 8
Requires: libvirt-python
%endif
(5) The %files section should also be refactored. You can see that
it's much clearer afterwards:
%files
%doc README.md
%license LICENSE
%{_bindir}/%{name}
%if %{with_python2}
%{python2_sitelib}/libvirt_test_api*
%{python2_sitelib}/libvirttestapi*
%endif
%if %{with_python3}
%{python3_sitelib}/libvirt_test_api*
%{python3_sitelib}/libvirttestapi*
%endif
%{_datadir}/libvirt-test-api*
I'll do a formal review in a minute.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 Richard W.M. Jones changed: What|Removed |Added CC||rjo...@redhat.com Assignee|nob...@fedoraproject.org|rjo...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #1 from lnie --- Hi, I have rebuilt the package and here are the new links: Spec URL:https://download.copr.fedorainfracloud.org/results/lnie/libvirt-test-API/fedora-32-x86_64/01415309-libvirt-test-api/libvirt-test-api.spec SRPM URL:https://download.copr.fedorainfracloud.org/results/lnie/libvirt-test-API/fedora-32-x86_64/01415309-libvirt-test-api/libvirt-test-api-1.0-1.fc32.src.rpm Koji:https://koji.fedoraproject.org/koji/taskinfo?taskID=45092907 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
