[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 --- Comment #15 from Fedora Update System --- FEDORA-2020-37cb00170f has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-07 03:09:50 --- Comment #14 from Fedora Update System --- FEDORA-2020-74679c3b8a has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2020-37cb00170f has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-37cb00170f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-37cb00170f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2020-37cb00170f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-37cb00170f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- FEDORA-2020-74679c3b8a has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-74679c3b8a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-74679c3b8a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2020-74679c3b8a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-74679c3b8a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 --- Comment #9 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-argos -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 --- Comment #8 from Michel Alexandre Salim --- repo requested: https://pagure.io/releng/fedora-scm-requests/issue/24619 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 --- Comment #7 from Michel Alexandre Salim --- (In reply to Jeremy Newton from comment #4) > Looks pretty good. I believe the spelling of "dropdown" should be > "drop-down" as rpmlint suggests, but not a blocker. > Thanks. I normally just copy-paste relevant parts of upstream's README, but yeah keeping rpmlint quiet on this would make noticing other issues easier, so I'll do this > I would query upstream to include a license file though, not a blocker > though. Definitely will do > > As well, not a blocker either, but it would be good to include the pull > request for patch0 url in a comment, possibly with a brief one line > explanation/summary of the patch. Ah yes. The URL to the patch is actually there, but I'll put a URL to the pull request itself and some description. Good call, thanks! Thanks for the review! Heh, had a mid-air collision just now when trying to submit this and also assign it to you at the same time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Jeremy Newton changed: What|Removed |Added Assignee|nob...@fedoraproject.org|alexjn...@fastmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Jeremy Newton changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #6 from Jeremy Newton --- Sorry, forgot to move to assigned -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427
Jeremy Newton changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Jeremy Newton ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v3)". 4 files have unknown
license. Detailed output of licensecheck in
/home/jeremy/packagegits/fedora-reviews/gnome-shell-extension-
argos/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
As I mentioned above, you should do this, but not a blocker
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
It would be good to add a comment that provides the url to the pull request for
patch0.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /us
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Jeremy Newton changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 --- Comment #4 from Jeremy Newton --- Looks pretty good. I believe the spelling of "dropdown" should be "drop-down" as rpmlint suggests, but not a blocker. I would query upstream to include a license file though, not a blocker though. As well, not a blocker either, but it would be good to include the pull request for patch0 url in a comment, possibly with a brief one line explanation/summary of the patch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 --- Comment #3 from Jeremy Newton --- Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 --- Comment #2 from Michel Alexandre Salim --- (In reply to Jeremy Newton from comment #1) > Would you like to swap with me? :) > > https://bugzilla.redhat.com/show_bug.cgi?id=1826034 sure! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Jeremy Newton changed: What|Removed |Added CC||alexjn...@fastmail.com Doc Type|--- |If docs needed, set a value --- Comment #1 from Jeremy Newton --- Would you like to swap with me? :) https://bugzilla.redhat.com/show_bug.cgi?id=1826034 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
