[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 --- Comment #17 from Fedora Update System --- FEDORA-2020-8216dd2d96 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 --- Comment #16 from Fedora Update System --- FEDORA-2020-dcc8e94005 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 Bug 1830767 depends on bug 1830765, which changed state. Bug 1830765 Summary: Re-Review Request: python-markups - A wrapper around various text markups https://bugzilla.redhat.com/show_bug.cgi?id=1830765 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-09-11 15:14:15 --- Comment #15 from Fedora Update System --- FEDORA-2020-acbbb269ea has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 --- Comment #14 from Fedora Update System --- FEDORA-2020-8216dd2d96 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-8216dd2d96` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8216dd2d96 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 --- Comment #13 from Fedora Update System --- FEDORA-2020-dcc8e94005 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-dcc8e94005` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-dcc8e94005 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- FEDORA-2020-acbbb269ea has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-acbbb269ea` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-acbbb269ea See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 --- Comment #11 from Fedora Update System --- FEDORA-2020-acbbb269ea has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-acbbb269ea -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 --- Comment #10 from Fedora Update System --- FEDORA-2020-dcc8e94005 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-dcc8e94005 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2020-8216dd2d96 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8216dd2d96 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 --- Comment #8 from José Matos --- (In reply to Robert-André Mauchin 🐧 from comment #7) > Do you plan of importing soon? I kind of need this package. I imported it either in the same day or the next day after your review. I did not yet build it because it depends on python-markups and I am waiting for Fabian's feedback since I have already submitted the requested update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 --- Comment #7 from Robert-André Mauchin 🐧 --- Do you plan of importing soon? I kind of need this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Robert-André Mauchin 🐧 --- No it's good Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767
--- Comment #5 from José Matos ---
(In reply to Robert-André Mauchin 🐧 from comment #4)
> - Why are you using:
>
> %{__python3} setup.py install -O1 --skip-build --root %{buildroot}
>
>
> instead of %py3_install?
Honestly? :-)
Because this is a re-review and I have reused the original spec file.
I will change it, do you want me to submit a new version just with this change?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767
--- Comment #4 from Robert-André Mauchin 🐧 ---
- Why are you using:
%{__python3} setup.py install -O1 --skip-build --root %{buildroot}
instead of %py3_install?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 --- Comment #3 from José Matos --- Thank you for the review. New versions with your suggestions incorporated at: Spec URL: https://jamatos.fedorapeople.org/retext/retext.spec SRPM URL: https://jamatos.fedorapeople.org/retext/retext-7.1.0-2.fc32.src.rpm IIRC the hash sign (#) at the %endif line was from the original code and not necessary since the conditions are small so it is always easy to see where the chunk starts. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #2 from Robert-André Mauchin ---
RPM build errors:
extra tokens at the end of %endif directive in line 34: %endif #
with_tests
extra tokens at the end of %endif directive in line 78: %endif #
with_tests
Comments at the end of the line are not supported by rpm.
- Not needed, it is handled by %transfiletrigger now:
%post
/usr/bin/update-desktop-database &> /dev/null || :
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun
/usr/bin/update-desktop-database &> /dev/null || :
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi
%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
- Use a better archive name:
Source0:
https://github.com/retext-project/retext/archive/%{version}/%{name}-%{version}.tar.gz
- Remove shebang in prep:
retext.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/ReText/__main__.py 644 /usr/bin/env python3
retext.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/ReText/converterprocess.py 644 /usr/bin/env
python3
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/retext
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
- gtk-update-icon-cache must not be invoked in %post and %posttrans for
Fedora 26 and later.
Note: icons in retext
See:
- update-desktop-database must not be invoked in %post and %postun for
Fedora 24 and later.
Note: desktop file(s) with MimeType entry in retext
See:
https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#desktop-
database
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License (v2)", "GPL
(v2 or later)". 46 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/retext/review-
retext/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop
[Bug 1830767] Re-Review Request: retext - Simple editor for Markdown and reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=1830767 José Matos changed: What|Removed |Added Depends On||1830765 Summary|Review Request: retext -|Re-Review Request: retext - |Simple editor for Markdown |Simple editor for Markdown |and reStructuredText|and reStructuredText Doc Type|--- |If docs needed, set a value --- Comment #1 from José Matos --- This is re-review since this package was already in Fedora and it was orphaned last year. I did not notice on time last year so I am bring it back here. One advantage of retext is that it supports several markup languages. This package depends on python-markups (also a re-review) and on python-markdown-math that is a new package required by the update to python-markups. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1830765 [Bug 1830765] Re-Review Request: python-markups - A wrapper around various text markups -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
