[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 --- Comment #11 from Fedora Update System --- FEDORA-2020-34281d4c2f has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-07-04 01:12:20 --- Comment #10 from Fedora Update System --- FEDORA-2020-3ab9d76046 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 --- Comment #9 from Fedora Update System --- FEDORA-2020-34281d4c2f has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-34281d4c2f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-34281d4c2f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2020-3ab9d76046 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-3ab9d76046 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-3ab9d76046 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 --- Comment #7 from Fedora Update System --- FEDORA-2020-34281d4c2f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-34281d4c2f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-3ab9d76046 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-3ab9d76046 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/luv-icon-theme -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 --- Comment #3 from Artur Iwicki --- As for executable bits being present on icon files, here's a pull request submitted upstream: https://github.com/Nitrux/luv-icon-theme/pull/223 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578 --- Comment #2 from Artur Iwicki --- Thanks for the review. Addressed the issues and updated to latest git snapshot. spec: https://svgames.pl/fedora/luv-icon-theme-0.4.9.31-2.20200623git42387fe9/luv-icon-theme.spec srpm: https://svgames.pl/fedora/luv-icon-theme-0.4.9.31-2.20200623git42387fe9/luv-icon-theme-0.4.9.31-2.20200623git42387fe9.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=46053355 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831578] Review Request: luv-icon-theme - Flat, but complex, icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1831578
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Remove these:
luv-icon-theme.noarch: E: zero-length /usr/share/icons/Luv/actions/24/dummy.txt
luv-icon-theme.noarch: E: zero-length
/usr/share/icons/Luv/actions/symbolic/dummy.txt
luv-icon-theme.noarch: E: zero-length /usr/share/icons/Luv/status/24/dummy.txt
- Remove the executable bits of these and send a patch upstream:
luv-icon-theme.noarch: E: script-without-shebang
/usr/share/icons/Luv/apps/16/qbittorrent.svg
luv-icon-theme.noarch: E: script-without-shebang
/usr/share/icons/Luv/apps/22/qbittorrent-tray.svg
luv-icon-theme.noarch: E: script-without-shebang
/usr/share/icons/Luv/apps/32/qbittorrent.svg
luv-icon-theme.noarch: E: script-without-shebang
/usr/share/icons/Luv/apps/48/qbittorrent.svg
luv-icon-theme.noarch: E: script-without-shebang
/usr/share/icons/Luv/apps/64/qbittorrent.svg
- You need to own these:
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/icons/Luv/status,
/usr/share/icons/Luv/mimetypes, /usr/share/icons/Luv/emblems,
/usr/share/icons/Luv/devices, /usr/share/icons/Luv/places,
/usr/share/icons/Luv/actions, /usr/share/icons/Luv/categories,
/usr/share/icons/Luv/emotes, /usr/share/icons/Luv/apps
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Creative Commons Attribution-
ShareAlike 4.0 International License". 1845 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/luv-icon-theme/review-luv-icon-
theme/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/icons/Luv/status,
/usr/share/icons/Luv/mimetypes, /usr/share/icons/Luv/emblems,
/usr/share/icons/Luv/devices, /usr/share/icons/Luv/places,
/usr/share/icons/Luv/actions, /usr/share/icons/Luv/categories,
/usr/share/icons/Luv/emotes, /usr/share/icons/Luv/apps
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does
