needinfo canceled: [Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
Product: Fedora Version: rawhide Component: Package Review Ankur Sinha (FranciscoD) has canceled Package Review 's request for Ankur Sinha (FranciscoD) 's needinfo: Bug 1832562: Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC) https://bugzilla.redhat.com/show_bug.cgi?id=1832562 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Ankur Sinha (FranciscoD) changed: What|Removed |Added Resolution|--- |WONTFIX Status|ASSIGNED|CLOSED Flags|fedora-review? | |needinfo?(sanjay.ankur@gmai | |l.com) | Blocks||201449 (FE-DEADREVIEW) Last Closed||2021-12-03 08:46:35 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1832562 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Ankur Sinha (FranciscoD) changed: What|Removed |Added Whiteboard||NotReady --- Comment #8 from Ankur Sinha (FranciscoD) --- I'm going to mark this as NotReady. Purusharth, please work on this and ping us when it's ready for review. Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 --- Comment #7 from Ankur Sinha (FranciscoD) --- Thanks Michael, Purusharth: please look at these comments when you have a minute. The regressions in the spec should be corrected, as I'd explained in the channel: the review is incremental so we need to make sure that issues which were already fixed in the spec should not crop up again. Then we can check to see whether the API is public/private (if private, then you drop the -devel package and only ship the binaries). Please drop a comment here when you've made some progress and we'll carry on with the review. Or find me in the channels sometime and we can go over things together too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562
Michael Schwendt changed:
What|Removed |Added
CC||bugs.mich...@gmx.net
--- Comment #6 from Michael Schwendt ---
This review request is a bit of a mystery. The spec file contains a few grave
mistakes that have been introduced since the older version found at:
https://pagure.io/tpcclib/blob/master/f/tpcclib.spec
> %package devel
> Summary: Libraries files for tpcclib development
> # Upstream only provides static libraries
> Provides: %{name}-static%{?_isa} = %{version}-static
Carefully follow
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries
since right now you would be unable to "BuildRequires: tpcclib-static" as per
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_statically_linking_executables
Also notice these two:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing
> %files devel
> %{_includedir}/*.a
> %{_includedir}/*.h
Static libraries belong into %{_libdir}
Currently, there are 34 static libraries and 34 header files. Can you tell a
bit more about the usage scenario of this package? What external software does
(or will) use these libs? Each of the header files includes a missing
"tpcclibConfig.h" which indicates that these likely are internal headers and
libs and not a public API.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|needinfo?(sanjay.ankur@gmai | |l.com) | --- Comment #5 from Ankur Sinha (FranciscoD) --- Thanks. I'll have a look at it this week. Please ping me in the channel if you need to. I should be lurking there during the day time in BST. PS: the needinfo flag is generally used when one has not received a response on the bug for a while---it sends addition notifications to uses. So not needed here, since I am actively looking at this bug :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Purusharth S changed: What|Removed |Added Flags||needinfo?(sanjay.ankur@gmai ||l.com) --- Comment #4 from Purusharth S --- Hey Ankur, Thanks for letting me know. I wasn't sure if the `fedora-review` would pick up the urls from the comments so I updated the previous one itself. Will keep that in mind :) And, thanks for the review as well. Here are the updated files: Spec URL: https://pagure.io/tpcclib/raw/version-0.7.5/f/tpcclib.spec SRPM URL: https://pagure.io/tpcclib/raw/version-0.7.5/f/tpcclib-0.7.5-1.fc32.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44424439 I've kept the licence as GPLv3 itself as per the discussion over devel. I also confirmed it with upstream over email (below) > The files with GPL 2 license were actually not included in compilation and > are now removed. > Most of the small files without license are test data which obviously cannot > be edited to contain > license, but I have omitted the license from individual code files too, > because I hope it would be sufficient to have GPL3 in the main docs, covering > the whole library. Let me know if this is okay? Also, I have some questions wrt reviewing process. Will ask that over sig irc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 --- Comment #3 from Ankur Sinha (FranciscoD) --- Ah, just noticed this. Please add new comments, there's no need to edit the initial comment. It just makes the review hard to follow. Ideally, you add comments addressing the issues that I have pointed out---to show that they have been fixed. Can you do that please? Look at this review for example: https://bugzilla.redhat.com/show_bug.cgi?id=1827957 Have you done any reviews yet, by the way? You should since reviewing is as important as adding new packages. Pick up something from here, and run fedora-review on it: https://fedoraproject.org/PackageReviewStatus/NEW.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Purusharth S changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- This is my First Package and I am being sposored by ankursinha (FranciscoD) Spec URL: https://pagure.io/tpcclib/raw/version-0.7.5/f/tpcclib.spec SRPM URL: https://pagure.io/tpcclib/raw/version-0.7.5/f/tpcclib-0.7.5-1.fc32.src.rpm Description: Tpcclib project is to develop and maintain command-line tools to processing and analyzing data collected in Turku PET Centre (TPC), University of Turku. The tpcclib project is released under GNU GPLv3. Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44424439 Fedora Account System Username:purusharths -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Purusharth S changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- This is my First Package and I am being sposored by ankursinha (FranciscoD) Spec URL: https://pagure.io/tpcclib/raw/version-0.7.5/f/tpcclib.spec SRPM URL: https://pagure.io/tpcclib/raw/version-0.7.5/f/tpcclib-0.7.5-1.fc31.src.rpm Description: Tpcclib project is to develop and maintain command-line tools to processing and analyzing data collected in Turku PET Centre (TPC), University of Turku. The tpcclib project is released under GNU GPLv3. Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44424439 Fedora Account System Username:purusharths -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Purusharth S changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- This is my First Package and I am being sposored by ankursinha (FranciscoD) Spec URL: https://pagure.io/tpcclib/raw/version-0.7.5/f/tpcclib.spec SRPM URL: //pagure.io/tpcclib/raw/version-0.7.5/f/tpcclib-0.7.5-1.fc32.src.rpm Description: Tpcclib project is to develop and maintain command-line tools to processing and analyzing data collected in Turku PET Centre (TPC), University of Turku. The tpcclib project is released under GNU GPLv3. Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44424439 Fedora Account System Username:purusharths -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Purusharth S changed: What|Removed |Added Summary|Review Request: tpcclib - |Review Request: tpcclib - |Command line tools for |Tools for processing data |processing and analyzing|from Turku PET Centre (TPC) |data collected in Turku PET | |Centre (TPC)| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
