[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 ycollet changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed|2020-11-24 19:19:55 |2020-12-12 21:32:35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 ycollet changed: What|Removed |Added Status|CLOSED |NEW Resolution|NOTABUG |--- Keywords||Reopened -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #24 from Vasiliy Glazov --- (In reply to Iñaki Ucar from comment #22) > I am interested. I didn't review this because I thought @vascom was working > on it. I can take it, but I cannot help you with the sponsoring process, > because I'm not a sponsor. As you can see review completed. But I can't sponsor ycollet because I see that he not ready to be maintainer. Every new Review Request contain spec with significant errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #23 from ycollet --- Don't waste your time on this. Personnaly, I give up .. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #22 from Iñaki Ucar --- I am interested. I didn't review this because I thought @vascom was working on it. I can take it, but I cannot help you with the sponsoring process, because I'm not a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 ycollet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2020-11-24 19:19:55 --- Comment #21 from ycollet --- Package review opened more than 5 months ago. Nobody seems to be interested ... So, I close the package review. Somebody else will had back this if somebody at fedora is interested. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #20 from ycollet --- I forgot to add systemd file in my spec file because, when I use jamulus, I start the server manually to set the directory path for jamulus to save audio files for the session. I also noticed that you add a %check section to verify the validityof the desktop file. I have converted some of my spec files to %qmake_qt5 macro too, but I missed this one :) And I noticed the use of help2man to generated a stub man page and convert to produced icons for missing resolutions. Thanks for this spec file :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #19 from Iñaki Ucar --- Ah, ok, you need a sponsor. I see now that you have several review requests and you are working with Vasily to get sponsored. Great. Some comments about my spec with respect to yours. Note that: - I package the service file that comes under 'distributions', so that the program can be launched as a server by systemd. - I add the /var/log/jamulus folder for the log files that this service generates, including a logrotate file. - I use the %qmake_qt5 macro, which automatically sets up the required flags. - I use INSTALL_ROOT to be able to call %make_install without manually installing everything. - I generate a manpage with help2man. - I create some more icon sizes. Hope it helps. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #18 from ycollet --- Thanks a lot for this spec file. I am still waiting for some more news related to this review. I am not an official packager but I am willing to become an official packager ... So, I wait ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 Iñaki Ucar changed: What|Removed |Added CC||i.uca...@gmail.com --- Comment #17 from Iñaki Ucar --- Hi, is this review alive? I was playing around with Jamulus and then I saw this review request. Here's my attempt: Spec: https://iucar.fedorapeople.org/pkgs/jamulus.spec SRPM: https://iucar.fedorapeople.org/pkgs/jamulus-3.6.0-1.fc32.src.rpm Please, feel free to take any piece of that for your spec. I can help reviewing too if needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #16 from ycollet --- Thanks for the install advice. I fixed the spec file. I also updated to jamulus-3.5.6. The developpers have fixed most of the licences problem. The link to the src rpm file: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-32-x86_64/01434101-jamulus/jamulus-3.5.6-6.fc32.src.rpm The link to ths spec file: https://raw.githubusercontent.com/ycollet/fedora-spec/master/jamulus/jamulus.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #15 from Vasiliy Glazov --- Last thing you need to use "install -p" key to preserve timestamps. You must change it but no need to rebuild at that moment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120
Vasiliy Glazov changed:
What|Removed |Added
Blocks||177841 (FE-NEEDSPONSOR)
Flags|fedora-review? |fedora-review+
--- Comment #14 from Vasiliy Glazov ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License",
"GPL (v2 or later) (with incorrect FSF address)", "BSD 3-clause "New"
or "Revised" License GPL (v2 or later) (with incorrect FSF address)",
"GPL (v2 or later)", "*No copyright* GPL (v2 or later) (with incorrect
FSF address)". 435 files have unknown license. Detailed output of
licensecheck in /home/vascom/1844120-jamulus/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Pac
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #13 from Vasiliy Glazov --- fedora-review -b 1844120 All review must be on rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #12 from ycollet --- The command line I tested: [SRPMS] $ fedora-review --verbose --mock-config fedora-32-x86_64 --rpm-spec --name jamulus Do you use some other specific flags ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #11 from Vasiliy Glazov --- I use fedora-review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #10 from ycollet --- I filed an issue upstream related to the licenses: https://github.com/corrados/jamulus/issues/341 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #9 from ycollet --- I removed INSTALL.md from doc files. I removed the opus code too (with a comment in the spec file). What script do you use to check the licence of the various files in the archive ? The link to the src rpm file: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-32-x86_64/01431054-jamulus/jamulus-3.5.5-6.fc32.src.rpm The link to the updated spec file: https://raw.githubusercontent.com/ycollet/fedora-spec/master/jamulus/jamulus.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #8 from Vasiliy Glazov --- I think you should remove opus directory from sources in %prep section to be sure that it will not bundled. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #7 from Vasiliy Glazov --- Created attachment 1695901 --> https://bugzilla.redhat.com/attachment.cgi?id=1695901&action=edit License check -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #6 from Vasiliy Glazov --- Remove INSTALL.md from %files. Install instructions from upstream should not be in package. Check real license of source files. It may be need to describe what part of code what license use. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #5 from ycollet --- The link to the src rpm file: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-32-x86_64/01429101-jamulus/jamulus-3.5.5-5.fc32.src.rpm The link to the spec file: https://raw.githubusercontent.com/ycollet/fedora-spec/master/jamulus/jamulus.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #4 from ycollet --- Hello, Thanks for the review. I totally forgot to replace %setup by %autosetup, sorry. I was focused on the fix wrt the debug package generation. I removed the Group tag and I switch from %__install to install. I corrected the desktop-file-install command. I also removed the %post and other sections. I've got this sections by digging years ago in https://src.fedoraproject.org/. But I didn't notice that the usage changed. I changed the Source0 line to download directly the release from the github page. I changed the summary and descriptions. I also checked the length of lines so as to respect the 80 symbols limit. The Obsolete line is removed. And I added the files in %doc and %license (I totally forgot to add these file). I also added a check on fedora version. For Fedora 32, I use all the security flags. For Fedora 31 and below, I remove the -fcf-protection flag because I still use this spec file to build jamulus for Fedora 30 and 31. My main machine is still on Fedora 30. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #3 from Vasiliy Glazov --- 7. Change Summary: to something more usefull without repeating name. 8. Line length in description must be 80 symbols maximum. Correct it. 9. I think Obsoletes: Jamulus <= 3.5.3-3 should be removed because wi not contain it in repos before. 10. Add license and doc files to %files section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #2 from Vasiliy Glazov --- 6. Why do you use commit if release available by direct URL? https://github.com/corrados/jamulus/archive/r3_5_5.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120
--- Comment #1 from Vasiliy Glazov ---
1. Remove Group tag.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
2. Change
%setup -qn jamulus-%{commit0}
to
%autosetup -n jamulus-%{commit0}
3. Don't use macro for "install" command
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
4. Correct desktop file install
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage
5. Remove %post, %postun and %posttrans sections. Scriptlets for desktop file
and mime not needed now.
After that I will see at build flags and why you change them.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 Vasiliy Glazov changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|vasc...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 ycollet changed: What|Removed |Added Summary|Review Request: -|acroos the internet -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
