[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 Gergely Gombos changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Gergely Gombos --- Doesn't build on armv7hl. Contacted upstream if this could be fixed or an ExcludeArch is needed. Scratch builds F32 https://koji.fedoraproject.org/koji/taskinfo?taskID=45515901 F33 https://koji.fedoraproject.org/koji/taskinfo?taskID=45515910 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #2 from Gergely Gombos --- Updated to new version and added ARM ExcludeArch. Spec URL: https://gombosg.fedorapeople.org/antimicrox/antimicroX.spec SRPM URL: https://gombosg.fedorapeople.org/antimicrox/antimicroX-3.0-1.fc32.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45616620 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 Alexander Ploumistos changed: What|Removed |Added CC||alex.ploumis...@gmail.com Assignee|nob...@fedoraproject.org|alex.ploumis...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850
--- Comment #3 from Alexander Ploumistos ---
Here are the issues that were picked up by fedora-review, I will need to take a
better look at a few other things as well, such as the licensing scheme, but
you can work on these for now:
1. Missing BR against the compiler, I guess it's gcc-c++.
2. I think I would have gone with antimicroX, antimicroX-libs and
antimicroX-devel, but I also find your separation of libantilib subpackages
reasonable. I think the shared library should either be versioned or moved. Is
it required in order to run antimicroX, to build the package, or is it just
provided in case someone wants to build some other program integrating its
functionality? When rpmlint is run on the packages, it complains:
antimicroX-libantilib.x86_64: E: invalid-soname /usr/lib64/libantilib.so
libantilib.so
Depending on how it's supposed to be used, moving it to %{_libdir}/%{name} or
%{_libdir}/libantilib/ might be the safest option.
Maybe these will help:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries
https://fedoraproject.org/wiki/Common_Rpmlint_issues#invalid-soname
3. Problems with permissions:
antimicroX.x86_64: W: spurious-executable-perm
/usr/share/doc/antimicroX/Changelog
antimicroX.x86_64: W: spurious-executable-perm
/usr/share/doc/antimicroX/README.md
antimicroX.x86_64: E: script-without-shebang
/usr/share/licenses/antimicroX/LICENSE
These three should have the executable bit removed.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions
4. File and directory ownership.
Note: No known owner of /usr/share/antimicroX/translations,
/usr/share/antimicroX/images, /usr/share/antimicroX/icons
Note: Directories without known owners: /usr/share/antimicroX/images,
/usr/share/icons/hicolor/24x24/apps,
/usr/share/antimicroX/translations, /usr/share/icons/hicolor/32x32,
/usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/64x64,
/usr/share/antimicroX/icons, /usr/share/icons/hicolor/48x48,
/usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16,
/usr/share/mime, /usr/share/icons/hicolor/24x24,
/usr/share/icons/hicolor/32x32/apps, /usr/share/mime/packages,
/usr/share/icons/hicolor/64x64/apps,
/usr/share/icons/hicolor/16x16/apps
For the directories under /usr/share/anitimicroX, I believe that changing this
line in your %files section
%dir %{_datadir}/%{name}
to
%{_datadir}/%{name}/
would solve the issue.
For the icon files, you can use something like this:
%{_datadir}/icons/hicolor/*/apps/%{name}.*
5. There are multiple licenses present, I need to verify if GPLv3+ is enough,
or if it should be a mixed license or if the effective license is one of the
others. This might take a while.
I'll get back to you if I find something else in the meantime.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #4 from Gergely Gombos --- Super, thanks! I'll work on these. 'Libantilib' is compiled along with the main app, and is not linked to by other software (more of a design pattern and a future possibility to e.g. integrate this functionality into other software like Lutris), and is required by the app to run. I'll rename to antimicroX-libs. I informed upstream about the soname versioning issue. [1] The repo had been forked from a GPLv3+ project [2], and is itself distributed as GPLv3+, so actually having a mixed license would be an issue, and upstream should be informed about it. Are you thinking about the icons? As I see (src/icons/README.txt) those were LGPLv2.1 and LGPLv3, so they are allowed to be recombined under GPLv3. [1] https://github.com/juliagoda/antimicroX/issues/118#issuecomment-643783318 [2] https://github.com/AntiMicro/antimicro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #5 from Alexander Ploumistos --- (In reply to Gergely Gombos from comment #4) > The repo had been forked from a GPLv3+ project [2], and is itself > distributed as GPLv3+, so actually having a mixed license would be an issue, > and upstream should be informed about it. > > Are you thinking about the icons? As I see (src/icons/README.txt) those were > LGPLv2.1 and LGPLv3, so they are allowed to be recombined under GPLv3. Yes, I was trying to figure out what the effective license from combining GPLv3 and LGPLv2.1 is, but I cant, I'm only getting a headache. Unless you are confident that GPLv3+ + LGPLv2+ = GPLv3+, the safest option is to use both licenses, e.g. "GPLv3+ and LGPLv2+". I still can't understand why licensecheck has README.md pegged as GPLv3, but that's not important. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #6 from Gergely Gombos --- Thanks. I am confident, since the project is distributed under GPLv3 license. LGPLv2.1 and LGPLv3 are both listed as GPL compatible [1] by FSF [2], so a mixed license is not needed if the project owner chose a GPLv3 license. The icons README simply states the original license of these files, compliant with the original licenses. [1] https://www.gnu.org/licenses/gpl-faq.html#WhatDoesCompatMean [2] https://www.gnu.org/licenses/license-list.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #7 from Gergely Gombos --- Here's a detailed compatibility matrix: https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility It also says that GPLv3 is OK for the project. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #8 from Alexander Ploumistos --- (In reply to Gergely Gombos from comment #7) > Here's a detailed compatibility matrix: > https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility > It also says that GPLv3 is OK for the project. Thanks a lot, it turns out that it's the third time I bookmark this page, I should probably give it a better name. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 Gergely Gombos changed: What|Removed |Added Flags||needinfo?(alex.ploumistos@g ||mail.com) --- Comment #9 from Gergely Gombos --- Fixed review issues. Spec URL: https://gombosg.fedorapeople.org/antimicrox/antimicroX.spec SRPM URL: https://gombosg.fedorapeople.org/antimicrox/antimicroX-3.0-1.20200617gitc6d79.fc32.src.rpm I think we shouldn't own these directories: /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16, /usr/share/mime, /usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/32x32/apps, /usr/share/mime/packages, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/16x16/apps Because they are owned by some very basic packages e.g. shared-mime-info, filesystem, hicolor-icon-theme. I don't see them being owned by other GUI packages either, but let me know if you think it would be better to own them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850
--- Comment #10 from Alexander Ploumistos ---
Hi Gergely,
I'm at work now, I will check the changes tonight.
(In reply to Gergely Gombos from comment #9)
> I think we shouldn't own these directories:
> /usr/share/icons/hicolor/24x24/apps,
> /usr/share/icons/hicolor/32x32,
> /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/64x64,
> /usr/share/icons/hicolor/48x48,
> /usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16,
> /usr/share/mime, /usr/share/icons/hicolor/24x24,
> /usr/share/icons/hicolor/32x32/apps, /usr/share/mime/packages,
> /usr/share/icons/hicolor/64x64/apps,
> /usr/share/icons/hicolor/16x16/apps
>
> Because they are owned by some very basic packages e.g. shared-mime-info,
> filesystem, hicolor-icon-theme.
> I don't see them being owned by other GUI packages either, but let me know
> if you think it would be better to own them.
We shouldn't own them. If you use something like this
%{_datadir}/icons/hicolor/*/apps/%{name}.*
you don't own the directories, just the files that antimicroX places in each of
them. Adjust "%{name}.*" to your file names.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850
--- Comment #11 from Gergely Gombos ---
Thanks! I don't think that the
%{_datadir}/icons/hicolor/*/apps/%{name}.*
syntax is any different from the current
%{_datadir}/icons/hicolor/*/apps/*
Because directory ownership is defined by %dir AFAIK.
At least, fedora-review generates the same note, too, when I tried your
suggestion.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 Alexander Ploumistos changed: What|Removed |Added Flags|needinfo?(alex.ploumistos@g | |mail.com) | --- Comment #12 from Alexander Ploumistos --- (In reply to Gergely Gombos from comment #11) > Because directory ownership is defined by %dir AFAIK. No, you can also just declare a path. > At least, fedora-review generates the same note, too, when I tried your > suggestion. That's odd, that was taken from one of the packages I've inherited and it was like that when it passed its review (a long time ago). I haven't seen an error in the automated tests for updates either. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #13 from Alexander Ploumistos --- My bad, there's a dependency on kde-filesystem. That's _somewhere_ in the packaging guidelines, but I can't find it right now, I'll have to check my bookmarks when I get home. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #14 from Alexander Ploumistos --- Got it, you need to add Requires: hicolor-icon-theme -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #15 from Gergely Gombos --- Added it! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #16 from Alexander Ploumistos --- Finally made it home, I'm currently running a local build. In the meantime, you can add a Requires: shared-mime-info if you feel that I'm running late, but I don't think there's anything else left to do, you can add it when you make the "official" build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850
Alexander Ploumistos changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #17 from Alexander Ploumistos ---
Three little things left to do before the first build, mentioned in detail in
the template text:
1. Requires: shared-mime-info
2. %license in antimicroX-libantilib-devel
3. File a blocking bug for the ExcludeArch
Everything else seems fine, package is approved!
Nicely done Gergely!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
Since antimicroX-libantilib-devel requires antimicroX-libantilib, you can just
add it to the antimicroX-libantilib %files section:
%files %{libname}
%license LICENSE
%{_libdir}/%{libname}.so.1
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/mime/packages,
/usr/share/mime
Add "Requires: shared-mime-info"
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[!]: Package is not known to require an ExcludeArch tag.
You need to file a bug once the package is approved and also mark it as
blocking
https://bugzilla.redhat.com/show_bug.cgi?id=F-ExcludeArch-ARM
Once that bug is files, add the bug number to the spec file in a comment next
to the ExcludeArch tag.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upst
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #18 from Gergely Gombos --- Will do, thanks for reviewing! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #19 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/antimicroX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #20 from Fedora Update System --- FEDORA-2020-7f022a8b41 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7f022a8b41 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #21 from Fedora Update System --- FEDORA-2020-939340c81f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-939340c81f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #23 from Fedora Update System --- FEDORA-2020-7f022a8b41 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-7f022a8b41 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7f022a8b41 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System --- FEDORA-2020-939340c81f has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-939340c81f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-939340c81f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-06-29 01:05:43 --- Comment #24 from Fedora Update System --- FEDORA-2020-939340c81f has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #25 from Fedora Update System --- FEDORA-2020-7f022a8b41 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
