[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 Mattia Verga changed: What|Removed |Added Resolution|--- |NOTABUG Blocks||201449 (FE-DEADREVIEW) Status|NEW |CLOSED Last Closed||2021-08-04 15:23:49 --- Comment #17 from Mattia Verga --- Closing as DEADREVIEW, then. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 Oden Eriksson changed: What|Removed |Added Flags|needinfo?(o...@nux.se)| --- Comment #16 from Oden Eriksson --- (In reply to Mattia Verga from comment #15) > Package never imported, resetting ticket status (it will need a fresh review > to create the repository). > > Oden, what's the status? Are you still interested in packaging this in > Fedora? Hi, I'm sorry to say I lost interest in this particular software. It's free for anyone to adopt. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 Mattia Verga changed: What|Removed |Added Assignee|ngomp...@gmail.com |nob...@fedoraproject.org Status|ASSIGNED|NEW Flags|fedora-review+ |needinfo?(o...@nux.se) --- Comment #15 from Mattia Verga --- Package never imported, resetting ticket status (it will need a fresh review to create the repository). Oden, what's the status? Are you still interested in packaging this in Fedora? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 Dan Horák changed: What|Removed |Added CC||d...@danny.cz --- Comment #14 from Dan Horák --- configure:3979: checking for EVP_sha1 in -lcrypto configure:4004: gcc -o conftest -O3 -Wall -Waggregate-return -Wcast-align -Wchar-subscripts -Wcomment -Wformat -Wimplicit -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wno-long-long -Wparentheses -Wpointer-arith -Wredundant-decls -Wreturn-type -Wswitch -Wtrigraphs -Wuninitialized -Wunused -Wwrite-strings -Wshadow -Wstrict-prototypes -Wcast-qual -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld conftest.c -lcrypto >&5 conftest.c:18:1: warning: function declaration isn't a prototype [-Wstrict-prototypes] 18 | char EVP_sha1 (); | ^~~~ conftest.c:20:1: warning: function declaration isn't a prototype [-Wstrict-prototypes] 20 | main () | ^~~~ /usr/bin/ld: /tmp/ccamYXmz.o: `EVP_sha1@@OPENSSL_1_1_0' non-PLT reloc for symbol defined in shared library and accessed from executable (rebuild file with -fPIC ?) /usr/bin/ld: final link failed: bad value collect2: error: ld returned 1 exit status ^^^ is the reason for build failing on s390x, the project's build-system doesn't use the distro-wide compiler flags, thus -fPIC is missing and the check fails -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 --- Comment #13 from Oden Eriksson --- Thank you Neal! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 Neal Gompa changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #12 from Neal Gompa --- I've sponsored you as a packager, as I've seen your work in Mageia and CentOS stuff and know you're very good at this. Congratulations on becoming a Fedora packager and welcome to the Fedora community! You can proceed to the next step in the package inclusion process. :) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Neal Gompa --- Based on the review, I think this is good to go! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058
--- Comment #9 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[-]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License 2.0", "Expat License".
9 files have unknown license. Detailed output of licensecheck in
/home/ngompa/1847058-mod_authn_otp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 --- Comment #9 from Neal Gompa --- > BuildRequires: gcc make autoconf automake I generally recommend that you make this one per line, to be nice with git diff, but I'm not going to make you change it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 --- Comment #8 from Oden Eriksson --- I was wrong. The BR is fixed now, same URL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 --- Comment #7 from Oden Eriksson --- I think these BR are pulled in by rpm-build ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 --- Comment #6 from Neal Gompa --- This package does not build because it's missing "BuildRequires: gcc" and "BuildRequires: make". Please add those. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 --- Comment #5 from Oden Eriksson --- (In reply to Neal Gompa from comment #4) > (In reply to Oden Eriksson from comment #3) > > Thanks Neal, I applied those changes. > > Can you post updated Spec and SRPM links? Yes, same as before. As in the description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 --- Comment #4 from Neal Gompa --- (In reply to Oden Eriksson from comment #3) > Thanks Neal, I applied those changes. Can you post updated Spec and SRPM links? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 --- Comment #3 from Oden Eriksson --- Thanks Neal, I applied those changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058
--- Comment #2 from Neal Gompa ---
> %{!?_httpd_apxs: %{expand: %%global _httpd_apxs
> %%{_sbindir}/apxs}}
> %{!?_httpd_mmn:%{expand: %%global _httpd_mmn%%(cat
> %{_includedir}/httpd/.mmn || echo 0-0)}}
These don't seem to be needed, they are defined and provided by the httpd-devel
package, could you please remove them?
> Source0:
> https://github.com/downloads/archiecobbs/mod-authn-otp/mod-authn-otp-%{version}.tar.gz
This URL is not valid. It seems something like works:
> Source0:%{url}/archive/%{version}/mod-authn-otp-%{version}.tar.gz
> %setup -q -n mod-authn-otp-%{version}
Please consider using "%autosetup -n mod-authn-otp-%{version}"
> make %{?_smp_mflags} CFLAGS="%{optflags} -fPIE"
Please use '%make_build' in place of "make %{?_smp_mflags}", and instead of
"%{optflags}", please consider using "%{build_cflags}".
> %doc CHANGES LICENSE README* users.sample
Please break out "LICENSE" to %license, like so:
> %doc CHANGES README* users.sample
> %license LICENSE
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 Neal Gompa changed: What|Removed |Added Version|32 |rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847058] Review Request: mod_authn_otp - One-time password authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=1847058 Oden Eriksson changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
