[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 Luya Tshimbalanga changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2020-09-06 05:43:52 --- Comment #7 from Luya Tshimbalanga --- Closing as the package is available in the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 Bug 1856589 depends on bug 1858531, which changed state. Bug 1858531 Summary: Review Request: partio - Library for reading/writing/manipulating common animation particle https://bugzilla.redhat.com/show_bug.cgi?id=1858531 What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/openshadinglanguage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 Luya Tshimbalanga changed: What|Removed |Added Depends On||1858531 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1858531 [Bug 1858531] Review Request: partio- Library for reading/writing/manipulating common animation particle -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 --- Comment #5 from Luya Tshimbalanga --- Thank you Robert-Andre! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 --- Comment #3 from Luya Tshimbalanga --- Upated files SPEC: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-rawhide-x86_64/01558161-openshadinglanguage/openshadinglanguage.spec SRPM: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-rawhide-x86_64/01558161-openshadinglanguage/openshadinglanguage-1.11.6.0-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #2 from Robert-André Mauchin --- - License should be BSD: License:BSD - Remove rpath from these binaries: openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/oslc ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/oslinfo ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/osltoy ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/testrender ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/testshade ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/testshade_dso ['/usr/lib64'] OpenImageIO-plugin-osl.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/OpenImageIO-2.1/osl.imageio.so ['/usr/lib64'] openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslcomp.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslexec.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslnoise.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslquery.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libtestshade.so.1.11.6 ['/usr/lib64'] Use: -DCMAKE_SKIP_RPATH=TRUE \ -DCMAKE_SKIP_INSTALL_RPATH=YES - Don't mix tabs and spaces: openshadinglanguage.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 14) - The description should be split to 80 characters per line: openshadinglanguage.src: E: description-line-too-long C Open Shading Language (OSL) is a small but rich language for programmable shading in advanced renderers and other applications, ideal for describing materials, lights, displacement, and pattern generation. - Own this directory: [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/OpenImageIO-2.1 Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "Public domain". 1283 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/openshadinglanguage/review- openshadinglanguage/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/OpenImageIO-2.1 [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/cmake(leatherman- devel, libssh-devel, PackageKit-Qt5-devel, libdynaplugz-devel, qaccessibilityclient-devel, cmake-filesystem, qt5-qtbase, marble- astro-devel, telepathy-qt5-devel, qjson-devel, uid_wrapper, libsavitar-devel, paraview-devel, libarcus-lulzbot-devel, marble- widget-qt5-devel, kqtquickcharts, pulseaudio-libs-devel, libarcus- devel, qjson-qt5-devel, openobex-devel), /usr/lib64/pkgconfig(ignition-transport-devel, dontpanic-devel, ignition-math-devel, uid_wrapper, pkgconf-pkg-config, libmodsecurity- devel, bemenu-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources
[Bug 1856589] Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 Luya Tshimbalanga changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Luya Tshimbalanga --- COPR repository with successful built: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-rawhide-x86_64/01553288-openshadinglanguage/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
