[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-09-25 16:38:44 --- Comment #14 from Fedora Update System --- FEDORA-2020-9c4dd47cd0 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2020-9c4dd47cd0 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9c4dd47cd0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9c4dd47cd0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2020-9c4dd47cd0 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9c4dd47cd0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 --- Comment #11 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qt-avif-image-plugin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Michel Alexandre Salim changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Michel Alexandre Salim --- That addresses the remaining issues. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 --- Comment #8 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/qt-avif-image-plugin.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/qt-avif-image-plugin-0.3.1-1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Robert-André Mauchin changed: What|Removed |Added Flags|needinfo?(zebo...@gmail.com | |) | --- Comment #9 from Robert-André Mauchin --- Thanks for the review! I added Requires for shared-mime-info and kf5-filesystem. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639
Michel Alexandre Salim changed:
What|Removed |Added
Flags||needinfo?(zebo...@gmail.com
||)
--- Comment #7 from Michel Alexandre Salim ---
Looks mostly fine, but there's a problem with directory ownership -- consider
either depending on kf5-filesystem, or if this is useful for Qt apps without
having KDE installed, just have this package own those directories too.
Also require shared-mime-info for /usr/share/mime
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
^ this seems a false positive
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 2-clause "Simplified" License",
"Expat License BSD 2-clause "Simplified" License", "Expat License",
"*No copyright* Public domain", "BSD 3-clause "New" or "Revised"
License", "ISC License". 1149 files have unknown license. Detailed
output of licensecheck in /home/michel/src/fedora/reviews/1858639-qt-
avif-image-plugin/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/mime/packages,
/usr/share/kservices5, /usr/share/mime,
/usr/share/kservices5/qimageioplugins
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 --- Comment #6 from Michel Alexandre Salim --- Ack, re-reviewing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 --- Comment #5 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/qt-avif-image-plugin.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/qt-avif-image-plugin-0.3.1-1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 --- Comment #4 from Robert-André Mauchin --- Yes I sent a PR to the maintainer, but we have a slight disagrement over the config. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 --- Comment #3 from Michel Alexandre Salim --- Created attachment 1702012 --> https://bugzilla.redhat.com/attachment.cgi?id=1702012=edit Rawhide build.log Looks like libavif in Rawhide is too old: CMake Warning at CMakeLists.txt:25 (find_package): Could not find a configuration file for package "libavif" that is compatible with requested version "0.8.0". The following configuration files were considered but not accepted: /usr/lib64/cmake/libavif/libavif-config.cmake, version: 0.7.3 /lib64/cmake/libavif/libavif-config.cmake, version: 0.7.3 -- libavif not found! Searching for local build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Michel Alexandre Salim changed: What|Removed |Added Status|NEW |ASSIGNED CC||mic...@michel-slm.name Flags||fedora-review? --- Comment #2 from Michel Alexandre Salim --- I can review this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Bug 1858639 depends on bug 1858419, which changed state. Bug 1858419 Summary: Review Request: libavif - Library for encoding and decoding .avif filesLibrary for encoding and decoding .avif files https://bugzilla.redhat.com/show_bug.cgi?id=1858419 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Robert-André Mauchin changed: What|Removed |Added Depends On||1858419 (libavif) Doc Type|--- |If docs needed, set a value --- Comment #1 from Robert-André Mauchin --- Successful build: https://copr.fedorainfracloud.org/coprs/eclipseo/avif/build/1563275/ Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1858419 [Bug 1858419] Review Request: libavif - Library for encoding and decoding .avif filesLibrary for encoding and decoding .avif files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
