[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 --- Comment #16 from Fedora Update System --- FEDORA-2020-2fedbc41d5 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-09-03 16:39:58 --- Comment #15 from Fedora Update System --- FEDORA-2020-12738c06ed has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 --- Comment #14 from Fedora Update System --- FEDORA-2020-2fedbc41d5 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-2fedbc41d5` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-2fedbc41d5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2020-12738c06ed has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-12738c06ed` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-12738c06ed See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #11 from Fedora Update System --- FEDORA-2020-2fedbc41d5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2fedbc41d5 --- Comment #12 from Fedora Update System --- FEDORA-2020-12738c06ed has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-12738c06ed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-openpsa-universalfeedcreator -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 --- Comment #9 from Remi Collet --- (In reply to Artur Iwicki from comment #8) > Thanks for the review. Please assign the ticket to yourself (required per > "fedpkg request-repo" procedures). Sorry about this, done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 Remi Collet changed: What|Removed |Added Assignee|nob...@fedoraproject.org|fed...@famillecollet.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 --- Comment #8 from Artur Iwicki --- Thanks for the review. Please assign the ticket to yourself (required per "fedpkg request-repo" procedures). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 Remi Collet changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Remi Collet --- [x]: Package complies to the Packaging Guidelines See minor TIPS above, but no blocker ** APPROVED ** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 --- Comment #6 from Remi Collet --- Created attachment 1712302 --> https://bugzilla.redhat.com/attachment.cgi?id=1712302=edit review.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 --- Comment #5 from Remi Collet --- > # Upstream repo does not contain a LICENSE file It have been recently added https://github.com/flack/UniversalFeedCreator/blob/master/LICENSE Find to add it later, on next version upgrade, ad LGPL doesn't require it to be present. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 --- Comment #4 from Remi Collet --- > sed -e 's|/lib/|/|g' -i autoload.php TIPS: generate the autoolader directly in lib (--output=lib/autoload.php) or use --basedir option to avoid having this sed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 --- Comment #3 from Artur Iwicki --- > Simpler way is to include this file from the generated autoloader I guess that works, too. > From phpcompatinfo analysis, and per PHP Guidelines, you need to require: > php-simplexml > php-date > php-pcre Thanks. Added. spec: https://svgames.pl/fedora/php-openpsa-universalfeedcreator-1.8.3.2-2/php-openpsa-universalfeedcreator.spec srpm: https://svgames.pl/fedora/php-openpsa-universalfeedcreator-1.8.3.2-2/php-openpsa-universalfeedcreator-1.8.3.2-2.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=49808924 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 --- Comment #2 from Remi Collet --- Created attachment 1712177 --> https://bugzilla.redhat.com/attachment.cgi?id=1712177=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839
Remi Collet changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||fed...@famillecollet.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
--- Comment #1 from Remi Collet ---
> # The library has a "constants.php" file and relies on autoloading it,
Indeed, in composer.json
"autoload": {
"classmap": ["lib"],
"files": ["lib/constants.php"]
},
Simpler way is to include this file from the generated autoloader, Ex:
cat << 'EOF' >>autoload.php
require_once "lib/constants.php";
EOF
IMHO, the "lib" directory is not needed in the package tree
From phpcompatinfo analysis, and per PHP Guidelines, you need to require:
php-simplexml
php-date
php-pcre
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1861839] Review Request: php-openpsa-universalfeedcreator - RSS and Atom feed generator
https://bugzilla.redhat.com/show_bug.cgi?id=1861839 Artur Iwicki changed: What|Removed |Added Blocks||1861757 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1861757 [Bug 1861757] DokuWiki 2020-07-29 "Hogfather" is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
