[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-09-20 10:40:17 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 Bug 1862798 depends on bug 1862796, which changed state. Bug 1862796 Summary: Review Request: rust-parsec-interface - Parsec interface library to communicate using the wire protocol https://bugzilla.redhat.com/show_bug.cgi?id=1862796 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-parsec-client -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798
Jared Smith changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #5 from Jared Smith ---
Package is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License 2.0",
"Apache License 2.0". 19 files have unknown license. Detailed output
of licensecheck in /tmp/1862798-rust-parsec-client/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
parsec-client-devel , rust-parsec-client+default-devel , rust-parsec-
client+no-fs-permission-check-devel , rust-parsec-client+testing-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 Peter Robinson changed: What|Removed |Added Blocks||1877893 (dbus-parsec) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1877893 [Bug 1877893] Review Request: dbus-parsec - DBus PARSEC interface -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 --- Comment #4 from Peter Robinson --- SPEC: https://pbrobinson.fedorapeople.org/rust-parsec-client.spec SRPM: https://pbrobinson.fedorapeople.org/rust-parsec-client-0.9.0-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 --- Comment #3 from Peter Robinson --- SPEC: https://pbrobinson.fedorapeople.org/rust-parsec-client.spec SRPM: https://pbrobinson.fedorapeople.org/rust-parsec-client-0.9.0-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 Jared Smith changed: What|Removed |Added Status|NEW |ASSIGNED CC||jsmith.fed...@gmail.com Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #2 from Robert-André Mauchin --- - You need to specify what you have changed with the fix-metadata.diff patch and add the PR you created for it: # Initial patched metadata # - Bump num to 0.4.0 https:// ... Patch0: parsec-client-fix-metadata.diff - Missing deps: DEBUG util.py:621: Error: DEBUG util.py:621: Problem: nothing provides requested (crate(mockstream/default) >= 0.0.3 with crate(mockstream/default) < 0.0.4) DEBUG util.py:623: (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) Please fill a new Review Request for this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 --- Comment #1 from Peter Robinson --- SPEC: https://pbrobinson.fedorapeople.org/rust-parsec-client.spec SRPM: https://pbrobinson.fedorapeople.org/rust-parsec-client-0.8.0-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 Bug 1862798 depends on bug 1862782, which changed state. Bug 1862782 Summary: Review Request: rust-derivative - Set of alternative `derive` attributes for Rust https://bugzilla.redhat.com/show_bug.cgi?id=1862782 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1862798] Review Request: rust-parsec-client - Parsec Client library for the Rust ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1862798 Peter Robinson changed: What|Removed |Added Blocks||1859994 (PARSEC) Depends On||1862796 ||(rust-parsec-interface), ||1862782 (rust-derivative) Alias||rust-parsec-client Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1859994 [Bug 1859994] Support PARSEC https://bugzilla.redhat.com/show_bug.cgi?id=1862782 [Bug 1862782] Review Request: rust-derivative - Set of alternative `derive` attributes for Rust https://bugzilla.redhat.com/show_bug.cgi?id=1862796 [Bug 1862796] Review Request: rust-parsec-interface - Parsec interface library to communicate using the wire protocol -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
