[Bug 1868017] Review Request: jaxb-fi - Implementation of the Fast Infoset Standard for Binary XML
https://bugzilla.redhat.com/show_bug.cgi?id=1868017 Fabio Valentini changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||jaxb-fi-1.2.18-1.fc33 Resolution|--- |NEXTRELEASE Last Closed||2020-08-18 21:25:10 --- Comment #6 from Fabio Valentini --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1594976 And for fedora 33: https://koji.fedoraproject.org/koji/buildinfo?buildID=1594977 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868017] Review Request: jaxb-fi - Implementation of the Fast Infoset Standard for Binary XML
https://bugzilla.redhat.com/show_bug.cgi?id=1868017 --- Comment #5 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jaxb-fi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868017] Review Request: jaxb-fi - Implementation of the Fast Infoset Standard for Binary XML
https://bugzilla.redhat.com/show_bug.cgi?id=1868017 --- Comment #4 from Fabio Valentini --- Thanks! I have corrected the License tag to ASL 2.0 and BSD and ASL 1.1. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868017] Review Request: jaxb-fi - Implementation of the Fast Infoset Standard for Binary XML
https://bugzilla.redhat.com/show_bug.cgi?id=1868017
--- Comment #3 from Mat Booth ---
Thanks! I was able to do the review now.
Issues:
1)
Please correct the license tag, it should be ASL 2.0 and BSD as indicated in
the root pom.xml.
2)
Fastinfoset bundles a class from xerxes-j2 that is ASL 1.1 licensed:
code/fastinfoset/src/main/java/com/sun/xml/fastinfoset/org/apache/xerces/util/XMLChar.java
So probably need to alter the license tag to accommodate for that and document
it at least in a comment.
Non-issues:
1)
Rpmlint reporting a transient failure to resolve github.com, I can ignore this
:-)
2)
Rpmlint reporting javadoc obsolete not provided. This can be ignored, the
javadoc package is intentionally not being generated.
Assuming you clarify the licensing situation above, then this package is
APPROVED.
Full review tool output follows below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License", "Apache License 2.0", "Apache License 1.1". 89 files have
unknown license. Detailed output of licensecheck in
/home/mbooth/fedora/1868017-jaxb-fi/licensecheck.txt
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if
[Bug 1868017] Review Request: jaxb-fi - Implementation of the Fast Infoset Standard for Binary XML
https://bugzilla.redhat.com/show_bug.cgi?id=1868017 Mat Booth changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868017] Review Request: jaxb-fi - Implementation of the Fast Infoset Standard for Binary XML
https://bugzilla.redhat.com/show_bug.cgi?id=1868017 --- Comment #2 from Fabio Valentini --- The required dependencies (jaxb-stax-ex 1.8.3 and xmlstreambuffer 1.5.9) are now available in f33+. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868017] Review Request: jaxb-fi - Implementation of the Fast Infoset Standard for Binary XML
https://bugzilla.redhat.com/show_bug.cgi?id=1868017 --- Comment #1 from Mat Booth --- Hmm, I got a build failure on F33: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project FastInfosetUtilities: Compilation failure: Compilation failure: [ERROR] /builddir/build/BUILD/jaxb-fi-1.2.18/code/utilities/src/main/java/module-info.java:[15,25] module not found: com.sun.xml.streambuffer [ERROR] /builddir/build/BUILD/jaxb-fi-1.2.18/code/utilities/src/main/java/module-info.java:[16,23] module not found: org.jvnet.staxex Do we need to review something else first? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1868017] Review Request: jaxb-fi - Implementation of the Fast Infoset Standard for Binary XML
https://bugzilla.redhat.com/show_bug.cgi?id=1868017 Mat Booth changed: What|Removed |Added Status|NEW |ASSIGNED CC||mat.bo...@redhat.com Assignee|nob...@fedoraproject.org|mat.bo...@redhat.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
