https://bugzilla.redhat.com/show_bug.cgi?id=1869109
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin 🐧 ---
- Aren't the libraries autodetected:
Requires: gtk3%{?_isa} >= %{gtk3_version}
Requires: libhandy%{?_isa} >= %{libhandy_version}
Requires: vte291%{?_isa} >= %{vte_version}
Requires: libgtop2%{?_isa}
This shouldn't be needed.
- Requires: hicolor-icon-theme to own the icons directories
- The Appdata file mist go to /isr/share/metainfo (%{_metainfodir} for us)
%{_datadir}/appdata/%{app_id}.appdata.xml
Please send a patch upstream fixing this:
data/meson.build
appstream_file = i18n.merge_file(
input: 'org.gnome.zbrown.KingsCross.appdata.xml.in',
output: 'org.gnome.zbrown.KingsCross.appdata.xml',
po_dir: '../po',
install: true,
install_dir: join_paths(get_option('datadir'), 'metainfo')
- Validate both the desktop file and the Appdata one:
BuildRequires: desktop-file-utils
BuildRequires: libappstream-glib
[…]
desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop
appstream-util validate-relax --nonet
%{buildroot}%{_metainfodir}/%{app_id}.appdata.xml
- Please add these licenses to the License field and add a comment explaining
the license breakdown:
Apache License (v2.0) or MIT license
kgx-0.2.1/src/fp-vte-util.c
kgx-0.2.1/src/fp-vte-util.h
- Use %global instead of %define:
%global gtk3_version 3.24
%global glib_version 2.58
%global vte_version 0.57
%global libhandy_version 0.0.11
%global gettext_version 0.19.8
%global app_id org.gnome.zbrown.KingsCross
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License v3.0 or
later", "Apache License (v2.0) or MIT license". 58 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/kgx/review-kgx/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requir
