[Bug 1870890] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1870890 sorensen...@tuta.io changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |DUPLICATE Last Closed||2021-02-15 22:09:35 --- Comment #9 from sorensen...@tuta.io --- *** This bug has been marked as a duplicate of bug 1928969 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1870890] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1870890 --- Comment #8 from sorensen...@tuta.io --- Spec URL: https://gitlab.com/fedora-mobile/chatty/-/raw/master/chatty.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-x86_64/01909757-chatty/chatty-0.2.0-2.fc34.src.rpm Successful Rawhide build on Copr: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1909757/ I updated to include some patches to build with the new gcc version in rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1870890] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1870890 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED CC||ke...@scrye.com Assignee|nob...@fedoraproject.org|ke...@scrye.com Flags||fedora-review? --- Comment #7 from Kevin Fenzi --- I'm happy to review this. Could you update the urls to src.rpm and spec? The ones in comment 3 seem to be 404ing now. ;( I did pull the 0.2.0-1 one from copr, but it doesn't seem to build here in mock. ;( In file included from /usr/include/glib-2.0/glib/gthread.h:32, from /usr/include/glib-2.0/glib/gasyncqueue.h:32, from /usr/include/glib-2.0/glib.h:32, from /usr/include/gtk-3.0/gdk/gdkconfig.h:13, from /usr/include/gtk-3.0/gdk/gdk.h:30, from /usr/include/gtk-3.0/gtk/gtk.h:30, from ../src/contrib/gtktypebuiltins.c:1: ../src/contrib/gtktypebuiltins.c: In function ‘gtk_sorter_order_get_type’: /usr/include/glib-2.0/glib/gatomic.h:112:5: error: argument 2 of ‘__atomic_load’ discards ‘volatile’ qualifier [-Wer ror=incompatible-pointer-types] 112 | __atomic_load (gapg_temp_atomic, &gapg_temp_newval, __ATOMIC_SEQ_CST); \ | ^ /usr/include/glib-2.0/glib/gthread.h:260:7: note: in expansion of macro ‘g_atomic_pointer_get’ 260 | (!g_atomic_pointer_get (location) && \ | ^~~~ ../src/contrib/gtktypebuiltins.c:12:7: note: in expansion of macro ‘g_once_init_enter’ 12 | if (g_once_init_enter (&g_define_type_id__volatile)) | ^ ../src/contrib/gtktypebuiltins.c: In function ‘gtk_sorter_change_get_type’: /usr/include/glib-2.0/glib/gatomic.h:112:5: error: argument 2 of ‘__atomic_load’ discards ‘volatile’ qualifier [-Wer ror=incompatible-pointer-types] 112 | __atomic_load (gapg_temp_atomic, &gapg_temp_newval, __ATOMIC_SEQ_CST); \ | ^ /usr/include/glib-2.0/glib/gthread.h:260:7: note: in expansion of macro ‘g_atomic_pointer_get’ 260 | (!g_atomic_pointer_get (location) && \ | ^~~~ ../src/contrib/gtktypebuiltins.c:32:7: note: in expansion of macro ‘g_once_init_enter’ 32 | if (g_once_init_enter (&g_define_type_id__volatile)) | ^ ../src/contrib/gtktypebuiltins.c: In function ‘gtk_filter_match_get_type’: /usr/include/glib-2.0/glib/gatomic.h:112:5: error: argument 2 of ‘__atomic_load’ discards ‘volatile’ qualifier [-Wer ror=incompatible-pointer-types] 112 | __atomic_load (gapg_temp_atomic, &gapg_temp_newval, __ATOMIC_SEQ_CST); \ | ^ /usr/include/glib-2.0/glib/gthread.h:260:7: note: in expansion of macro ‘g_atomic_pointer_get’ 260 | (!g_atomic_pointer_get (location) && \ | ^~~~ ../src/contrib/gtktypebuiltins.c:55:7: note: in expansion of macro ‘g_once_init_enter’ 55 | if (g_once_init_enter (&g_define_type_id__volatile)) | ^ ../src/contrib/gtktypebuiltins.c: In function ‘gtk_filter_change_get_type’: /usr/include/glib-2.0/glib/gatomic.h:112:5: error: argument 2 of ‘__atomic_load’ discards ‘volatile’ qualifier [-Werror=incompatible-pointer-types] 112 | __atomic_load (gapg_temp_atomic, &gapg_temp_newval, __ATOMIC_SEQ_CST); \ | ^ /usr/include/glib-2.0/glib/gthread.h:260:7: note: in expansion of macro ‘g_atomic_pointer_get’ 260 | (!g_atomic_pointer_get (location) && \ | ^~~~ ../src/contrib/gtktypebuiltins.c:75:7: note: in expansion of macro ‘g_once_init_enter’ 75 | if (g_once_init_enter (&g_define_type_id__volatile)) | ^ cc1: some warnings being treated as errors Might be it worked under gcc 10, but rawhide is now using gcc 11? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1870890] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1870890 Kevin Fenzi changed: What|Removed |Added CC||lkund...@v3.sk --- Comment #6 from Kevin Fenzi --- *** Bug 1757674 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1870890] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1870890 --- Comment #5 from Nikhil Jha --- (In reply to Elliott Sales de Andrade from comment #4) > Looks like a duplicate of bug 1757674; you may want to discuss with that > packager. Thanks! Already did this a few months ago. They said they don’t have time to work on that package anymore so the mobility sig is taking it over. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1870890] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1870890 --- Comment #4 from Elliott Sales de Andrade --- Looks like a duplicate of bug 1757674; you may want to discuss with that packager. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1870890] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1870890 --- Comment #3 from sorensen...@tuta.io --- Spec URL: https://gitlab.com/fedora-mobile/chatty/-/raw/master/chatty.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-33-x86_64/01710020-chatty/chatty-0.1.16-2.fc33.src.rpm > - I don't understand what you're doing with libjabber, especially why you > are copying it to the buildroot and install it in %files. Isn't this file > provided by libpurple? It is not provided by libpurple, unless this PR here is merged to *not* remove the symlink: https://src.fedoraproject.org/rpms/pidgin/pull-request/3 Review items have been addressed, successful build here in copr: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1710020/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1870890] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1870890
Robert-André Mauchin 🐧 changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin 🐧 ---
- Be more specific than %{_datadir}/*
%{_datadir}/glib-2.0/schemas/sm.puri.Chatty.gschema.xml
%{_datadir}/applications/sm.puri.Chatty.desktop
%{_datadir}/icons/hicolor/*/apps/sm.puri.Chatty*.svg
%{_metainfodir}/sm.puri.Chatty.metainfo.xml
%dir %{_datadir}/bash-completion
%dir %{_datadir}/bash-completion/completions
%{_datadir}/bash-completion/completions/chatty
- Validate the desktop and appdata file. Add %meson_test.
BuildRequires: libappstream-glib
BuildRequires: desktop-file-utils
[…]
%check
appstream-util validate-relax --nonet \
%{buildroot}%{_metainfodir}/*.appdata.xml
desktop-file-validate \
%{buildroot}/%{_datadir}/applications/sm.puri.Chatty.desktop
%meson_test
- I don't understand what you're doing with libjabber, especially why you are
copying it to the buildroot and install it in %files. Isn't this file provided
by libpurple?
/usr/lib64/purple-2/libjabber.so.0
/usr/lib64/purple-2/libjabber.so.0.0.0
Why is it not in the provides list?
- Requires hicolor-icon-theme to own the icons directory.
- /etc/ → %{_sysconfdir}
- Handle the lang file properly with %find_lang
%find_lang purism-chatty
[…]
%files -f purism-chatty.lang
%{_bindir}/chatty
- Delete the rpath:
chatty.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/chatty ['/tmp']
It's located at the end of src/meson.build
- Don't mix tabs and spaces:
chatty.src:8: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 3)
- Add a comment above the patch explaining why it is neded
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
= MUST items =
C/C++:
[x]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Rpath absent or only used for internal libs.
Note: See rpmlint output
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/applications(filesystem, java-runtime-decompiler, racket),
/usr/share/bash-completion(mtr, tio, dconf-editor, rkt, golang-github-
tdewolff-minify, eg, driverctl, tealdeer, zeitgeist, exa, awscli,
restic, maven, python-django-bash-completion, unar, yadifa-tools,
nitrokey-app, flatpak, subversion, cmake-data, licensecheck, lightdm,
ModemManager, lxi-tools, mercurial-py3, policycoreutils, source-
highlight, gpaste, docker-compose, cowsay, ethtool, pdfgrep, vagrant,
reprepro, hyperfine, zola, ffsend, skim, mercurial-py2, clufter-cli,
falkon, buildah, fd-find, dotnet-host, gammu, python3-catkin_tools,
etckeeper, dnf, lxc, tracker, rtags, git-annex, stress-ng, fedpkg,
bash-completion, beaker-client, breezy, devscripts-checkbashisms,
toolbox, pbuilder, exercism, swaylock, ldc, swayidle, rpmlint,
cobbler, libqmi, filesystem, fedmod, bodhi-client, docopt, devscripts,
clevis, git-delta, chocolate-doom, stratis-cli, task, python3-trezor,
git-core, libmbim, the_silver_searcher, wlogout, sway, datamash, nnn,
zypper, skopeo, bubblewrap, rpmdevtools, kmod, glib2, rpmspectool,
calf, ripgrep, cpu-x, yadifa, darcs, hstr), /usr/share/bash-
completion/completions(lastpass-cli, libnbd-bash-completion, mtr, tio,
dconf-editor, rkt, libguestfs-bash-completion, golang-github-tdewolff-
minify, eg, driverctl, tealdeer, zeitgeist, kompose, exa, awscli,
restic, firewalld, maven, python-django-bash-completion, ndctl, unar,
yadifa-tools, nitrokey-app, firejail, flatpak, subversion, cmake-data,
licensecheck, lightdm, ModemManager, lxi-tools, nordugrid-ar
[Bug 1870890] Review Request: chatty - mobile libpurple messaging client
https://bugzilla.redhat.com/show_bug.cgi?id=1870890 Nikhil Jha changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Nikhil Jha --- (oh, and as always, here's a COPR build https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1619181/) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
