[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781 Fedora Update System changed: What|Removed |Added Resolution|NEXTRELEASE |ERRATA --- Comment #9 from Fedora Update System --- FEDORA-2020-451a75cdaf has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781 --- Comment #8 from Fedora Update System --- FEDORA-2020-451a75cdaf has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-451a75cdaf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-451a75cdaf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781 --- Comment #7 from Fedora Update System --- FEDORA-2020-451a75cdaf has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-451a75cdaf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781 Zamir SUN changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-09-05 05:41:55 --- Comment #6 from Zamir SUN --- Package built in Fedora 33 and Rawhide. Closing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/lxqt-archiver -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin 🐧 --- Perfect, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781 --- Comment #3 from Zamir SUN --- Thanks. Fixed in place. I did not bump the release. SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/lxqt-archiver/lxqt-archiver.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/lxqt-archiver/lxqt-archiver-0.2.0-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781 --- Comment #2 from Robert-André Mauchin 🐧 --- - Also own these directories: [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/lxqt-archiver, /usr/libexec/lxqt- archiver -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781
Robert-André Mauchin 🐧 changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin 🐧 ---
- Not needed in the l10n subpackage since it depends on the main one
%doc CHANGELOG AUTHORS README.md
%license LICENSE
- Please BR gcc-c++ explicitly
%if 0%{?el7}
BuildRequires: devtoolset-7-gcc-c++
%else
BuildRequires: gcc-c++
%endif
- Add a comment for each patch to describe what they do:
Patch0:
https://github.com/lxqt/lxqt-archiver/commit/ecec793534c841cce935093d1e08b9aa227565a8.patch
Patch1:
https://github.com/lxqt/lxqt-archiver/commit/b968e339bebe80ddd017ddf16f70bee52261e533.patch
- Consider providing an Appdata file:
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License, Version
2", "GNU General Public License v2.0 or later", "*No copyright*
[generated file]", "GNU General Public License". 48 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/lxqt-archiver/review-lxqt-
archiver/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/lxqt-archiver, /usr/libexec/lxqt-
archiver
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=
[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781 Zamir SUN changed: What|Removed |Added CC||lxqt-sig@lists.fedoraprojec ||t.org Blocks||1839762, 1830731 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1830731 [Bug 1830731] LXQt 0.15.0: Bring lxqt-archiver into Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1839762 [Bug 1839762] LXQt: Replace ark with lxqt-archiver in compos since Fedora 33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1872781] Review Request: lxqt-archiver - A simple & lightweight desktop-agnostic Qt file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1872781 SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/lxqt-archiver/lxqt-archiver.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/lxqt-archiver/lxqt-archiver-0.2.0-1.fc32.src.rpm Description: A simple & lightweight desktop-agnostic Qt file archiver Copr build: https://copr.fedorainfracloud.org/coprs/zsun/lxqt/build/1635583/ rpmlint: $ rpmlint /home/zsun/rpmbuild/SRPMS/lxqt-archiver-0.2.0-1.fc32.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint lxqt-archiver-0.2.0-1.fc34.x86_64.rpm lxqt-archiver.x86_64: W: no-manual-page-for-binary lxqt-archiver Error checking signature of lxqt-archiver-0.2.0-1.fc34.x86_64.rpm: lxqt-archiver-0.2.0-1.fc34.x86_64.rpm: digests SIGNATURES NOT OK 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint lxqt-archiver-l10n-0.2.0-1.fc34.noarch.rpm Error checking signature of lxqt-archiver-l10n-0.2.0-1.fc34.noarch.rpm: lxqt-archiver-l10n-0.2.0-1.fc34.noarch.rpm: digests SIGNATURES NOT OK 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: zsun -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
