needinfo canceled: [Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Bruno Cornec 's needinfo: Bug 187317: Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules https://bugzilla.redhat.com/show_bug.cgi?id=187317 --- Comment #51 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules
https://bugzilla.redhat.com/show_bug.cgi?id=187317
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #49 from Robert-André Mauchin ---
- This need to be justified or fixed:
# Avoids to generate debug packages
%global debug_package %{nil}
- Again why the non standard release info:
Release:0.20201118013837.s3776M%{dist}
It should be 1.
- Not used in Fedora
Group:
- Not needed
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -u -n)
- Not available for me:
Source:
ftp://ftp.mondorescue.org/test/src/%{srcname}-%{version}.0.20201118013837.tar.gz
- I don't think we support ia64 anymore.
- Please justify this
ExclusiveArch: x86_64 i586 i386 i686 ia64
Why can't it be compiled on other arches?
- Not needed:
rm -rf $RPM_BUILD_ROOT
%clean
rm -rf $RPM_BUILD_ROOT
%defattr(-,root,root)
- The license file must be installed with %license in %files:
%license COPYING
- Is there a reason this is not noarchc it seems to be all perl and bash. You
should probably add:
BuildRequires: perl-generators
BuildRequires: perl-interpreter
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules
https://bugzilla.redhat.com/show_bug.cgi?id=187317 Bug 187317 depends on bug 476234, which changed state. Bug 476234 Summary: Review Request: mindi-busybox - Busybox version suited for Mindi https://bugzilla.redhat.com/show_bug.cgi?id=476234 What|Removed |Added Status|CLOSED |NEW Resolution|DEFERRED|--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules
https://bugzilla.redhat.com/show_bug.cgi?id=187317 --- Comment #48 from Mattia Verga --- Well, the first step if you want this review to proceed is to get mindi-busybox packaged - the old review request was closed as stalled, so you'll have to open a new one. After that, you should have a look to the packaging guidelines, I've barely looked your last .spec file, but I've already some problems (ExclusiveArch set for architectures that are no more supported by Fedora, buildroot removal...) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules
https://bugzilla.redhat.com/show_bug.cgi?id=187317 Bruno Cornec changed: What|Removed |Added Flags|needinfo?(bruno.cornec@hp.c |needinfo- |om) | --- Comment #47 from Bruno Cornec --- Sorry, seems that due ato a change in my e-mail address some of the dialog has been lost. And yes it has been a lenghty opened BR, but I'm still willing to include MondoRescue and here mindi inside Fedora, if you wish it as well. Anyway, since it has been long since the last feedback, I think it's better to start from the latest versions from both sides: SRPM: ftp://ftp.mondorescue.org/test/fedora/32/x86_64/mindi-3.3.0-0.20201118003941.s3776M.fc32.src.rpm SPEC: ftp://ftp.mondorescue.org/test/fedora/32/x86_64/mindi.spec Hopefully most of the problems are either acceptable or solved since that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules
https://bugzilla.redhat.com/show_bug.cgi?id=187317 Mattia Verga changed: What|Removed |Added CC||mattia.ve...@protonmail.com Whiteboard||STALLEDSUBMITTER Flags||needinfo?(bruno.cornec@hp.c ||om) --- Comment #46 from Mattia Verga --- Setting NEEDINFO flag to start the countdown of 30 days before review-stats closes this, just in case someone wants to resurrect this 14yo ticket... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules
https://bugzilla.redhat.com/show_bug.cgi?id=187317 Bug 187317 depends on bug 476234, which changed state. Bug 476234 Summary: Review Request: mindi-busybox - Busybox version suited for Mindi https://bugzilla.redhat.com/show_bug.cgi?id=476234 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DEFERRED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules
https://bugzilla.redhat.com/show_bug.cgi?id=187317
--- Comment #44 from Michael Schwendt bugs.mich...@gmx.net ---
The rpmlint findings (run rpmlint with option -i for more helpful
explanations):
mindi.x86_64: W: only-non-binary-in-usr-lib
mindi.x86_64: E: no-binary
False positive, and the spec file comments on that too. It's true that the
executables in PATH are only scripts, but the package cannnot be made noarch
because of the arch-specific %_libdir/mindi/ tree it creates.
However, this means the automatically generated -debuginfo package should/could
be disabled with this definition:
%global debug_package %{nil}
Currently, it's empty anyway.
mindi.x86_64: W: dangling-relative-symlink /usr/sbin/parted2fdisk
../../sbin/fdisk
mindi.x86_64: W: dangling-relative-symlink
/usr/lib64/mindi/rootfs/sbin/parted2fdisk fdisk
Two minor issues here:
* It's /usr/sbin/fdisk since Fedora 17:
http://fedoraproject.org/wiki/Features/UsrMove
* Is the missing dependency on either package util-linux or /usr/sbin/fdisk
intentional, or has it been optimised away?
mindi.src:42: W: macro-in-comment %{_docdir}
In %changelog, please escape macros using double '%%', so they never get
expanded. You want to see the macro name in the changelog, not its value, which
may change over time. Some macros even can have side-effects when expanding at
wrong locations of the spec file.
mindi.src:1266: W: mixed-use-of-spaces-and-tabs (spaces: line 1266, tab: line
4)
Somewhere deep in the %changelog, so not really an issue.
mindi.src: W: invalid-url Source0:
ftp://ftp.mondorescue.org/test/src/mindi-2.1.620130730020540.tar.gz urlopen
error ftp error: [Errno ftp error] 550 Failed to change directory.
Indeed. That tarball is not available in the src download dir.
Release: 0%{dist}
Just mentioning, first build for Fedora starts at 1 usually.
%config(noreplace) %{_sysconfdir}/%{name}
A bit sloppy, because this line includes the complete /etc/mindi directory,
even README.* files and flags everything as config file.
What else? Similar to review of mindi-busybox, being explicit in the spec file
with a comment on whether the spec file shall stay compatible with EL5 would be
good. Else the old buildroot related cruft may be removed. %defattr usage can
be dropped in either case.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules
https://bugzilla.redhat.com/show_bug.cgi?id=187317 Michael Schwendt bugs.mich...@gmx.net changed: What|Removed |Added Summary|Review Request: mindi |Review Request: mindi - ||Creation of emergency boot ||disks/CDs using your ||kernel, tools and modules -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules
https://bugzilla.redhat.com/show_bug.cgi?id=187317 --- Comment #43 from Michael Schwendt bugs.mich...@gmx.net --- The Spec URL and SRPM URL lines in review tickets make it possible to run fedora-review -b 187317 for this ticket. Spec URL: ftp://ftp.mondorescue.org/test/fedora/19/x86_64/mindi.spec SRPM URL: ftp://ftp.mondorescue.org/test/fedora/19/x86_64/mindi-2.1.620130730020540-0.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 187317] Review Request: mindi
https://bugzilla.redhat.com/show_bug.cgi?id=187317 Michael Schwendt bugs.mich...@gmx.net changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #42 from Michael Schwendt bugs.mich...@gmx.net --- Cannot find Bruno Cornec in FAS. Please maintain the FE-NEEDSPONSOR flag properly. Hidden review tickets, wrong ticket status, unclear sponsorship status - that several of the reasons for no progress. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 187317] Review Request: mindi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=187317 Bruno Cornec br...@victoria.frmug.org changed: What|Removed |Added CC||br...@victoria.frmug.org --- Comment #40 from Bruno Cornec br...@victoria.frmug.org 2011-11-18 19:14:36 EST --- The latest versions for this package are available here: ftp://ftp.mondorescue.org/test/fedora/16/x86_64/mindi-2.1.0-0.2014000556.fc16.src.rpm and ftp://ftp.mondorescue.org/test/fedora/16/x86_64/mindi.spec TIA for anyone willing to hep me having them in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
