[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-09-25 16:53:18 --- Comment #8 from Fedora Update System --- FEDORA-2020-9229f219ce has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578 Fabian Affolter changed: What|Removed |Added Blocks||1882303 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1882303 [Bug 1882303] [abrt] kismon: module(): client_rest.py:39::ModuleNotFoundError: No module named 'KismetRest' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- FEDORA-2020-9229f219ce has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9229f219ce \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9229f219ce See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-9229f219ce has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9229f219ce -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578 --- Comment #5 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-kismet-rest -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578 Andy Mender changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Andy Mender --- > Not, possible as they require a running kismet instance. Upstream is using > containers to do it but this will not work with the build system. I see... I looked at the tests and assumed it's possible to have at least a local instance running for the tests. Package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578 --- Comment #3 from Fabian Affolter --- (In reply to Andy Mender from comment #1) > I see the project has tests: > https://github.com/kismetwireless/python-kismet-rest/tree/master/tests > Can you add them as a %check step if possible? Not, possible as they require a running kismet instance. Upstream is using containers to do it but this will not work with the build system. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578 --- Comment #2 from Fabian Affolter --- (In reply to Andy Mender from comment #1) > I see the project has tests: > https://github.com/kismetwireless/python-kismet-rest/tree/master/tests > Can you add them as a %check step if possible? Not, possible as they require a running kismet instance. Upstream is using containers to do it but this will not work with the build system. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578
--- Comment #1 from Andy Mender ---
I see the project has tests:
https://github.com/kismetwireless/python-kismet-rest/tree/master/tests
Can you add them as a %check step if possible?
The rest looks good. Full review below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License". 44
files have unknown license. Detailed output of licensecheck in
/home/amender/rpmbuild/SPECS/python-kismet-rest/python-kismet-
rest/licensecheck.txt
Review: LICENSE file picked up as LGPL, but it's actually GPLv2.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes
[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1876578] Review Request: python-kismet-rest - Python API for the Kismet REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=1876578 Fabian Affolter changed: What|Removed |Added Blocks||563471 (FE-SECLAB) Doc Type|--- |If docs needed, set a value Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-kismet-rest.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-kismet-rest-2019.5.2-1.fc32.src.rpm Project URL: https://github.com/kismetwireless/python-kismet-rest Description: Python API wrapper for Kismet RESTful API interface. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=50946494 rpmlint output: $ rpmlint python-kismet-rest-2019.5.2-1.fc32.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python3-kismet-rest-2019.5.2-1.fc32.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
