[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350 --- Comment #10 from Fedora Update System --- FEDORA-2020-4a1fc702c7 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-09-25 17:01:18 --- Comment #9 from Fedora Update System --- FEDORA-2020-0db72cc4f6 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350 --- Comment #8 from Fedora Update System --- FEDORA-2020-0db72cc4f6 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-0db72cc4f6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0db72cc4f6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- FEDORA-2020-4a1fc702c7 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-4a1fc702c7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4a1fc702c7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350 --- Comment #6 from Fedora Update System --- FEDORA-2020-4a1fc702c7 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4a1fc702c7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2020-0db72cc4f6 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0db72cc4f6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350 --- Comment #4 from Mohan Boddu --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gammastep -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350 Andy Mender changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Andy Mender --- > I have no idea what that means. I'm pretty sure the scriptlets section > adheres to the guidelines. > Is it fedora-review bug? Unfortunately, I don't have much experience with packaging systemd service files, but you're right, the SPEC file adheres to the guidelines listed here: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please, ignore the warning. > That would make the package depend on `systemd` or own systemd unit > directories. > Both are wrong things to do for a simple package. I think an explicit dependency on systemd is not needed in this case. It's a part of the core system. > fedora-review seems to have trouble with any gitlab URLs :( That might be it. In the past I had issues with externally hosted packages as well and someone mentioned that it might be because fedora-review doesn't properly follow redirected routes. > Please, ignore this rpmlint error. > There's a GObject introspection import from python file which is not > supported by rpm automatic dependency generators. Thus, explicit lib > dependency. Makes sense then. The rest looks good. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350
--- Comment #2 from Aleksei Bavshin ---
(In reply to Andy Mender from comment #1)
Thanks for the review!
Updated files:
Spec URL:
https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01659102-gammastep/gammastep.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01659102-gammastep/gammastep-2.0.2-0.1.fc34.src.rpm
---
> If the gammastep-indicator subpackage is a regular Python package, it should
> (if possible) provide egg-info like so:
> > %{python3_sitelib}/gammastep-indicator-%{version}-py%{python3_version}.egg-info/
Nope, it's all autotools. To my knowledge, it's not possible to generate
egg-info with automake python module.
> - systemd_user_post is invoked in %post and systemd_user_preun in %preun
> for Systemd user units service files.
> Note: Systemd user unit service file(s) in gammastep, gammastep-indicator
> See: https://docs.fedoraproject.org/en-US/packaging-
> guidelines/Scriptlets/#_user_units
I have no idea what that means. I'm pretty sure the scriptlets section adheres
to the guidelines.
Is it fedora-review bug?
> Review: The src/gamma-control.xml file has an extra in-code legal
> disclaimer
> that resembles the MIT license. Please, have a look at it.
Fixed, thanks!
> [!]: License file installed when any subpackage combination is installed.
> Review: since the gammastep-indicator subpackage does not explicitly
> Requires
> the main gammastep package, one should add the license file to it as
> well.
Added Requires to gammastep-indicator.
> [x]: Package must own all directories that it creates.
> Note: Directories without known owners: /usr/lib/systemd/user,
> /usr/lib/systemd
> Review: please, make gammastep own these dirs or add the necessary
> Requires.
That would make the package depend on `systemd` or own systemd unit
directories.
Both are wrong things to do for a simple package.
> [x]: Sources can be downloaded from URI in Source: tag
> Note: Could not download Source0:
>
> https://gitlab.com/chinstrap/gammastep/-/archive/v2.0.2/gammastep-v2.0.2.tar.
> gz
> See: https://docs.fedoraproject.org/en-US/packaging-
> guidelines/SourceURL/
> Review: Some route redirection issue in fedora-review?
> The URL is perfectly accessible.
fedora-review seems to have trouble with any gitlab URLs :(
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
> gammastep-indicator
> Review: Is the gammastep-indicator subpackage an independent subpackage?
No, gammastep-indicator should require the main package. Thanks for catching
that.
> gammastep-indicator.x86_64: E: explicit-lib-dependency libappindicator-gtk3
Please, ignore this rpmlint error.
There's a GObject introspection import from python file which is not supported
by rpm automatic dependency generators. Thus, explicit lib dependency.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350
--- Comment #1 from Andy Mender ---
> %files indicator
> %{_bindir}/%{name}-indicator
> %{_datadir}/applications/%{name}-indicator.desktop
> %{_datadir}/icons/hicolor/scalable/apps/%{name}-status-*.svg
> %{_metainfodir}/%{name}-indicator.appdata.xml
> %{_userunitdir}/%{name}-indicator.service
> %{python3_sitelib}/%{name}_indicator/
If the gammastep-indicator subpackage is a regular Python package, it should
(if possible) provide egg-info like so:
> %{python3_sitelib}/gammastep-indicator-%{version}-py%{python3_version}.egg-info/
Please, ignore this comment if that's not the case :).
Full review below. There are quite some extra warnings from fedora-review, but
some of them might be noise.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- systemd_user_post is invoked in %post and systemd_user_preun in %preun
for Systemd user units service files.
Note: Systemd user unit service file(s) in gammastep, gammastep-indicator
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Scriptlets/#_user_units
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* GPL (v3)", "NTP License
(legal disclaimer)". 110 files have unknown license. Detailed output
of licensecheck in /home/amender/rpmbuild/SPECS/gammastep/copr-
build-1651081/review-gammastep/licensecheck.txt
Review: The src/gamma-control.xml file has an extra in-code legal
disclaimer
that resembles the MIT license. Please, have a look at it.
[!]: License file installed when any subpackage combination is installed.
Review: since the gammastep-indicator subpackage does not explicitly
Requires
the main gammastep package, one should add the license file to it as well.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/systemd/user,
/usr/lib/systemd
Review: please, make gammastep own these dirs or add the necessary
Requires.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
[Bug 1878350] Review Request: gammastep - Adjusts the color temperature of your screen according to time of day
https://bugzilla.redhat.com/show_bug.cgi?id=1878350 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
