[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 --- Comment #13 from Fedora Update System --- FEDORA-2020-f337e268d1 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 --- Comment #12 from Fedora Update System --- FEDORA-2020-9ba766e78e has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-11-15 01:49:29 --- Comment #11 from Fedora Update System --- FEDORA-2020-553ce44637 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 --- Comment #10 from Fedora Update System --- FEDORA-2020-f337e268d1 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f337e268d1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f337e268d1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 --- Comment #9 from Fedora Update System --- FEDORA-2020-553ce44637 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-553ce44637 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-553ce44637 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2020-9ba766e78e has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9ba766e78e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9ba766e78e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 --- Comment #7 from Fedora Update System --- FEDORA-2020-9ba766e78e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9ba766e78e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 --- Comment #6 from Fedora Update System --- FEDORA-2020-553ce44637 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-553ce44637 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2020-f337e268d1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f337e268d1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sweet-gtk-theme -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 --- Comment #3 from Artur Frenszek-Iwicki --- > - Not needed for a noarch package: > %global debug_package %{nil} Hm. Weird. I remember builds failing without it. Oh, I know now. It was probably before I ensured that the resulting package does not contain any of the Python helper scripts used for the build; I think rpmbuild tried to find debuginfo for those and failed. For completeness's sake: spec: https://svgames.pl/fedora/sweet-gtk-theme-1.10.5-4.20201025gita1641414/sweet-gtk-theme.spec srpm: https://svgames.pl/fedora/sweet-gtk-theme-1.10.5-4.20201025gita1641414/sweet-gtk-theme-1.10.5-4.20201025gita1641414.fc33.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=55040476 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 Robert-André Mauchin 🐧 changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #2 from Robert-André Mauchin 🐧 --- - Not needed for a noarch package: %global debug_package %{nil} - Please bump to latest comit to get fix for Cinnamon colors Package approved. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 665 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/sweet- gtk-theme/review-sweet-gtk-theme/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 Artur Frenszek-Iwicki changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Frenszek-Iwicki --- Updated to latest git snapshot - now with support for Cinnamon. spec: https://svgames.pl/fedora/sweet-gtk-theme-1.10.5-3.20201004gite3ee1783/sweet-gtk-theme.spec srpm: https://svgames.pl/fedora/sweet-gtk-theme-1.10.5-3.20201004gite3ee1783/sweet-gtk-theme-1.10.5-3.20201004gite3ee1783.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=53298809 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880731] Review Request: sweet-gtk-theme - Light and dark, colorful GTK+ theme
https://bugzilla.redhat.com/show_bug.cgi?id=1880731 Artur Frenszek-Iwicki changed: What|Removed |Added Blocks||1874849 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1874849 [Bug 1874849] Request to package sweet theme -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org