[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates
https://bugzilla.redhat.com/show_bug.cgi?id=1880848 Robin Lee changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||golang-github-rickb777-date ||-1.14.2-1.fc34 Resolution|--- |RAWHIDE Last Closed||2020-10-20 07:58:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates
https://bugzilla.redhat.com/show_bug.cgi?id=1880848 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-rickb777-date -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates
https://bugzilla.redhat.com/show_bug.cgi?id=1880848 Andy Mender changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Andy Mender --- Final Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53660391 Looks good now. Package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates
https://bugzilla.redhat.com/show_bug.cgi?id=1880848
--- Comment #2 from Robin Lee ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01710314-golang-github-rickb777-date/golang-github-rickb777-date.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01710314-golang-github-rickb777-date/golang-github-rickb777-date-1.14.2-1.fc34.src.rpm
Change:
- Update to 1.14.2
(In reply to Andy Mender from comment #1)
> Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53019328
>
> It fails on i686 and armv7hl. Please, have a look at the errors.
Fixed in 1.14.2.
>
> > Version:1.14.0
>
> Version 1.14.1 is already out, feel free to update:
> https://github.com/rickb777/date/releases/tag/v1.14.1
Updated to 1.14.2
> [ ]: Fully versioned dependency in subpackages if applicable.
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
> github-rickb777-date-devel
> Review: Not sure about this. Golang packages are auto-generated
> and the -devel package is not listed in the SPEC file.
Not needed theoretically. The golang guideline does not talk about this.
> Installation errors
> ---
> INFO: mock.py version 2.6 starting (python version = 3.8.5)...
> Start: init plugins
> INFO: selinux enabled
> Finish: init plugins
> INFO: Signal handler active
> Start: run
> Start: chroot init
> INFO: calling preinit hooks
> INFO: enabled root cache
> INFO: enabled package manager cache
> Start: cleaning package manager metadata
> Finish: cleaning package manager metadata
> INFO: enabled HW Info plugin
> Mock Version: 2.6
> INFO: Mock Version: 2.6
> Finish: chroot init
> INFO: installing package(s):
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-debuginfo-1.14.0-1.fc34.x86_64.rpm
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-devel-1.14.0-1.fc34.noarch.rpm
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-1.14.0-1.fc34.x86_64.rpm
> ERROR: Command failed:
> # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
> --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local
> --disableplugin=spacewalk install
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-debuginfo-1.14.0-1.fc34.x86_64.rpm
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-devel-1.14.0-1.fc34.noarch.rpm
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-1.14.0-1.fc34.x86_64.rpm --setopt=tsflags=nocontexts
I tested in mock that the new packages are installable.
>
>
>
> Rpmlint
> ---
> Checking: golang-github-rickb777-date-1.14.0-1.fc34.x86_64.rpm
> golang-github-rickb777-date-devel-1.14.0-1.fc34.noarch.rpm
> golang-github-rickb777-date-1.14.0-1.fc34.src.rpm
> golang-github-rickb777-date.x86_64: E:
> shared-lib-without-dependency-information /usr/bin/datetool
> Review: Could you have a look at this?
The tool is simple and does not call function in external library. As
'--as-needed' is enabled in linking so the executable finally has no
needed library.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates
https://bugzilla.redhat.com/show_bug.cgi?id=1880848
--- Comment #1 from Andy Mender ---
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53019328
It fails on i686 and armv7hl. Please, have a look at the errors.
> Version:1.14.0
Version 1.14.1 is already out, feel free to update:
https://github.com/rickb777/date/releases/tag/v1.14.1
There are some minor issues I indicated in the comments under specific review
points in the full review below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in
/home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-
github-rickb777-date/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-rickb777-date-devel
Review: Not sure about this. Golang packages are auto-generated
and the -devel package is not listed in the SPEC file.
[?]: Package functions as described.
[ ]: Latest version is packaged.
Review: mentioned in an earlier comment.
[x]: Package does not include license t
[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates
https://bugzilla.redhat.com/show_bug.cgi?id=1880848 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates
https://bugzilla.redhat.com/show_bug.cgi?id=1880848 Bug 1880848 depends on bug 1880847, which changed state. Bug 1880847 Summary: Review Request: golang-github-rickb777-plural - Simple Go API for pluralisation https://bugzilla.redhat.com/show_bug.cgi?id=1880847 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates
https://bugzilla.redhat.com/show_bug.cgi?id=1880848 Robin Lee changed: What|Removed |Added Blocks||1465889 ||(DeepinDEPackageReview), ||1828015 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1828015 [Bug 1828015] deepin-api-202008250003 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates
https://bugzilla.redhat.com/show_bug.cgi?id=1880848 Robin Lee changed: What|Removed |Added Depends On||1880847 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1880847 [Bug 1880847] Review Request: golang-github-rickb777-plural - Simple Go API for pluralisation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
