[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381 Robin Lee changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||dtkgui-5.2.2.18-1.fc34 Resolution|--- |RAWHIDE Last Closed||2020-12-01 10:41:46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381 --- Comment #7 from Andy Mender --- Got it! Thanks for the swift reply! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381 Robin Lee changed: What|Removed |Added Flags|needinfo?(robinlee.sysu@gma | |il.com) | --- Comment #6 from Robin Lee --- (In reply to Andy Mender from comment #5) > I see the package hasn't been imported yet. Need any help with it? The package has been built in a side tag. It will be pushed with the whole new DDE packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381 Andy Mender changed: What|Removed |Added Flags||needinfo?(robinlee.sysu@gma ||il.com) --- Comment #5 from Andy Mender --- I see the package hasn't been imported yet. Need any help with it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dtkgui -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381 Andy Mender changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Andy Mender --- Koji build for updated SPEC/SRPM: https://koji.fedoraproject.org/koji/taskinfo?taskID=52107534 I re-ran fedora-review. Looks good. Source checksums match now as well: > Source checksums > > https://github.com/linuxdeepin/dtkgui/archive/5.2.2.15/dtkgui-5.2.2.15.tar.gz > : > CHECKSUM(SHA256) this package : > 7f6bccc6807a15525ba9bebc308c2f7ead8e4aa11864fd7a67fd66bf954b61de > CHECKSUM(SHA256) upstream package : > 7f6bccc6807a15525ba9bebc308c2f7ead8e4aa11864fd7a67fd66bf954b61de Package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381
--- Comment #2 from Robin Lee ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01681792-dtkgui/dtkgui.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01681792-dtkgui/dtkgui-5.2.2.15-2.fc34.src.rpm
(In reply to Andy Mender from comment #1)
> Koji build from mentioned side tag:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=52041656
>
> > Name: dtkgui
> > Version: 5.2.2.15
> > Release:1%{?dist}
> > Summary:Deepin dtkgui
> > License:LGPLv3+
> > URL:https://github.com/linuxdeepin/dtkgui
>
> Could you align the Version field like the other fields?
Fixed.
>
> > # no-op since Fedora 28
> > %ldconfig_scriptlets
>
> This can/should be removed per
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/
> #_linker_configuration_files
Removed.
>
> > %changelog
> > * Thu Jun 09 2020 uoser - 5.2.2.1-1
> > - Update to 5.2.2.1
>
> The %changelog entry is incorrect. June 9th was a Tuesday.
Fixed.
>
> [!]: Package requires other packages for directories it uses.
> Note: No known owner of /usr/libexec/dtk5
> Review: Which packages provides this directory? dtkcore?
> [!]: Package must own all directories that it creates.
> Note: Directories without known owners: /etc/dbus-1/system.d,
> /usr/libexec/dtk5, /etc/dbus-1
> Review: As above. Where applicable, either add missing Requires
> or make your package own the directories.
Will let dtkcore own /usr/libexec/dtk5.
> = EXTRA items =
>
> Generic:
> [!]: Rpmlint is run on all installed packages.
> Note: Mock build failed
> See: https://docs.fedoraproject.org/en-US/packaging-
> guidelines/#_use_rpmlint
Only installable with dtkcore from the side tag.
> Source checksums
>
> https://github.com/linuxdeepin/dtkgui/archive/5.2.2.15/dtkgui-5.2.2.15.tar.
> gz :
> CHECKSUM(SHA256) this package :
> 59d65f9596077b8c5f3bbd603797197dab7b6b6b331ba197e6a060fd5301211d
> CHECKSUM(SHA256) upstream package :
> 7f6bccc6807a15525ba9bebc308c2f7ead8e4aa11864fd7a67fd66bf954b61de
> diff -r also reports differences
Re-downloaded.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381
--- Comment #1 from Andy Mender ---
Koji build from mentioned side tag:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52041656
> Name: dtkgui
> Version: 5.2.2.15
> Release:1%{?dist}
> Summary:Deepin dtkgui
> License:LGPLv3+
> URL:https://github.com/linuxdeepin/dtkgui
Could you align the Version field like the other fields?
> # no-op since Fedora 28
> %ldconfig_scriptlets
This can/should be removed per
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_linker_configuration_files
> %changelog
> * Thu Jun 09 2020 uoser - 5.2.2.1-1
> - Update to 5.2.2.1
The %changelog entry is incorrect. June 9th was a Tuesday.
Full review below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in
/home/amender/rpmbuild/SPECS/dtkgui/dtkgui/diff.txt
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License (v3
or later)". 52 files have unknown license. Detailed output of
licensecheck in
/home/amender/rpmbuild/SPECS/dtkgui/dtkgui/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/libexec/dtk5
Review: Which packages provides this directory? dtkcore?
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/dbus-1/system.d,
/usr/libexec/dtk5, /etc/dbus-1
Review: As above. Where applicable, either add missing Requires
or make your package own the directories.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
Review: yes, but see earlier comment.
[x]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
Review: Should deepin-gui-settings have a desktop file?
[x]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %desc
[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381 Robin Lee changed: What|Removed |Added Blocks||1465889 ||(DeepinDEPackageReview), ||1827715 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1827715 [Bug 1827715] dtkwidget-5.2.2.15 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881381] Review Request: dtkgui - Deepin dtkgui
https://bugzilla.redhat.com/show_bug.cgi?id=1881381 Robin Lee changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01680909-dtkgui/dtkgui.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01680909-dtkgui/dtkgui-5.2.2.15-1.fc34.src.rpm Description: Dtkgui is the GUI module for DDE look and feel. Fedora Account System Username: cheeselee -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
