[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 Andy Mender changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2020-11-24 20:29:37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pylibgamerzilla -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 Andy Mender changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #9 from Andy Mender --- You're very welcome! Looks good now. Package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 --- Comment #8 from Dennis Payne --- Spec URL: https://raw.githubusercontent.com/dulsi/pylibgamerzilla/master/pylibgamerzilla.spec SRPM URL: http://identicalsoftware.com/gamerzilla/pylibgamerzilla-0.0.1-4.fc32.src.rpm I should have remembered the cmake change. I had to change another game I package because of that. Thanks for your help. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 --- Comment #7 from Andy Mender --- Created attachment 1718740 --> https://bugzilla.redhat.com/attachment.cgi?id=1718740=edit SPEC file with fixes Fixed my %changelog entry and replaced %define with %global -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922
--- Comment #6 from Andy Mender ---
Unfortunately, it still fails:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52736388
This part of the build log is revealing:
> + cp /builddir/build/BUILD/pylibgamerzilla-0.0.1/_gamerzilla.so
> /builddir/build/BUILDROOT/pylibgamerzilla-0.0.1-3.fc34.x86_64/usr/lib64/python3.9/site-packages/
> cp: cannot stat '/builddir/build/BUILD/pylibgamerzilla-0.0.1/_gamerzilla.so':
> No such file or directory
> error: Bad exit status from /var/tmp/rpm-tmp.38Ay73 (%install)
> RPM build errors:
> Bad exit status from /var/tmp/rpm-tmp.38Ay73 (%install)
> Child return code was: 1
I did some digging and remembered that in-source cmake builds are no longer the
default and that's how this SPEC file is drafted. That's why it works with
rpmbuild on Fedora 32, but fails on Fedora 34 in Koji and local mock
environments. More info here:
- https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/
- https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds
I uploaded an improved SPEC file. Here's a passing Koji build from it:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52737176
> * Sat Oct 03 2020 Dennis Payne - 0.0.1-3
> - Add another missing build requires
>
> * Sat Oct 03 2020 Dennis Payne - 0.0.1-2
> - Add missing build requires
Here it's a good idea to note which BuildRequires was added when.
Full review for the updated SPEC file:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Review: internal to the package. Ignore warning.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 3 files have unknown
license. Detailed output of licensecheck in
/home/amender/rpmbuild/SPECS/pylibgamerzilla/pylibgamerzilla/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
Review: see earlier comment.
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 --- Comment #5 from Andy Mender --- Created attachment 1718727 --> https://bugzilla.redhat.com/attachment.cgi?id=1718727=edit Updated SPEC file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 --- Comment #4 from Dennis Payne --- Spec URL: https://raw.githubusercontent.com/dulsi/pylibgamerzilla/master/pylibgamerzilla.spec SRPM URL: http://identicalsoftware.com/gamerzilla/pylibgamerzilla-0.0.1-3.fc32.src.rpm Hopefully this one builds. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 --- Comment #3 from Andy Mender --- Koji build from new SRPM: https://koji.fedoraproject.org/koji/taskinfo?taskID=52706363 Unfortunately, it still fails. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 --- Comment #2 from Dennis Payne --- Spec URL: https://raw.githubusercontent.com/dulsi/pylibgamerzilla/master/pylibgamerzilla.spec SRPM URL: http://identicalsoftware.com/gamerzilla/pylibgamerzilla-0.0.1-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 --- Comment #1 from Andy Mender --- Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=52703660 The build fails on all supported architectures with cmake errors related to swig. Could you have a look at them? CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:797 (message): None of the required 'gamerzilla' found Call Stack (most recent call first): CMakeLists.txt:13 (PKG_SEARCH_MODULE) CMake Deprecation Warning at /usr/share/cmake/Modules/UseSWIG.cmake:593 (message): SWIG_ADD_MODULE is deprecated. Use SWIG_ADD_LIBRARY instead. Call Stack (most recent call first): CMakeLists.txt:22 (SWIG_ADD_MODULE) -- Configuring incomplete, errors occurred! See also "/builddir/build/BUILD/pylibgamerzilla-0.0.1/x86_64-redhat-linux-gnu/CMakeFiles/CMakeOutput.log". The SPEC file looks okay in general, but doesn't build in a Rawhide/F34 mock environment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884922] Review Request: pylibgamerzilla - Python integration with gamerzilla library
https://bugzilla.redhat.com/show_bug.cgi?id=1884922 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
