[Bug 1885039] Review Request: python-dkimpy - DKIM, ARC, and TLSRPT email signing and verification
https://bugzilla.redhat.com/show_bug.cgi?id=1885039 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2020-10-19 18:13:02 --- Comment #6 from Fedora Update System --- FEDORA-2020-9d4ef73a14 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885039] Review Request: python-dkimpy - DKIM, ARC, and TLSRPT email signing and verification
https://bugzilla.redhat.com/show_bug.cgi?id=1885039 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2020-9d4ef73a14 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9d4ef73a14 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885039] Review Request: python-dkimpy - DKIM, ARC, and TLSRPT email signing and verification
https://bugzilla.redhat.com/show_bug.cgi?id=1885039 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-dkimpy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885039] Review Request: python-dkimpy - DKIM, ARC, and TLSRPT email signing and verification
https://bugzilla.redhat.com/show_bug.cgi?id=1885039
Andy Mender changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Andy Mender ---
> %description
> dkimpy is a library that implements DKIM (DomainKeys Identified Mail) email
> signing and
> verification.
The first line of the %description is still too long. Try to split it like
this:
%description
dkimpy is a library that implements DKIM (DomainKeys Identified Mail) email
signing and verification.
> %package -n python3-%{pypi_name}
> Summary:%{summary}
> %{?python_provide:%python_provide python3-%{pypi_name}}
Here, one should use the %py_provides macro:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro
You can do it on package import. The rest looks okay. Package approved!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885039] Review Request: python-dkimpy - DKIM, ARC, and TLSRPT email signing and verification
https://bugzilla.redhat.com/show_bug.cgi?id=1885039 --- Comment #2 from Neal Gompa --- I've updated the SRPM and SPEC with the requested changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885039] Review Request: python-dkimpy - DKIM, ARC, and TLSRPT email signing and verification
https://bugzilla.redhat.com/show_bug.cgi?id=1885039 --- Comment #1 from Andy Mender --- Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53211994 > BuildRequires: python3-devel > BuildRequires: python3dist(aiodns) > BuildRequires: python3dist(authres) > BuildRequires: python3dist(authres) > BuildRequires: python3dist(dnspython) >= 1.16 > BuildRequires: python3dist(pynacl) > BuildRequires: python3dist(pynacl) authres and pynacl are listed twice. Quite a bit of files use the zlib/libpng license: zlib/libpng license --- dkimpy-1.0.5/LICENSE dkimpy-1.0.5/dkim/__init__.py dkimpy-1.0.5/dkim/arcsign.py dkimpy-1.0.5/dkim/arcverify.py dkimpy-1.0.5/dkim/asn1.py dkimpy-1.0.5/dkim/asyncsupport.py dkimpy-1.0.5/dkim/canonicalization.py dkimpy-1.0.5/dkim/crypto.py dkimpy-1.0.5/dkim/dkimsign.py dkimpy-1.0.5/dkim/dkimverify.py dkimpy-1.0.5/dkim/dknewkey.py dkimpy-1.0.5/dkim/dnsplug.py dkimpy-1.0.5/dkim/tests/__init__.py dkimpy-1.0.5/dkim/tests/test_arc.py dkimpy-1.0.5/dkim/tests/test_canonicalization.py dkimpy-1.0.5/dkim/tests/test_crypto.py dkimpy-1.0.5/dkim/tests/test_dkim.py dkimpy-1.0.5/dkim/tests/test_dkim_ed25519.py dkimpy-1.0.5/dkim/tests/test_dkim_rsavariants.py dkimpy-1.0.5/dkim/tests/test_dkim_tlsrpt.py dkimpy-1.0.5/dkim/tests/test_dnsplug.py dkimpy-1.0.5/dkim/tests/test_util.py dkimpy-1.0.5/dkim/util.py dkimpy-1.0.5/setup.py Perhaps the correct license tag is "zlib" and not "BSD" in this case? Or use both and explain the license breakdown briefly in a comment above the License field? From rpmlint: python3-dkimpy.noarch: E: description-line-too-long C dkimpy is a library that implements DKIM (DomainKeys Identified Mail) email signing and python3-dkimpy.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/dkim/arcsign.py 644 /usr/bin/env python python3-dkimpy.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/dkim/arcverify.py 644 /usr/bin/env python python3-dkimpy.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/dkim/dkimsign.py 644 /usr/bin/env python python3-dkimpy.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/dkim/dkimverify.py 644 /usr/bin/env python python3-dkimpy.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/dkim/dknewkey.py 644 /usr/bin/python python-dkimpy.src: E: description-line-too-long C dkimpy is a library that implements DKIM (DomainKeys Identified Mail) email signing and I think you need to remove the shebang in a couple of files or make them executable. Full review below: Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "zlib/libpng license". 40 files have unknown license. Detailed output of licensecheck in /home/amender/rpmbuild/SPECS/python-dkimpy/python- dkimpy/licensecheck.txt Review: Covered in an earlier comment. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it
[Bug 1885039] Review Request: python-dkimpy - DKIM, ARC, and TLSRPT email signing and verification
https://bugzilla.redhat.com/show_bug.cgi?id=1885039 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885039] Review Request: python-dkimpy - DKIM, ARC, and TLSRPT email signing and verification
https://bugzilla.redhat.com/show_bug.cgi?id=1885039 Neal Gompa changed: What|Removed |Added Blocks||1885040 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1885040 [Bug 1885040] Review Request: python-authheaders - A library wrapping email authentication header verification and generation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
