[Bug 1887709] mamba - Virtual Midi Keyboard for Jack Audio Connection Kit
https://bugzilla.redhat.com/show_bug.cgi?id=1887709 ycollet changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2020-11-24 19:21:05 --- Comment #9 from ycollet --- obody seems to be interested ... So, I close the package review. Somebody else will had back this if somebody at fedora is interested. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887709] mamba - Virtual Midi Keyboard for Jack Audio Connection Kit
https://bugzilla.redhat.com/show_bug.cgi?id=1887709 --- Comment #8 from Artur Frenszek-Iwicki --- I think in this case it would be preferable to have Mamba, without the git submodule, as Source0, and to have libxputty as Source1. You can add a macro (e.g. "%global libxputty_version") to store the version/commit hash of the bundled library. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887709] mamba - Virtual Midi Keyboard for Jack Audio Connection Kit
https://bugzilla.redhat.com/show_bug.cgi?id=1887709 --- Comment #7 from ycollet --- Maba uses a submodule: libxputty. And when you use the download link of github to get the source, you don't get the submodule sources. That's a github problem which poses problem for many project. That's why I use a separate script to get the source code of mamba (including the submodule). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887709] mamba - Virtual Midi Keyboard for Jack Audio Connection Kit
https://bugzilla.redhat.com/show_bug.cgi?id=1887709
Christoph Karl changed:
What|Removed |Added
CC||pampelm...@gmx.at
--- Comment #6 from Christoph Karl ---
Seems the following is still missing:
- Use a link for source:
Source0:
https://github.com/brummer10/Mamba/archive/v%{version}/Mamba-%{version}.tar.gz
Is there a reason why you want to use a script for downloading the sources?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887709] mamba - Virtual Midi Keyboard for Jack Audio Connection Kit
https://bugzilla.redhat.com/show_bug.cgi?id=1887709 --- Comment #5 from ycollet --- I packaged libsmf and submitted a new package review here: https://bugzilla.redhat.com/show_bug.cgi?id=1895696 I also completed the spec file for the mamba package. I fixed all the comment everybody made in the package review. Except one for the moment: I didn't package separately the submodule of the git repo. libXputty is a wrapper around cairo. You can have a look at the repository: https://github.com/brummer10/libxputty This library has no official version number, it's compiled as a static library and is included as a submodule in various brummer10 plugins at different commit. So, if we package libxputty, we will need to package to with various commit number as a version number. So, let's wait until brummer10 makes an official release of this library. The fixed mamba spec file is here: https://raw.githubusercontent.com/ycollet/fedora-spec/master/guitarix/mamba.spec The new sec rpm file is here: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-33-x86_64/01746642-mamba/mamba-1.7-3.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
